Attachment 104159 Details for Bug 25309 – Bug 25309: Limit size of streetnumber field to 10

[patch] Bug 25309: Limit size of streetnumber field to 10

Bug-25309-Limit-size-of-streetnumber-field-to-10.patch (text/plain), 3.31 KB, created by Katrin Fischer on 2020-05-01 22:33:43 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2020-05-01 22:33:43 UTC

Size: 3.31 KB

patch

obsolete

>From 5e1b391c13bb204a963583676b9cda66befb123d Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Wed, 29 Apr 2020 14:57:57 +0200
>Subject: [PATCH] Bug 25309: Limit size of streetnumber field to 10
>
>It's its size in DB (varchar(10))
>
>Test plan:
>Create or editing a patron and confirm that you fill in more than 10
>characters in the streetnumber field
>Save
>=> The patron has been correctly created/updated
>
>Signed-off-by: David Roberts <david@koha-ptfs.co.uk>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> .../intranet-tmpl/prog/en/includes/member-main-address-style-de.inc     | 2 +-
> .../intranet-tmpl/prog/en/includes/member-main-address-style-fr.inc     | 2 +-
> .../intranet-tmpl/prog/en/includes/member-main-address-style-us.inc     | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/member-main-address-style-de.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/member-main-address-style-de.inc
>index 818d7c6317..0d0f25cf0b 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/member-main-address-style-de.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/member-main-address-style-de.inc
>@@ -43,7 +43,7 @@
>       <label for="streetnumber">
>       [% END %]
>       Street number: </label>
>-        <input type="text" id="streetnumber" name="streetnumber" size="5" value="[% patron.streetnumber | html %]" />
>+        <input type="text" id="streetnumber" name="streetnumber" size="5" maxlength="10" value="[% patron.streetnumber | html %]" />
> [% IF ( mandatorystreetnumber ) %]<span class="required">Required</span>[% END %]
>     </li>
>         [% END %]
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/member-main-address-style-fr.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/member-main-address-style-fr.inc
>index a79df88123..0bf679ea12 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/member-main-address-style-fr.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/member-main-address-style-fr.inc
>@@ -9,7 +9,7 @@
>                 <label for="streetnumber">
>             [% END %]
>                 Street number: </label>
>-                <input type="text" id="streetnumber" name="streetnumber" size="5" value="[% patron.streetnumber | html %]" />
>+                <input type="text" id="streetnumber" name="streetnumber" size="5" maxlength="10" value="[% patron.streetnumber | html %]" />
>             [% IF ( mandatorystreetnumber ) %]<span class="required">Required</span>[% END %]
>         </li>
>     [% END %]
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/member-main-address-style-us.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/member-main-address-style-us.inc
>index 0db6e834dd..bb6002cf1b 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/member-main-address-style-us.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/member-main-address-style-us.inc
>@@ -8,7 +8,7 @@
>       <label for="streetnumber">
>       [% END %]
>       Street number: </label>
>-        <input type="text" id="streetnumber" name="streetnumber" size="5" value="[% patron.streetnumber | html %]" />
>+        <input type="text" id="streetnumber" name="streetnumber" size="5" maxlength="10" value="[% patron.streetnumber | html %]" />
> [% IF ( mandatorystreetnumber ) %]<span class="required">Required</span>[% END %]
>     </li>
>         [% END %]
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 25309: 103889 | 103933 | 103956 | 104159