Bugzilla – Attachment 104164 Details for
Bug 25341
When adding a single item to course reserves, ignore whitespace
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 25341: Remove whitespace from barcode in add_items.pl
Bug-25341-Remove-whitespace-from-barcode-in-addite.patch (text/plain), 1.16 KB, created by
Katrin Fischer
on 2020-05-02 01:14:38 UTC
(
hide
)
Description:
Bug 25341: Remove whitespace from barcode in add_items.pl
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2020-05-02 01:14:38 UTC
Size:
1.16 KB
patch
obsolete
>From d516e6ee4944bb5e26e36ee61adc823a92af4f8a Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Fri, 1 May 2020 17:01:11 +0000 >Subject: [PATCH] Bug 25341: Remove whitespace from barcode in add_items.pl > >TEST PLAN: >1. Go to course reserves and trying adding a course with a barcode that has some leading/trailing whitespace. >2. It doesnt work >3. Apply patch and restart_all >4. Try again with leading/trailing whitespace, it should work. > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > course_reserves/add_items.pl | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/course_reserves/add_items.pl b/course_reserves/add_items.pl >index 3e98570f33..33763d8ee9 100755 >--- a/course_reserves/add_items.pl >+++ b/course_reserves/add_items.pl >@@ -42,6 +42,8 @@ my $return = $cgi->param('return') || ''; > my $itemnumber = $cgi->param('itemnumber') || ''; > my $is_edit = $cgi->param('is_edit') || ''; > >+$barcode =~ s/^\s*|\s*$//g; #remove leading/trailing whitespace >+ > my $item = Koha::Items->find( { ( $itemnumber ? ( itemnumber => $itemnumber ) : ( barcode => $barcode ) ) } ); > $itemnumber = $item->id if $item; > >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 25341
:
104131
| 104164