Attachment 104246 Details for Bug 19532 – Bug 19532: Recalls objects and tests

[patch] Bug 19532: Recalls objects and tests

Bug-19532-Recalls-objects-and-tests.patch (text/plain), 19.65 KB, created by Aleisha Amohia on 2020-05-04 06:16:37 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Aleisha Amohia

Created: 2020-05-04 06:16:37 UTC

Size: 19.65 KB

patch

obsolete

>From 8cbea9689bf5f68f0aed9738415e6193b019fd0a Mon Sep 17 00:00:00 2001
>From: Aleisha Amohia <aleishaamohia@hotmail.com>
>Date: Wed, 22 Apr 2020 07:35:47 +0000
>Subject: [PATCH] Bug 19532: Recalls objects and tests
>
>Getter and setter methods and other object methods for Koha Recalls,
>plus tests for these
>---
> C4/Letters.pm                |   1 +
> Koha/Recall.pm               | 417 +++++++++++++++++++++++++++++++++++++++++++
> Koha/Recalls.pm              |  53 ++++++
> Koha/Schema/Result/Recall.pm |  38 ++++
> t/db_dependent/Koha/Recall.t | 157 ++++++++++++++++
> 5 files changed, 666 insertions(+)
> create mode 100644 Koha/Recall.pm
> create mode 100644 Koha/Recalls.pm
> create mode 100644 t/db_dependent/Koha/Recall.t
>
>diff --git a/C4/Letters.pm b/C4/Letters.pm
>index 1036c461f31..bfb0e7e2686 100644
>--- a/C4/Letters.pm
>+++ b/C4/Letters.pm
>@@ -757,6 +757,7 @@ sub _parseletter_sth {
>     ($table eq 'subscription') ? "SELECT * FROM $table WHERE subscriptionid = ?" :
>     ($table eq 'serial') ? "SELECT * FROM $table WHERE serialid = ?" :
>     ($table eq 'problem_reports') ? "SELECT * FROM $table WHERE reportid = ?" :
>+    ($table eq 'recalls') ? "SELECT * FROM $table WHERE recall_id = ?" :
>     undef ;
>     unless ($query) {
>         warn "ERROR: No _parseletter_sth query for table '$table'";
>diff --git a/Koha/Recall.pm b/Koha/Recall.pm
>new file mode 100644
>index 00000000000..b2006c7a1d0
>--- /dev/null
>+++ b/Koha/Recall.pm
>@@ -0,0 +1,417 @@
>+package Koha::Recall;
>+
>+# Copyright 2020 Aleisha Amohia <aleisha@catalyst.net.nz>
>+#
>+# This file is part of Koha.
>+#
>+# Koha is free software; you can redistribute it and/or modify it
>+# under the terms of the GNU General Public License as published by
>+# the Free Software Foundation; either version 3 of the License, or
>+# (at your option) any later version.
>+#
>+# Koha is distributed in the hope that it will be useful, but
>+# WITHOUT ANY WARRANTY; without even the implied warranty of
>+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>+# GNU General Public License for more details.
>+#
>+# You should have received a copy of the GNU General Public License
>+# along with Koha; if not, see <http://www.gnu.org/licenses>.
>+
>+use Modern::Perl;
>+
>+use Koha::Database;
>+use Koha::DateUtils;
>+
>+use base qw(Koha::Object);
>+
>+=head1 NAME
>+
>+Koha::Recall - Koha Recall Object class
>+
>+=head1 API
>+
>+=head2 Internal methods
>+
>+=cut
>+
>+=head3 biblio
>+
>+    my $biblio = $recall->biblio;
>+
>+Returns the related Koha::Biblio object for this recall.
>+
>+=cut
>+
>+sub biblio {
>+    my ( $self ) = @_;
>+    my $biblio_rs = $self->_result->biblio;
>+    return Koha::Biblio->_new_from_dbic( $biblio_rs );
>+}
>+
>+=head3 item
>+
>+    my $item = $recall->item;
>+
>+Returns the related Koha::Item object for this recall.
>+
>+=cut
>+
>+sub item {
>+    my ( $self ) = @_;
>+    my $item_rs = $self->_result->item;
>+    return Koha::Item->_new_from_dbic( $item_rs );
>+}
>+
>+=head3 patron
>+
>+    my $patron = $recall->patron;
>+
>+Returns the related Koha::Patron object for this recall.
>+
>+=cut
>+
>+sub patron {
>+    my ( $self ) = @_;
>+    my $patron_rs = $self->_result->borrower;
>+    return Koha::Patron->_new_from_dbic( $patron_rs );
>+}
>+
>+=head3 library
>+
>+    my $library = $recall->library;
>+
>+Returns the related Koha::Library object for this recall.
>+
>+=cut
>+
>+sub library {
>+    my ( $self ) = @_;
>+    my $library_rs = $self->_result->branch;
>+    return Koha::Library->_new_from_dbic( $library_rs );
>+}
>+
>+=head3 checkout
>+
>+    my $checkout = $recall->checkout;
>+
>+Returns the related Koha::Checkout object for this recall.
>+
>+=cut
>+
>+sub checkout {
>+    my ( $self ) = @_;
>+    $self->{_checkout} ||= Koha::Checkouts->find({ itemnumber => $self->itemnumber });
>+
>+    unless ( $self->item_level_recall ) {
>+        # Only look at checkouts of items that are allowed to be recalled, and get the oldest one
>+        my @items = Koha::Items->search({ biblionumber => $self->biblionumber });
>+        my @itemnumbers;
>+        foreach (@items) {
>+            my $recalls_allowed = Koha::CirculationRules->get_effective_rule({
>+                branchcode => C4::Context->userenv->{'branch'},
>+                categorycode => $self->patron->categorycode,
>+                itemtype => $_->effective_itemtype,
>+                rule_name => 'recalls_allowed',
>+            });
>+            if ( defined $recalls_allowed and $recalls_allowed > 0 ) {
>+                push ( @itemnumbers, $_->itemnumber );
>+            }
>+        }
>+        my $checkouts = Koha::Checkouts->search({ itemnumber => [ @itemnumbers ] }, { order_by => { -asc => 'date_due' } });
>+        $self->{_checkout} = $checkouts->next;
>+    }
>+
>+    return $self->{_checkout};
>+}
>+
>+=head3 requested
>+
>+    if ( $recall->requested )
>+
>+    [% IF recall.requested %]
>+
>+Return true if recall status is requested.
>+
>+=cut
>+
>+sub requested {
>+    my ( $self ) = @_;
>+    my $status = $self->status;
>+    return $status && $status eq 'R';
>+}
>+
>+=head3 waiting
>+
>+    if ( $recall->waiting )
>+
>+    [% IF recall.waiting %]
>+
>+Return true if recall is awaiting pickup.
>+
>+=cut
>+
>+sub waiting {
>+    my ( $self ) = @_;
>+    my $status = $self->status;
>+    return $status && $status eq 'W';
>+}
>+
>+=head3 overdue
>+
>+    if ( $recall->overdue )
>+
>+    [% IF recall.overdue %]
>+
>+Return true if recall is overdue to be returned.
>+
>+=cut
>+
>+sub overdue {
>+    my ( $self ) = @_;
>+    my $status = $self->status;
>+    return $status && $status eq 'O';
>+}
>+
>+=head3 in_transit
>+
>+    if ( $recall->in_transit )
>+
>+    [% IF recall.in_transit %]
>+
>+Return true if recall is in transit.
>+
>+=cut
>+
>+sub in_transit {
>+    my ( $self ) = @_;
>+    my $status = $self->status;
>+    return $status && $status eq 'T';
>+}
>+
>+=head3 expired
>+
>+    if ( $recall->expired )
>+
>+    [% IF recall.expired %]
>+
>+Return true if recall has expired.
>+
>+=cut
>+
>+sub expired {
>+    my ( $self ) = @_;
>+    my $status = $self->status;
>+    return $status && $status eq 'E';
>+}
>+
>+=head3 cancelled
>+
>+    if ( $recall->cancelled )
>+
>+    [% IF recall.cancelled %]
>+
>+Return true if recall has been cancelled.
>+
>+=cut
>+
>+sub cancelled {
>+    my ( $self ) = @_;
>+    my $status = $self->status;
>+    return $status && $status eq 'C';
>+}
>+
>+=head3 finished
>+
>+    if ( $recall->finished )
>+
>+    [% IF recall.finished %]
>+
>+Return true if recall is finished and has been fulfilled.
>+
>+=cut
>+
>+sub finished {
>+    my ( $self ) = @_;
>+    my $status = $self->status;
>+    return $status && $status eq 'F';
>+}
>+
>+=head3 calc_expirationdate
>+
>+    my $expirationdate = $recall->calc_expirationdate;
>+    $recall->update({ expirationdate => $expirationdate });
>+
>+Calculate the expirationdate to set based on circulation rules and system preferences.
>+
>+=cut
>+
>+sub calc_expirationdate {
>+    my ( $self ) = @_;
>+
>+    my $branchcode = C4::Circulation::_GetCircControlBranch( $self->item->unblessed, $self->patron->unblessed );
>+    my $rule = Koha::CirculationRules->get_effective_rule({
>+        categorycode => $self->patron->categorycode,
>+        branchcode => $branchcode,
>+        itemtype => $self->item->effective_itemtype,
>+        rule_name => 'recall_shelf_time'
>+    });
>+
>+    my $shelf_time = defined $rule ? $rule->rule_value : C4::Context->preference('RecallsMaxPickUpDelay');
>+
>+    my $expirationdate = dt_from_string->add( days => $shelf_time );
>+    return $expirationdate;
>+}
>+
>+=head3 start_transfer
>+
>+    $recall->start_transfer({ item => $item_object });
>+
>+Set the recall as in transit.
>+
>+=cut
>+
>+sub start_transfer {
>+    my ( $self, $params ) = @_;
>+
>+    if ( $self->item_level_recall ) {
>+        # already has an itemnumber
>+        $self->update({ status => 'T' });
>+    } else {
>+        my $itemnumber = $params->{item}->itemnumber;
>+        $self->update({ status => 'T', itemnumber => $itemnumber });
>+    }
>+
>+    my $ignore_reserves = 1;
>+    my ( $dotransfer, $messages ) = C4::Circulation::transferbook( $self->branchcode, $self->item->barcode, $ignore_reserves, 'Recalled' );
>+
>+    return $self;
>+}
>+
>+=head3 set_waiting
>+
>+    $recall->set_waiting({
>+        expirationdate => $expirationdate,
>+        item => $item_object
>+    });
>+
>+Set the recall as waiting and update expiration date.
>+Notify the recall requester.
>+
>+=cut
>+
>+sub set_waiting {
>+    my ( $self, $params ) = @_;
>+
>+    my $itemnumber;
>+    if ( $self->item_level_recall ) {
>+        $itemnumber = $self->itemnumber;
>+        $self->update({ status => 'W', waitingdate => dt_from_string, expirationdate => $params->{expirationdate} });
>+    } else {
>+        # biblio-level recall with no itemnumber. need to set itemnumber
>+        $itemnumber = $params->{item}->itemnumber;
>+        $self->update({ status => 'W', waitingdate => dt_from_string, expirationdate => $params->{expirationdate}, itemnumber => $itemnumber });
>+    }
>+
>+    # send notice to recaller to pick up item
>+    my $letter = C4::Letters::GetPreparedLetter(
>+        module => 'circulation',
>+        letter_code => 'PICKUP_RECALLED_ITEM',
>+        branchcode => $self->branchcode,
>+        want_librarian => 0,
>+        tables => {
>+            biblio => $self->biblionumber,
>+            borrowers => $self->borrowernumber,
>+            items => $itemnumber,
>+            recalls => $self->recall_id,
>+        },
>+    );
>+
>+    C4::Message->enqueue($letter, $self->patron->unblessed, 'email');
>+
>+    return $self;
>+}
>+
>+=head3 revert_waiting
>+
>+    $recall->revert_waiting;
>+
>+Revert recall waiting status.
>+
>+=cut
>+
>+sub revert_waiting {
>+    my ( $self ) = @_;
>+    $self->update({ status => 'R', waitingdate => undef });
>+    return $self;
>+}
>+
>+=head3 set_overdue
>+
>+    $recall->set_overdue;
>+
>+Set a recall as overdue when the recall has been requested and the borrower who has checked out the recalled item is late to return it. This will only be used by a cron - a recall cannot be set as overdue manually.
>+
>+=cut
>+
>+sub set_overdue {
>+    my ( $self ) = @_;
>+    $self->update({ status => 'O' });
>+    C4::Log::logaction( 'RECALLS', 'OVERDUE', $self->recall_id, "Recall status set to overdue", 'COMMANDLINE') if ( C4::Context->preference('RecallsLog') );
>+    return $self;
>+}
>+
>+=head3 set_expired
>+
>+    $recall->set_expired({ location => 'INTRANET' });
>+
>+Set a recall as expired. This may be done manually or by a cronjob, either when the borrower that placed the recall takes more than RecallsMaxPickUpDelay number of days to collect their item, or if the specified expirationdate passes. The location is either 'INTRANET' or 'COMMANDLINE' for logging purposes.
>+
>+=cut
>+
>+sub set_expired {
>+    my ( $self, $params ) = @_;
>+    my $location = $params->{location} || 'COMMANDLINE';
>+    $self->update({ status => 'E', old => 1, expirationdate => dt_from_string });
>+    C4::Log::logaction( 'RECALLS', 'EXPIRE', $self->recall_id, "Recall expired", $location) if ( C4::Context->preference('RecallsLog') );
>+    return $self;
>+}
>+
>+=head3 set_cancelled
>+
>+    $recall->set_cancelled;
>+
>+Set a recall as cancelled. This may be done manually, either by the borrower that placed the recall, or by the library.
>+
>+=cut
>+
>+sub set_cancelled {
>+    my ( $self ) = @_;
>+    $self->update({ status => 'C', old => 1, cancellationdate => dt_from_string });
>+    C4::Log::logaction( 'RECALLS', 'CANCEL', $self->recall_id, "Recall cancelled", 'INTRANET') if ( C4::Context->preference('RecallsLog') );
>+    return $self;
>+}
>+
>+=head3 set_finished
>+
>+    $recall->set_finished;
>+
>+Set a recall as finished. This should only be called when the item allocated to a recall is checked out to the borrower who requested the recall.
>+
>+=cut
>+
>+sub set_finished {
>+    my ( $self ) = @_;
>+    $self->update({ status => 'F', old => 1 });
>+    C4::Log::logaction( 'RECALLS', 'FULFILL', $self->recall_id, "Recall fulfilled", 'INTRANET') if ( C4::Context->preference('RecallsLog') );
>+    return $self;
>+}
>+
>+=head3 _type
>+
>+=cut
>+
>+sub _type {
>+    return 'Recall';
>+}
>+
>+1;
>diff --git a/Koha/Recalls.pm b/Koha/Recalls.pm
>new file mode 100644
>index 00000000000..654a72aadaf
>--- /dev/null
>+++ b/Koha/Recalls.pm
>@@ -0,0 +1,53 @@
>+package Koha::Recalls;
>+
>+# Copyright 2020 Aleisha Amohia <aleisha@catalyst.net.nz>
>+#
>+# This file is part of Koha.
>+#
>+# Koha is free software; you can redistribute it and/or modify it
>+# under the terms of the GNU General Public License as published by
>+# the Free Software Foundation; either version 3 of the License, or
>+# (at your option) any later version.
>+#
>+# Koha is distributed in the hope that it will be useful, but
>+# WITHOUT ANY WARRANTY; without even the implied warranty of
>+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>+# GNU General Public License for more details.
>+#
>+# You should have received a copy of the GNU General Public License
>+# along with Koha; if not, see <http://www.gnu.org/licenses>.
>+
>+use Modern::Perl;
>+
>+use Koha::Database;
>+use Koha::Recall;
>+
>+use base qw(Koha::Objects);
>+
>+=head1 NAME
>+
>+Koha::Recalls - Koha Recalls Object set class
>+
>+=head1 API
>+
>+=head2 Internal methods
>+
>+=cut
>+
>+=head3 _type
>+
>+=cut
>+
>+sub _type {
>+    return 'Recall';
>+}
>+
>+=head3 object_class
>+
>+=cut
>+
>+sub object_class {
>+    return 'Koha::Recall';
>+}
>+
>+1;
>diff --git a/Koha/Schema/Result/Recall.pm b/Koha/Schema/Result/Recall.pm
>index e08cf151af6..ab6d2f13e1d 100644
>--- a/Koha/Schema/Result/Recall.pm
>+++ b/Koha/Schema/Result/Recall.pm
>@@ -273,4 +273,42 @@ __PACKAGE__->add_columns(
>     '+item_level_recall' => { is_boolean => 1 },
> );
> 
>+__PACKAGE__->belongs_to(
>+  "biblio",
>+  "Koha::Schema::Result::Biblio",
>+  { biblionumber => "biblionumber" },
>+  { is_deferrable => 1, on_delete => "CASCADE", on_update => "CASCADE" },
>+);
>+
>+__PACKAGE__->belongs_to(
>+  "item",
>+  "Koha::Schema::Result::Item",
>+  { itemnumber => "itemnumber" },
>+  {
>+    is_deferrable => 1,
>+    join_type     => "LEFT",
>+    on_delete     => "CASCADE",
>+    on_update     => "CASCADE",
>+  },
>+);
>+
>+__PACKAGE__->belongs_to(
>+  "borrower",
>+  "Koha::Schema::Result::Borrower",
>+  { borrowernumber => "borrowernumber" },
>+  { is_deferrable => 1, on_delete => "CASCADE", on_update => "CASCADE" },
>+);
>+
>+__PACKAGE__->belongs_to(
>+  "branch",
>+  "Koha::Schema::Result::Branch",
>+  { branchcode => "branchcode" },
>+  {
>+    is_deferrable => 1,
>+    join_type     => "LEFT",
>+    on_delete     => "CASCADE",
>+    on_update     => "CASCADE",
>+  },
>+);
>+
> 1;
>diff --git a/t/db_dependent/Koha/Recall.t b/t/db_dependent/Koha/Recall.t
>new file mode 100644
>index 00000000000..72679ed6307
>--- /dev/null
>+++ b/t/db_dependent/Koha/Recall.t
>@@ -0,0 +1,157 @@
>+#!/usr/bin/perl
>+
>+# This file is part of Koha.
>+#
>+# Koha is free software; you can redistribute it and/or modify it
>+# under the terms of the GNU General Public License as published by
>+# the Free Software Foundation; either version 3 of the License, or
>+# (at your option) any later version.
>+#
>+# Koha is distributed in the hope that it will be useful, but
>+# WITHOUT ANY WARRANTY; without even the implied warranty of
>+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>+# GNU General Public License for more details.
>+#
>+# You should have received a copy of the GNU General Public License
>+# along with Koha; if not, see <http://www.gnu.org/licenses>.
>+
>+use Modern::Perl;
>+
>+use Test::More tests => 18;
>+use t::lib::TestBuilder;
>+use t::lib::Mocks;
>+
>+use Koha::DateUtils;
>+
>+BEGIN {
>+    require_ok('Koha::Recall');
>+    require_ok('Koha::Recalls');
>+}
>+
>+# Start transaction
>+
>+my $database = Koha::Database->new();
>+my $schema = $database->schema();
>+$schema->storage->txn_begin();
>+my $dbh = C4::Context->dbh;
>+
>+my $builder = t::lib::TestBuilder->new;
>+
>+# Setup test variables
>+
>+my $item1 = $builder->build_sample_item();
>+my $biblio1 = $item1->biblio;
>+my $branch1 = $item1->holdingbranch;
>+my $itemtype1 = $item1->effective_itemtype;
>+
>+my $item2 = $builder->build_sample_item();
>+my $biblio2 = $item2->biblio;
>+my $branch2 = $item2->holdingbranch;
>+my $itemtype2 = $item2->effective_itemtype;
>+
>+my $category1 = $builder->build({ source => 'Category' })->{ categorycode };
>+my $patron1 = $builder->build_object({ class => 'Koha::Patrons', value => { categorycode => $category1, branchcode => $branch1 } });
>+my $patron2 = $builder->build_object({ class => 'Koha::Patrons', value => { categorycode => $category1, branchcode => $branch1 } });
>+t::lib::Mocks::mock_userenv({ patron => $patron1 });
>+
>+Koha::CirculationRules->set_rule({
>+    branchcode => undef,
>+    categorycode => undef,
>+    itemtype => undef,
>+    rule_name => 'recalls_allowed',
>+    rule_value => '10',
>+});
>+
>+C4::Circulation::AddIssue( $patron2->unblessed, $item1->barcode );
>+
>+my $recall1 = Koha::Recall->new({
>+    borrowernumber => $patron1->borrowernumber,
>+    recalldate => dt_from_string,
>+    biblionumber => $biblio1->biblionumber,
>+    branchcode => $branch1,
>+    status => 'R',
>+    itemnumber => $item1->itemnumber,
>+    expirationdate => undef,
>+    item_level_recall => 1
>+})->store;
>+
>+is( $recall1->biblio->title, $biblio1->title, "Recall biblio relationship correctly linked" );
>+is( $recall1->item->homebranch, $item1->homebranch, "Recall item relationship correctly linked" );
>+is( $recall1->patron->categorycode, $category1, "Recall patron relationship correctly linked" );
>+is( $recall1->library->branchname, Koha::Libraries->find( $branch1 )->branchname, "Recall library relationship correctly linked" );
>+is( $recall1->checkout->itemnumber, $item1->itemnumber, "Recall checkout relationship correctly linked" );
>+is( $recall1->requested, 1, "Recall has been requested" );
>+
>+$recall1->set_overdue;
>+is( $recall1->overdue, 1, "Recall is overdue" );
>+
>+$recall1->set_cancelled;
>+is( $recall1->cancelled, 1, "Recall is cancelled" );
>+
>+my $recall2 = Koha::Recall->new({
>+    borrowernumber => $patron1->borrowernumber,
>+    recalldate => dt_from_string,
>+    biblionumber => $biblio1->biblionumber,
>+    branchcode => $branch1,
>+    status => 'R',
>+    itemnumber => $item1->itemnumber,
>+    expirationdate => undef,
>+    item_level_recall => 1
>+})->store;
>+
>+Koha::CirculationRules->set_rule({
>+    branchcode => undef,
>+    categorycode => undef,
>+    itemtype => undef,
>+    rule_name => 'recall_shelf_time',
>+    rule_value => undef,
>+});
>+
>+t::lib::Mocks->mock_preference( 'RecallsMaxPickUpDelay', 7 );
>+my $expected_expirationdate = dt_from_string->add({ days => 7 });
>+my $expirationdate = $recall2->calc_expirationdate;
>+is( $expirationdate, $expected_expirationdate, "Expiration date calculated based on system preference as no circulation rules are set" );
>+
>+Koha::CirculationRules->set_rule({
>+    branchcode => undef,
>+    categorycode => undef,
>+    itemtype => undef,
>+    rule_name => 'recall_shelf_time',
>+    rule_value => '3',
>+});
>+$expected_expirationdate = dt_from_string->add({ days => 3 });
>+$expirationdate = $recall2->calc_expirationdate;
>+is( $expirationdate, $expected_expirationdate, "Expiration date calculated based on circulation rules" );
>+
>+$recall2->set_waiting({ expirationdate => $expirationdate });
>+is( $recall2->waiting, 1, "Recall is waiting" );
>+
>+my $notice = C4::Message->find_last_message( $patron1->unblessed, 'PICKUP_RECALLED_ITEM', 'email' );
>+ok( defined $notice, "Patron was notified to pick up waiting recall" );
>+
>+$recall2->set_expired({ location => 'COMMANDLINE' });
>+is( $recall2->expired, 1, "Recall has expired" );
>+
>+my $old_recalls_count = Koha::Recalls->search({ old => 1 })->count;
>+is( $old_recalls_count, 2, "Recalls have been flagged as old when cancelled or expired" );
>+
>+my $recall3 = Koha::Recall->new({
>+    borrowernumber => $patron1->borrowernumber,
>+    recalldate => dt_from_string,
>+    biblionumber => $biblio1->biblionumber,
>+    branchcode => $branch1,
>+    status => 'R',
>+    itemnumber => $item1->itemnumber,
>+    expirationdate => undef,
>+    item_level_recall => 1
>+})->store;
>+
>+# test that recall gets T status
>+$recall3->start_transfer;
>+is( $recall3->in_transit, 1, "Recall is in transit" );
>+
>+# for testing purposes, pretend the item gets checked out
>+$recall3->set_finished;
>+is( $recall3->finished, 1, "Recall has been fulfilled" );
>+
>+$schema->storage->txn_rollback();
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 19532: 68569 | 68570 | 68571 | 68572 | 68642 | 68643 | 68644 | 68645 | 68653 | 69100 | 69102 | 69147 | 69148 | 69149 | 69170 | 69172 | 69221 | 69222 | 69223 | 69322 | 69353 | 69354 | 69405 | 69409 | 69410 | 69411 | 69841 | 69872 | 69873 | 69874 | 69875 | 69876 | 69877 | 69878 | 69879 | 69880 | 69881 | 69882 | 69883 | 69884 | 69885 | 69886 | 69887 | 69888 | 69889 | 69890 | 69986 | 70093 | 71409 | 71574 | 71575 | 71576 | 71577 | 71578 | 71579 | 71580 | 71581 | 71582 | 71583 | 71584 | 71585 | 71586 | 71587 | 71588 | 71589 | 71590 | 71591 | 71592 | 72244 | 72311 | 72312 | 72313 | 72314 | 72315 | 72316 | 72317 | 72318 | 72319 | 72320 | 72321 | 72322 | 72323 | 72324 | 72325 | 72326 | 72327 | 72328 | 72329 | 72330 | 72331 | 72332 | 72333 | 72334 | 72335 | 72336 | 72337 | 72338 | 72527 | 76817 | 76818 | 76819 | 76820 | 76821 | 76822 | 76823 | 76824 | 76825 | 76826 | 76827 | 76828 | 76829 | 76830 | 76831 | 76832 | 76833 | 76834 | 76835 | 76836 | 76837 | 76838 | 76839 | 76840 | 76841 | 76842 | 76843 | 76844 | 76845 | 76846 | 76847 | 77177 | 77178 | 77179 | 78755 | 78757 | 78759 | 78761 | 78763 | 78765 | 78766 | 78768 | 78770 | 78772 | 78773 | 78774 | 78775 | 78776 | 78777 | 78778 | 78780 | 78782 | 78785 | 78787 | 78789 | 78790 | 78792 | 78794 | 78797 | 78800 | 78801 | 78802 | 78803 | 78804 | 78805 | 78806 | 78807 | 78808 | 80763 | 80764 | 80765 | 80766 | 80767 | 80768 | 80769 | 80770 | 80771 | 80772 | 80773 | 80774 | 80775 | 80776 | 80777 | 80778 | 80779 | 80780 | 80781 | 80782 | 80783 | 80784 | 80785 | 80786 | 80787 | 80788 | 80789 | 80793 | 80878 | 81204 | 81205 | 81206 | 81207 | 81208 | 81209 | 81210 | 81211 | 81212 | 81213 | 81214 | 81215 | 81216 | 81217 | 81218 | 81219 | 81220 | 81221 | 81222 | 81223 | 81224 | 81225 | 81226 | 81227 | 81228 | 81229 | 81230 | 81231 | 81232 | 81233 | 81234 | 81235 | 81236 | 81237 | 81238 | 81239 | 81240 | 81241 | 81242 | 81243 | 81244 | 81245 | 81246 | 81247 | 81547 | 81548 | 81549 | 81550 | 81551 | 81552 | 81553 | 81554 | 81555 | 81556 | 81557 | 81558 | 81559 | 81560 | 81561 | 81562 | 81563 | 81564 | 81565 | 81566 | 81567 | 81568 | 81569 | 81583 | 81584 | 81585 | 81586 | 81587 | 81588 | 81595 | 81618 | 81652 | 81653 | 81654 | 81655 | 81656 | 81657 | 81658 | 81659 | 81660 | 81661 | 81662 | 81663 | 81664 | 81665 | 81666 | 81667 | 81668 | 81669 | 81670 | 81671 | 81672 | 81673 | 81674 | 81675 | 81676 | 81677 | 81678 | 81679 | 81680 | 81681 | 81682 | 81683 | 103887 | 103888 | 103890 | 103899 | 103900 | 103901 | 103999 | 104000 | 104001 | 104002 | 104005 | 104006 | 104007 | 104066 | 104067 | 104068 | 104069 | 104070 | 104071 | 104246 | 104247 | 104248 | 104249 | 104250 | 104322 | 104323 | 104324 | 104325 | 104326 | 104327 | 104328 | 104329 | 104330 | 104331 | 104332 | 104333 | 104334 | 104335 | 104336 | 104391 | 104392 | 104393 | 104394 | 104395 | 104396 | 104397 | 104398 | 104474 | 104475 | 104476 | 104477 | 104478 | 104479 | 104480 | 104481 | 104545 | 104546 | 104547 | 104548 | 104549 | 104550 | 104551 | 104552 | 104646 | 104647 | 104648 | 104649 | 104650 | 104651 | 104652 | 104653 | 104722 | 104723 | 104724 | 104725 | 104726 | 104727 | 104728 | 104729 | 104806 | 104807 | 104808 | 104809 | 104810 | 104811 | 104812 | 104813 | 104814 | 104815 | 104816 | 104817 | 104818 | 104819 | 104820 | 104821 | 104863 | 104864 | 104865 | 104866 | 104867 | 104868 | 104869 | 104870 | 104902 | 104903 | 104904 | 104905 | 104906 | 104907 | 104908 | 104909 | 104910 | 104913 | 104914 | 104915 | 104916 | 104917 | 104918 | 104919 | 104920 | 104988 | 104989 | 104990 | 104991 | 104992 | 106268 | 106269 | 106371 | 106372 | 106373 | 106374 | 106375 | 106376 | 106377 | 106378 | 106810 | 106811 | 106812 | 106813 | 106814 | 106815 | 106816 | 106817 | 106857 | 107198 | 107199 | 107200 | 107201 | 107202 | 107203 | 107204 | 107205 | 107807 | 107808 | 107809 | 107810 | 107811 | 107812 | 107813 | 107814 | 107918 | 107919 | 107920 | 107921 | 107922 | 107923 | 107924 | 107925 | 108222 | 108223 | 108224 | 108225 | 108226 | 108227 | 108228 | 108229 | 108980 | 108981 | 108982 | 109306 | 109307 | 109308 | 109309 | 109310 | 109311 | 109312 | 109313 | 109314 | 109315 | 109316 | 109317 | 109318 | 109463 | 109464 | 109465 | 109466 | 109467 | 109468 | 109469 | 109775 | 109776 | 109777 | 109778 | 109779 | 109780 | 109781 | 109782 | 109783 | 109784 | 109785 | 111199 | 111200 | 111201 | 111202 | 111203 | 111204 | 111205 | 111206 | 112316 | 112317 | 112321 | 112322 | 112323 | 112324 | 112325 | 112326 | 112346 | 112472 | 112491 | 112540 | 112612 | 112613 | 112614 | 112615 | 112616 | 112617 | 112618 | 112619 | 112620 | 112621 | 112622 | 113195 | 113196 | 113197 | 113198 | 113199 | 113200 | 113201 | 113202 | 113203 | 113204 | 113205 | 113286 | 113287 | 113288 | 113289 | 113290 | 113291 | 113292 | 113293 | 113294 | 113295 | 113296 | 113297 | 113298 | 113335 | 113351 | 113352 | 113353 | 113354 | 113355 | 113356 | 113357 | 113358 | 113359 | 113361 | 113362 | 113363 | 113364 | 113365 | 113430 | 113431 | 113432 | 113433 | 113434 | 113435 | 113436 | 113437 | 113438 | 113439 | 113440 | 113441 | 113442 | 113443 | 113444 | 113445 | 116121 | 116122 | 116123 | 116124 | 116125 | 116126 | 116127 | 116128 | 116129 | 116130 | 116131 | 116132 | 116133 | 116134 | 118267 | 118268 | 118269 | 118270 | 118271 | 118272 | 118273 | 118274 | 118275 | 118276 | 118277 | 118278 | 118279 | 118280 | 122993 | 122994 | 122995 | 122996 | 122997 | 122998 | 122999 | 123000 | 123001 | 123002 | 123003 | 123004 | 123005 | 126244 | 126245 | 126246 | 126247 | 126248 | 126249 | 126250 | 126251 | 126252 | 126253 | 126254 | 126255 | 126256 | 126257 | 126453 | 126454 | 126455 | 126456 | 126457 | 126458 | 126459 | 126460 | 126469 | 126470 | 126565 | 126566 | 126568 | 126569 | 126570 | 126571 | 126572 | 126573 | 126574 | 126575 | 126576 | 126577 | 126578 | 126579 | 126580 | 129305 | 129306 | 129307 | 129308 | 129309 | 129310 | 129311 | 129312 | 129313 | 129314 | 129315 | 129316 | 129317 | 129318 | 129319 | 130641 | 130642 | 130643 | 130644 | 130645 | 130646 | 130647 | 130648 | 130649 | 130650 | 130651 | 130652 | 130653 | 130654 | 130655 | 130656 | 131108 | 131156 | 131157 | 131158 | 131159 | 131160 | 131193 | 131213 | 131257 | 131260 | 131261 | 131262 | 131263 | 131264 | 131265 | 131266 | 131267 | 131268 | 131269 | 131270 | 131271 | 131272 | 131273 | 131274 | 131275 | 131276 | 131277 | 131278 | 131279 | 131280 | 131281 | 131282 | 131330 | 131629 | 131630 | 131631 | 131664 | 131665 | 131666 | 131701 | 132332