Attachment 104279 Details for Bug 18670 – Bug 18670: Remove RewriteLog and RewriteLogLevel from sample config files

[patch] Bug 18670: Remove RewriteLog and RewriteLogLevel from sample config files

Bug-18670-Remove-RewriteLog-and-RewriteLogLevel-fr.patch (text/plain), 3.33 KB, created by Jonathan Druart on 2020-05-04 13:16:51 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2020-05-04 13:16:51 UTC

Size: 3.33 KB

patch

obsolete

>From 2b068ddfa93dfa8b0ce4be9b33c31d53e719c368 Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <katrin.fischer.83@web.de>
>Date: Sun, 19 Apr 2020 13:39:08 +0200
>Subject: [PATCH] Bug 18670: Remove RewriteLog and RewriteLogLevel from sample
> config files
>
>It looks like RewriteLog will no longer work with Apache 2.4 and later.
>
>RewriteLog
>Those familiar with earlier versions of mod_rewrite will
>no doubt be looking for the RewriteLog and RewriteLogLevel
>directives. This functionality has been completely replaced
>by the new per-module logging configuration mentioned above.
>http://httpd.apache.org/docs/current/mod/mod_rewrite.html
>
>All lines removed were commented out, so there should be
>no change in behaviour or side effects.
>
>To test.
>- Verify every mention of RewriteLog has been removed from Koha
>- Verify patch by reading it
>
>Signed-off-by: David Nind <david@davidnind.com>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> debian/templates/apache-site-https.conf.in | 2 --
> debian/templates/apache-site.conf.in       | 2 --
> etc/koha-httpd.conf                        | 8 --------
> 3 files changed, 12 deletions(-)
>
>diff --git a/debian/templates/apache-site-https.conf.in b/debian/templates/apache-site-https.conf.in
>index b0f68833b4..196a415b8e 100644
>--- a/debian/templates/apache-site-https.conf.in
>+++ b/debian/templates/apache-site-https.conf.in
>@@ -34,7 +34,6 @@
> 
>    ErrorLog    /var/log/koha/__KOHASITE__/opac-error.log
> #  TransferLog /var/log/koha/__KOHASITE__/opac-access.log
>-#  RewriteLog  /var/log/koha/__KOHASITE__/opac-rewrite.log
> </VirtualHost>
> 
> # Intranet
>@@ -62,5 +61,4 @@
> 
>    ErrorLog    /var/log/koha/__KOHASITE__/intranet-error.log
> #  TransferLog /var/log/koha/__KOHASITE__/intranet-access.log
>-#  RewriteLog  /var/log/koha/__KOHASITE__/intranet-rewrite.log
> </VirtualHost>
>diff --git a/debian/templates/apache-site.conf.in b/debian/templates/apache-site.conf.in
>index 654674d5d7..9e94f599f3 100644
>--- a/debian/templates/apache-site.conf.in
>+++ b/debian/templates/apache-site.conf.in
>@@ -16,7 +16,6 @@
> 
>    ErrorLog    /var/log/koha/__KOHASITE__/opac-error.log
> #  TransferLog /var/log/koha/__KOHASITE__/opac-access.log
>-#  RewriteLog  /var/log/koha/__KOHASITE__/opac-rewrite.log
> </VirtualHost>
> 
> # Intranet
>@@ -35,5 +34,4 @@
> 
>    ErrorLog    /var/log/koha/__KOHASITE__/intranet-error.log
> #  TransferLog /var/log/koha/__KOHASITE__/intranet-access.log
>-#  RewriteLog  /var/log/koha/__KOHASITE__/intranet-rewrite.log
> </VirtualHost>
>diff --git a/etc/koha-httpd.conf b/etc/koha-httpd.conf
>index 2fe7df456e..20a9b45f2c 100644
>--- a/etc/koha-httpd.conf
>+++ b/etc/koha-httpd.conf
>@@ -100,10 +100,6 @@
>      # Rewrite Rules
>      RewriteEngine On
> 
>-     # Uncomment to turn on rewrite logging
>-     #RewriteLog __LOG_DIR__/koha-opac-rewrite.log
>-     #RewriteLogLevel 1
>-
>      #The following two directives are unnecessary to proper Koha functioning.
>      #RewriteCond %{QUERY_STRING} (.*?)(?:[A-Za-z0-9_-]+)=&(.*)
>      #RewriteRule (.+) $1?%1%2 [N,R,NE]
>@@ -224,10 +220,6 @@
>      # Rewrite Rules
>      RewriteEngine On
> 
>-     # Uncomment to turn on rewrite logging
>-     #RewriteLog __LOG_DIR__/koha-intranet-rewrite.log
>-     #RewriteLogLevel 1
>-
>      #The following two directives are unnecessary to proper Koha functioning.
>      #RewriteCond %{QUERY_STRING} (.*?)(?:[A-Za-z0-9_-]+)=&(.*)
>      #RewriteRule (.+) $1?%1%2 [N,R,NE]
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 18670: 103212 | 103224 | 104279