Attachment 104297 Details for Bug 24769 – Bug 24769: (bug 14711 follow-up) Fix typo in parameter name for AddReserve

[patch] Bug 24769: (bug 14711 follow-up) Fix typo in parameter name for AddReserve

Bug-24769-bug-14711-follow-up-Fix-typo-in-paramete.patch (text/plain), 1.46 KB, created by Tomás Cohen Arazi (tcohen) on 2020-05-04 14:45:33 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2020-05-04 14:45:33 UTC

Size: 1.46 KB

patch

obsolete

>From bd4150e777beb1d92202059ef7bbc70682196a21 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Fri, 24 Apr 2020 11:25:43 +0200
>Subject: [PATCH] Bug 24769: (bug 14711 follow-up) Fix typo in parameter name
> for AddReserve
>
>The parameter is branchcode, not branch.
>
>Test plan:
>Place a hold on a biblio using ILSDI
>Check that the branchcode is correctly filled with the patron's library
>
>Signed-off-by: David Nind <david@davidnind.com>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> C4/ILSDI/Services.pm | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/C4/ILSDI/Services.pm b/C4/ILSDI/Services.pm
>index e929b37d91..5ebba3435d 100644
>--- a/C4/ILSDI/Services.pm
>+++ b/C4/ILSDI/Services.pm
>@@ -756,7 +756,7 @@ sub HoldTitle {
>     my $priority= C4::Reserves::CalculatePriority( $biblionumber );
>     AddReserve(
>         {
>-            branch           => $branch,
>+            branchcode       => $branch,
>             borrowernumber   => $borrowernumber,
>             biblionumber     => $biblionumber,
>             priority         => $priority,
>@@ -852,7 +852,7 @@ sub HoldItem {
>     my $priority = C4::Reserves::CalculatePriority($biblionumber);
>     AddReserve(
>         {
>-            branch           => $branch,
>+            branchcode       => $branch,
>             borrowernumber   => $borrowernumber,
>             biblionumber     => $biblionumber,
>             priority         => $priority,
>-- 
>2.26.2

Actions: View | Diff | Splinter Review

Attachments on bug 24769: 99820 | 103636 | 103637 | 103638 | 103643 | 103644 | 104296 | 104297 | 104298 | 104300