Attachment 104298 Details for Bug 24769 – Bug 24769: (bug 14711 follow-up 2) Fix typo in parameter name for AddReserve

[patch] Bug 24769: (bug 14711 follow-up 2) Fix typo in parameter name for AddReserve

Bug-24769-bug-14711-follow-up-2-Fix-typo-in-parame.patch (text/plain), 1.49 KB, created by Tomás Cohen Arazi (tcohen) on 2020-05-04 14:45:41 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2020-05-04 14:45:41 UTC

Size: 1.49 KB

patch

obsolete

>From 104272ac26a29f2a15a7879397d1b6a1acecd5ce Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Fri, 24 Apr 2020 11:31:33 +0200
>Subject: [PATCH] Bug 24769: (bug 14711 follow-up 2) Fix typo in parameter name
> for AddReserve
>
>This patch fixes 2 other occurrences. The first one is in POD of
>AddReserve, the other one fixes SIP code
>
>Signed-off-by: David Nind <david@davidnind.com>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> C4/Reserves.pm                 | 2 +-
> C4/SIP/ILS/Transaction/Hold.pm | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/C4/Reserves.pm b/C4/Reserves.pm
>index 9c040bdc12..49a4445857 100644
>--- a/C4/Reserves.pm
>+++ b/C4/Reserves.pm
>@@ -144,7 +144,7 @@ BEGIN {
> 
>     AddReserve(
>         {
>-            branch           => $branchcode,
>+            branchcode       => $branchcode,
>             borrowernumber   => $borrowernumber,
>             biblionumber     => $biblionumber,
>             priority         => $priority,
>diff --git a/C4/SIP/ILS/Transaction/Hold.pm b/C4/SIP/ILS/Transaction/Hold.pm
>index d51ebde199..c86011e734 100644
>--- a/C4/SIP/ILS/Transaction/Hold.pm
>+++ b/C4/SIP/ILS/Transaction/Hold.pm
>@@ -70,7 +70,7 @@ sub do_hold {
>     AddReserve(
>         {
>             priority       => $priority,
>-            branch         => $branch,
>+            branchcode     => $branch,
>             borrowernumber => $patron->borrowernumber,
>             biblionumber   => $item->biblionumber
>         }
>-- 
>2.26.2

Actions: View | Diff | Splinter Review

Attachments on bug 24769: 99820 | 103636 | 103637 | 103638 | 103643 | 103644 | 104296 | 104297 | 104298 | 104300