Bugzilla – Attachment 104308 Details for
Bug 25304
Some of the markup needs to be corrected
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 25304: Some of the markup needs to be corrected
Bug-25304-Some-of-the-markup-needs-to-be-corrected.patch (text/plain), 33.85 KB, created by
Timothy Alexis Vass
on 2020-05-04 15:30:43 UTC
(
hide
)
Description:
Bug 25304: Some of the markup needs to be corrected
Filename:
MIME Type:
Creator:
Timothy Alexis Vass
Created:
2020-05-04 15:30:43 UTC
Size:
33.85 KB
patch
obsolete
>From b5feabfc7464124b9881ebacb6cc1799f26c003e Mon Sep 17 00:00:00 2001 >From: Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> >Date: Mon, 4 May 2020 17:29:14 +0200 >Subject: [PATCH] Bug 25304: Some of the markup needs to be corrected > > To test: > 1) Open an item in OPAC and see if everything works as it should. >--- > .../bootstrap/en/modules/opac-detail.tt | 166 +++++++++--------- > 1 file changed, 82 insertions(+), 84 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >index a177fdea16..21116e4df0 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >@@ -8,7 +8,7 @@ > [% USE AuthorisedValues %] > [% SET TagsShowEnabled = ( ( Koha.Preference( 'TagsEnabled' ) == 1 ) && TagsShowOnDetail ) %] > [% SET TagsInputEnabled = ( ( Koha.Preference( 'opacuserlogin' ) == 1 ) && ( Koha.Preference( 'TagsEnabled' ) == 1 ) && TagsInputOnDetail ) %] >-[% IF Koha.Preference('AmazonAssocTag') %] >+[% IF ( Koha.Preference('AmazonAssocTag') ) %] > [% AmazonAssocTag = '?tag=' _ Koha.Preference('AmazonAssocTag') %] > [% ELSE %] > [% AmazonAssocTag = '' %] >@@ -17,11 +17,11 @@ > [% SET AdlibrisURL = Koha.Preference('AdlibrisCoversURL') %] > > [% ShowCourseReservesHeader = 0 %] >-[% IF Koha.Preference( 'UseCourseReserves' ) == 1 %] >+[% IF ( Koha.Preference( 'UseCourseReserves' ) == 1 ) %] > [% FOREACH ITEM_RESULT IN itemloop %] >- [% IF ITEM_RESULT.course_reserves %] >+ [% IF ( ITEM_RESULT.course_reserves ) %] > [% FOREACH r IN ITEM_RESULT.course_reserves %] >- [% IF r.course.enabled == 'yes' %] >+ [% IF ( r.course.enabled == 'yes' ) %] > [% ShowCourseReservesHeader = 1 %] > [% END %] > [% END %] >@@ -94,14 +94,14 @@ > <div title="[% img_title | html %]" class="[% coce_id | html %]" id="coce-thumbnail-preview"></div> > [% END %] > >- [% IF OpenLibraryCovers %] >+ [% IF ( OpenLibraryCovers ) %] > <div title="[% img_title | html %]" class="[% normalized_isbn | html %]" id="openlibrary-thumbnail-preview"></div> > [% END %] > > [% bt_id = ( normalized_upc || normalized_isbn ) %] > > [% IF ( BakerTaylorEnabled && bt_id ) %] >- [% IF BakerTaylorBookstoreURL %] >+ [% IF ( BakerTaylorBookstoreURL ) %] > [% IF ( OPACURLOpenInNewWindow ) %] > <a href="https://[% BakerTaylorBookstoreURL | url %][% bt_id | url %]" target="_blank" rel="noreferrer"><img alt="See Baker & Taylor" src="[% BakerTaylorImageURL | html %][% bt_id | html %]" /></a> > [% ELSE %] >@@ -112,7 +112,7 @@ > [% END %] > [% END %] > >- [% IF Koha.Preference('OPACCustomCoverImages') AND Koha.Preference('CustomCoverImagesURL') %] >+ [% IF ( Koha.Preference('OPACCustomCoverImages') AND Koha.Preference('CustomCoverImagesURL') ) %] > [% IF ( OPACURLOpenInNewWindow ) %] > <a class="custom_cover_image" href="[% biblio.custom_cover_image_url | url %]" target="_blank" rel="noreferrer"><img alt="Cover image" src="[% biblio.custom_cover_image_url | url %]" /></a> > [% ELSE %] >@@ -170,7 +170,7 @@ > <a class="authlink" href="/cgi-bin/koha/opac-authoritiesdetail.pl?authid=[% MARCAUTHOR.authoritylink | html %]"><i class="fa fa-search" aria-hidden="true"></i></a> > [% END %] > >- [% IF IDREF and MARCAUTHOR.unimarc3 %] >+ [% IF ( IDREF and MARCAUTHOR.unimarc3 ) %] > <a href="/cgi-bin/koha/opac-idref.pl?unimarc3=[% MARCAUTHOR.unimarc3 | uri %]" title="IdRef" rel="gb_page_center[600, 500]">IdRef</a> > [% END %] > >@@ -287,16 +287,16 @@ > <ul> > [% FOREACH MARCurl IN MARCURLS %] > <li> >- [% IF ( MARCurl.part ) %][% MARCurl.part | html %]<br />[% END %] >+ [% IF ( MARCurl.part ) %][% MARCurl.part | html %]<br>[% END %] > > [% IF ( OPACURLOpenInNewWindow ) %] >- [% IF trackclicks == 'track' || trackclicks == 'anonymous' %] >+ [% IF ( trackclicks == 'track' || trackclicks == 'anonymous' ) %] > <a href="/cgi-bin/koha/tracklinks.pl?uri=[% MARCurl.MARCURL | uri %]&biblionumber=[% biblio.biblionumber | uri %]" title="[% MARCurl.MARCURL | html %]" target="_blank" rel="noreferrer"> > [% ELSE %] > <a href="[% MARCurl.MARCURL | url %]" title="[% MARCurl.MARCURL | html %]" target="_blank" rel="noreferrer"> > [% END %] > [% ELSE %] >- [% IF trackclicks == 'track' || trackclicks == 'anonymous' %] >+ [% IF ( trackclicks == 'track' || trackclicks == 'anonymous' ) %] > <a href="/cgi-bin/koha/tracklinks.pl?uri=[% MARCurl.MARCURL | uri %]&biblionumber=[% biblio.biblionumber | uri %]" title="[% MARCurl.MARCURL | html %]"> > [% ELSE %] > <a href="[% MARCurl.MARCURL | url %]" title="[% MARCurl.MARCURL | html %]"> >@@ -331,11 +331,11 @@ > [% END # / LibraryThingForLibrariesID %] > > <!--This grabs all of the lists a bib record appears in --> >- [% IF shelves.count %] >+ [% IF ( shelves.count ) %] > <span class="results_summary lists"><span class="label">List(s) this item appears in: </span> > [% FOREACH s IN shelves %] > <a href="/cgi-bin/koha/opac-shelves.pl?op=view&shelfnumber=[% s.shelfnumber | uri %]">[% s.shelfname | html %]</a> >- [% IF ( loop.last ) %][% ELSE %]|[% END %] >+ [% UNLESS ( loop.last ) %]|[% END %] > [% END %] > </span> > [% END %] >@@ -347,7 +347,7 @@ > <ul id="tagslist"> > [% FOREACH TagLoo IN TagLoop %] > <li><a href="/cgi-bin/koha/opac-search.pl?tag=[% TagLoo.term |url %]&q=[% TagLoo.term |url %]">[% TagLoo.term | html %]</a><span class="weight">([% TagLoo.weight_total | html %])</span> >- [% IF ( loop.last ) %][% ELSE %], [% END %] >+ [% UNLESS ( loop.last ) %],[% END %] > </li> > [% END %] > </ul> >@@ -378,7 +378,7 @@ > <a class="tag_add" id="tag_add[% biblio.biblionumber | html %]" href="#">Add tag(s)</a> > [% ELSE %] > <span id="login4tags"> >- [% IF Koha.Preference('casAuthentication') %] >+ [% IF ( Koha.Preference('casAuthentication') ) %] > [%# CAS authentication is too complicated for modal window %] > <a href="/cgi-bin/koha/opac-user.pl">Log in to add tags.</a> > [% ELSE %] >@@ -436,7 +436,7 @@ > <option value="" selected="selected"></option> > [% END %] > [% FOREACH i IN [ 1 2 3 4 5 ] %] >- [% IF rating_avg_int == i %] >+ [% IF ( rating_avg_int == i ) %] > <option value="[% i | html %]" selected="selected">[% i | html %]</option> > [% ELSE %] > <option value="[% i | html %]">[% i | html %]</option> >@@ -452,7 +452,7 @@ > > [% UNLESS ( rating_readonly ) %] <input name="rate_button" type="submit" value="Rate me" />[% END %] > >- [% IF my_rating %] >+ [% IF ( my_rating ) %] > <span id="rating_value_text">Your rating: [% my_rating.rating_value | html %].</span> > <span id="cancel_rating_text"><a href="#"><i class="fa fa-remove" aria-hidden="true"></i> Cancel rating</a>.</span> > [% ELSE %] >@@ -467,17 +467,16 @@ > > [% IF ( BakerTaylorContentURL ) %] > <span class="results_summary"> >- <span class="label">Enhanced content: </span> >- [% IF ( OPACURLOpenInNewWindow ) %]<a href="[% BakerTaylorContentURL | url %]" target="_blank" rel="noreferrer">Content Cafe</a>[% ELSE %]<a href="[% BakerTaylorContentURL | url %]">Content Cafe</a>[% END %] >+ <span class="label">Enhanced content: </span> >+ [% IF ( OPACURLOpenInNewWindow ) %]<a href="[% BakerTaylorContentURL | url %]" target="_blank" rel="noreferrer">Content Cafe</a>[% ELSE %]<a href="[% BakerTaylorContentURL | url %]">Content Cafe</a>[% END %] > </span> > [% END # / IF BakerTaylorContentURL %] > > [% IF ( NovelistSelectProfile && (normalized_isbn || normalized_upc) ) %] > [% IF ( NovelistSelectView == 'above') %] > <span class="results_summary NovelistSelect" style="display:none;"> >- <span class="label">Novelist Select: </span> >- <div data-novelist-novelistselect=[% IF normalized_isbn %][% normalized_isbn | html %][% ELSE %][% normalized_upc | html %][% END %]></div> >- >+ <span class="label">Novelist Select: </span> >+ <div data-novelist-novelistselect=[% IF ( normalized_isbn ) %][% normalized_isbn | html %][% ELSE %][% normalized_upc | html %][% END %]></div> > </span> > [% END %] > [% END # / IF NovelistSelectProfile %] >@@ -508,13 +507,13 @@ > > [% IF ( MARCNOTES || notes || ( SyndeticsEnabled && SyndeticsSummary && SYNDETICS_SUMMARY )) %] > [% SET title_notes_count = 0 %] >- [% IF MARCNOTES %] >+ [% IF ( MARCNOTES ) %] > [% SET title_notes_count = MARCNOTES.size %] >- [% ELSIF notes %] >+ [% ELSIF ( notes ) %] > [% SET title_notes_count = 1 %] > [% END %] > >- [% IF SYNDETICS_SUMMARY %][% SET title_notes_count = title_notes_count + 1 %][% END %] >+ [% IF ( SYNDETICS_SUMMARY ) %][% SET title_notes_count = title_notes_count + 1 %][% END %] > <li id="tab_descriptions"><a href="#descriptions">Title notes ( [% title_notes_count | html %] )</a></li> > [% END %] > >@@ -553,7 +552,7 @@ > </li> > [% END %] > >- [% IF Koha.Preference( 'reviewson' ) == 1 %] >+ [% IF ( Koha.Preference( 'reviewson' ) == 1 ) %] > <li id="tab_comments"><a href="#comments">Comments[% ' ( ' _ (reviews.size || 0) _ ' )' | html %]</a></li> > [% END %] > >@@ -607,26 +606,26 @@ > [% END # / IF serialcollection %] > > <div id="holdings"> >- [% IF too_many_items %] >+ [% IF ( too_many_items ) %] > <p>This record has many physical items ([% items_count | html %]). <a href="/cgi-bin/koha/opac-detail.pl?biblionumber=[% biblio.biblionumber | uri %]&viewallitems=1">Click here to view them all.</a></p> > [% ELSIF ( itemloop.size ) %] > [% INCLUDE items_table items=itemloop tab="holdings" table_id="holdingst" %] >- [% IF Koha.Preference('OPACAcquisitionDetails') and acquisition_details.total_quantity > 0 %] >- [% IF acquisition_details.total_quantity == 1 %] >+ [% IF ( Koha.Preference('OPACAcquisitionDetails') and acquisition_details.total_quantity > 0 ) %] >+ [% IF ( acquisition_details.total_quantity == 1 ) %] > <span>1 item is on order.</span> > [% ELSE %] > <span>[% acquisition_details.total_quantity | html %] items are on order.</span> > [% END %] > [% END %] > >- [% IF holds_count.defined || priority %] >+ [% IF ( holds_count.defined || priority ) %] > <div id="bib_holds"> >- [% IF holds_count.defined %] >+ [% IF ( holds_count.defined ) %] > <span>Total holds: [% holds_count | html %]</span> > [% END %] > >- [% IF priority %] >- [% IF holds_count.defined %] >+ [% IF ( priority ) %] >+ [% IF ( holds_count.defined ) %] > <span>(priority [% priority | html %])</span> > [% ELSE %] > <span>Overall queue priority: [% priority | html %]</span> >@@ -640,8 +639,8 @@ > <div id="alternateholdings"><span class="holdings_label">Holdings:</span>[% ALTERNATEHOLDING.holding | html %]</div> > [% END %] > [% ELSE %] >- [% IF Koha.Preference('OPACAcquisitionDetails') and acquisition_details.total_quantity > 0 %] >- [% IF acquisition_details.total_quantity == 1 %] >+ [% IF ( Koha.Preference('OPACAcquisitionDetails') and acquisition_details.total_quantity > 0 ) %] >+ [% IF ( acquisition_details.total_quantity == 1 ) %] > <span>1 item is on order.</span> > [% ELSE %] > <span>[% acquisition_details.total_quantity | html %] items are on order.</span> >@@ -679,7 +678,7 @@ > <div id="marcnotes"> > [% FOREACH MARCNOTE IN MARCNOTES %] > <p> >- [% IF MARCNOTE.marcnote.match('^https?://\S+$') %] >+ [% IF ( MARCNOTE.marcnote.match('^https?://\S+$') ) %] > <a href="[% MARCNOTE.marcnote | url %]">[% MARCNOTE.marcnote | html %]</a> > [% ELSE %] > [% MARCNOTE.marcnote | html | html_line_break %] >@@ -753,7 +752,7 @@ > > [% IF ( NovelistSelectProfile && NovelistSelectView == 'tab' && (normalized_isbn || normalized_upc) ) %] > <div id="NovelistSelect" > >- <div data-novelist-novelistselect=[% IF normalized_isbn %][% normalized_isbn | html %][% ELSE %][% normalized_upc | html %][% END %]></div> >+ <div data-novelist-novelistselect=[% IF ( normalized_isbn ) %][% normalized_isbn | html %][% ELSE %][% normalized_upc | html %][% END %]></div> > </div> > [% END # / IF NovelistSelectProfile && NovelistSelectView == 'tab' %] > >@@ -875,18 +874,18 @@ > </div> > [% END # / IF LibraryThingForLibrariesID && LibraryThingForLibrariesTabbedView %] > >- [% IF Koha.Preference( 'reviewson' ) == 1 %] >+ [% IF ( Koha.Preference( 'reviewson' ) == 1 ) %] > <div id="comments"> > <div id="newcomment"></div> > [% IF ( reviews ) %] > [% FOREACH review IN reviews %] >- [% IF borrowernumber && review.borrowernumber == borrowernumber %] >+ [% IF ( borrowernumber && review.borrowernumber == borrowernumber ) %] > <div class="commentline yours" id="c[% review.reviewid | html %]"> > [% IF ( review.avatarurl ) %] > <img class="avatar" src="[% review.avatarurl | html %]" height="80" width="80" alt="" /> > [% END %] > >- [% IF review.approved %] >+ [% IF ( review.approved ) %] > <h5>Your comment</h5> > [% ELSE %] > <h5>Your comment (preview, pending approval)</h5> >@@ -1011,7 +1010,7 @@ > <div id="images"> > <p>Click on an image to view it in the image viewer</p> > [% FOREACH image IN localimages %] >- [% IF image %] >+ [% IF ( image ) %] > <a class="localimage" href="/cgi-bin/koha/opac-imageviewer.pl?biblionumber=[% biblio.biblionumber | html %]&imagenumber=[% image | html %]"><img alt="" src="/cgi-bin/koha/opac-image.pl?thumbnail=1&imagenumber=[% image | html %]" /></a> > [% END %] > [% END %] >@@ -1022,7 +1021,7 @@ > [% IF ( NovelistSelectProfile && NovelistSelectView == 'below' && ( normalized_isbn || normalized_upc ) ) %] > <div id="NovelistSelect"> > <h3>Novelist Select</h3> >- <div data-novelist-novelistselect="[% IF normalized_isbn %][% normalized_isbn | html %][% ELSE %][% normalized_upc | html %][% END %]"></div> >+ <div data-novelist-novelistselect="[% IF ( normalized_isbn ) %][% normalized_isbn | html %][% ELSE %][% normalized_upc | html %][% END %]"></div> > </div> > [% END %] > >@@ -1152,7 +1151,7 @@ > [% IF ( NovelistSelectProfile && NovelistSelectView == 'right' && ( normalized_isbn || normalized_upc ) ) %] > <div id="NovelistSelect"> > <h4>Novelist Select</h4> >- <div data-novelist-novelistselect=[% IF normalized_isbn %][% normalized_isbn | html %][% ELSE %][% normalized_upc | html %][% END %]></div> >+ <div data-novelist-novelistselect=[% IF ( normalized_isbn ) %][% normalized_isbn | html %][% ELSE %][% normalized_upc | html %][% END %]></div> > </div> > [% END %] > >@@ -1180,9 +1179,9 @@ > [% END -%] > [% END %] > </div> >- [% END # /IF SocialNetworks %] >+ [% END # / IF SocialNetworks %] > </div> <!-- / .ulactioncontainer --> >- </div> <!-- / .span4 --> >+ </div> <!-- / .span3 --> > </div> <!-- / .row-fluid --> > <div class="row-fluid"> > [% IF ( LibraryThingForLibrariesID ) %] >@@ -1247,9 +1246,9 @@ > [% END %] > <th id="item_datedue" data-colname="item_datedue" class="date_due">Date due</th> > <th id="item_barcode" data-colname="item_barcode" class="barcode">Barcode</th> >- [% IF holds_count.defined %] >+ [% IF ( holds_count.defined ) %] > <th id="item_holds" data-colname="item_holds">Item holds</th> >- [% ELSIF show_priority %] >+ [% ELSIF ( show_priority ) %] > <th id="item_priority" data-colname="item_priority">Item hold queue priority</th> > [% END %] > >@@ -1260,7 +1259,7 @@ > </thead> > <tbody> > [% FOREACH ITEM_RESULT IN items %] >- [% IF ITEM_RESULT.this_branch %] >+ [% IF ( ITEM_RESULT.this_branch ) %] > <tr class="highlight-row-detail" vocab="http://schema.org/" typeof="Offer"> > [% ELSE %] > <tr vocab="http://schema.org/" typeof="Offer"> >@@ -1300,7 +1299,7 @@ > <link property="itemOffered" href="#record" /> > <link property="businessFunction" href="http://purl.org/goodrelations/v1#LeaseOut"> > <span class="[% ITEM_RESULT.home_branch_opac_info ? 'branch-info-tooltip-trigger' : '' %]" title=""> >- [% IF Branches.GetURL( ITEM_RESULT.homebranch ) %] >+ [% IF ( Branches.GetURL( ITEM_RESULT.homebranch ) ) %] > [% home_branch_url = Branches.GetURL( ITEM_RESULT.homebranch ) %] > [% IF ( home_branch_url ) %] > <a href="[% home_branch_url | url %]">[% Branches.GetName( ITEM_RESULT.homebranch ) | html %]</a> >@@ -1340,15 +1339,15 @@ > </td> > [% IF ( itemdata_enumchron ) %] > <td class="vol_info"> >- [% IF ITEM_RESULT.enumchron && ITEM_RESULT.serialseq %] >+ [% IF ( ITEM_RESULT.enumchron && ITEM_RESULT.serialseq ) %] > <span class="enum">[% ITEM_RESULT.enumchron | html %]</span> > [% IF ( ITEM_RESULT.serialseq && ITEM_RESULT.enumchron!=ITEM_RESULT.serialseq ) %] > <span class="sep"> -- </span> > <span class="serialseq">[% ITEM_RESULT.serialseq | html %]</span> > [% END %] >- [% ELSIF ITEM_RESULT.enumchron %] >+ [% ELSIF ( ITEM_RESULT.enumchron ) %] > <span class="enum">[% ITEM_RESULT.enumchron | html %]</span> >- [% ELSIF ITEM_RESULT.serialseq %] >+ [% ELSIF ( ITEM_RESULT.serialseq ) %] > <span class="serialseq">[% ITEM_RESULT.serialseq | html %]</span> > [% END %] > >@@ -1360,20 +1359,20 @@ > > [% IF ( itemdata_uri ) %] > <td class="url"> >- [% IF ITEM_RESULT.uri %] >+ [% IF ( ITEM_RESULT.uri ) %] > [%# Initialize three helper vars %] > [% SET target_attr = ''; SET rel_attr = ''; SET href_attr = '' %] >- [% IF Koha.Preference('OPACURLOpenInNewWindow') %][% SET target_attr = '_blank'; SET rel_attr = 'noreferrer' %][% END %] >+ [% IF ( Koha.Preference('OPACURLOpenInNewWindow') ) %][% SET target_attr = '_blank'; SET rel_attr = 'noreferrer' %][% END %] > > [%# Check if there are multiple URIs; in the single case we only use pref URLLinkText or Link to resource %] >- [% IF ITEM_RESULT.uri.split(' \| ').size > 1 %] >+ [% IF ( ITEM_RESULT.uri.split(' \| ').size > 1 ) %] > [% FOREACH uri IN ITEM_RESULT.uri.split(' \| ') %] >- [% IF trackclicks == 'track' || trackclicks == 'anonymous' %][% SET href_attr = "/cgi-bin/koha/tracklinks.pl?uri=" _ uri _ "&biblionumber=" _ biblio.biblionumber _ "&itemnumber=" _ ITEM_RESULT.itemnumber %][% ELSE %][% SET href_attr = uri %][% END %] >+ [% IF ( trackclicks == 'track' || trackclicks == 'anonymous' ) %][% SET href_attr = "/cgi-bin/koha/tracklinks.pl?uri=" _ uri _ "&biblionumber=" _ biblio.biblionumber _ "&itemnumber=" _ ITEM_RESULT.itemnumber %][% ELSE %][% SET href_attr = uri %][% END %] > <a target="[% target_attr | html %]" rel="[% rel_attr | html %]" href="[% href_attr | url %]" property="url">[% uri | html %]</a><br> > [% END %] > [% ELSE %] >- [% IF trackclicks == 'track' || trackclicks == 'anonymous' %][% SET href_attr = "/cgi-bin/koha/tracklinks.pl?uri=" _ ITEM_RESULT.uri _ "&biblionumber=" _ biblio.biblionumber _ "&itemnumber=" _ ITEM_RESULT.itemnumber %][% ELSE %][% SET href_attr = ITEM_RESULT.uri %][% END %] >- <a target="[% target_attr | html %]" rel="[% rel_attr | html %]" href="[% href_attr | url %]" property="url">[% IF Koha.Preference('URLLinkText') %][% Koha.Preference('URLLinkText') | html %][% ELSE %]Link to resource[% END %]</a> >+ [% IF ( trackclicks == 'track' || trackclicks == 'anonymous' ) %][% SET href_attr = "/cgi-bin/koha/tracklinks.pl?uri=" _ ITEM_RESULT.uri _ "&biblionumber=" _ biblio.biblionumber _ "&itemnumber=" _ ITEM_RESULT.itemnumber %][% ELSE %][% SET href_attr = ITEM_RESULT.uri %][% END %] >+ <a target="[% target_attr | html %]" rel="[% rel_attr | html %]" href="[% href_attr | url %]" property="url">[% IF ( Koha.Preference('URLLinkText') ) %][% Koha.Preference('URLLinkText') | html %][% ELSE %]Link to resource[% END %]</a> > [% END %] > [% END %] > </td> >@@ -1384,12 +1383,12 @@ > [% IF ( itemdata_itemnotes ) %]<td class="notes" property="description">[% ITEM_RESULT.itemnotes | $raw %]</td>[% END %] > <td class="date_due"><span title="[% ITEM_RESULT.datedue | html %]">[% ITEM_RESULT.datedue | $KohaDates as_due_date => 1 %]</span></td> > <td class="barcode" property="serialNumber">[% ITEM_RESULT.barcode | html %]</td> >- [% IF holds_count.defined || show_priority %] >+ [% IF ( holds_count.defined || show_priority ) %] > <td class="holds_count"> >- [% IF holds_count.defined %][% ITEM_RESULT.holds_count | html %][% END %] >+ [% IF ( holds_count.defined ) %][% ITEM_RESULT.holds_count | html %][% END %] > >- [% IF ITEM_RESULT.priority %] >- [% IF holds_count.defined %] >+ [% IF ( ITEM_RESULT.priority ) %] >+ [% IF ( holds_count.defined ) %] > <span>(priority [% ITEM_RESULT.priority | html %])</span> > [% ELSE %] > <span>[% ITEM_RESULT.priority | html %]</span> >@@ -1398,18 +1397,18 @@ > </td> > [% END %] > >- [% IF ShowCourseReservesHeader %] >+ [% IF ( ShowCourseReservesHeader ) %] > <td> >- [% IF ITEM_RESULT.course_reserves %] >+ [% IF ( ITEM_RESULT.course_reserves ) %] > [% FOREACH r IN ITEM_RESULT.course_reserves %] >- [% IF r.course.enabled == 'yes' %] >+ [% IF ( r.course.enabled == 'yes' ) %] > <p> > <a href="opac-course-details.pl?course_id=[% r.course.course_id | uri %]"> > [% r.course.course_name | html %] >- <!--[% IF r.course.course_number %][% r.course.course_number | html %][% END %]--> >- [% IF r.course.section %][% r.course.section | html %][% END %] >+ <!--[% IF ( r.course.course_number ) %][% r.course.course_number | html %][% END %]--> >+ [% IF ( r.course.section ) %][% r.course.section | html %][% END %] > >- [% IF r.course.term %][% AuthorisedValues.GetByCode( 'TERM', r.course.term, 1 ) | html %][% END %] >+ [% IF ( r.course.term ) %][% AuthorisedValues.GetByCode( 'TERM', r.course.term, 1 ) | html %][% END %] > </a> > </p> > [% END %] >@@ -1626,14 +1625,13 @@ > var default_order_index = 0; > [% END %] > >- [% IF ( query_desc ) %] >- [% IF ( OpacHighlightedWords ) %]var query_desc = "[% query_desc |replace("'", "\'") |replace('\n', '\\n') |replace('\r', '\\r') | html %]"; >- q_array = query_desc.split(" "); >- q_array = q_array.filter(function(n){ return n }); // Remove empty strings >- highlightOn(); >- $("#highlight_toggle_on" ).hide().click(function() {highlightOn() ; return false;}); >- $("#highlight_toggle_off").show().click(function() {highlightOff(); return false;}); >- [% END %] >+ [% IF ( query_desc && OpacHighlightedWords ) %] >+ var query_desc = "[% query_desc |replace("'", "\'") |replace('\n', '\\n') |replace('\r', '\\r') | html %]"; >+ q_array = query_desc.split(" "); >+ q_array = q_array.filter(function(n){ return n }); // Remove empty strings >+ highlightOn(); >+ $("#highlight_toggle_on" ).hide().click(function() {highlightOn() ; return false;}); >+ $("#highlight_toggle_off").show().click(function() {highlightOff(); return false;}); > [% END %] > > [% IF ( GoogleJackets ) %] >@@ -1644,19 +1642,19 @@ > KOHA.coce.getURL('[% Koha.Preference('CoceHost') | html %]', '[% Koha.Preference('CoceProviders') | html %]', [% covernewwindow | html %]); > [% END %] > >- [% IF OpenLibraryCovers %] >+ [% IF ( OpenLibraryCovers ) %] > KOHA.OpenLibrary.GetCoverFromIsbn(); > [% END %] > >- [% IF OPACLocalCoverImages %] >+ [% IF ( OPACLocalCoverImages ) %] > KOHA.LocalCover.GetCoverFromBibnumber(true); > [% END %] > > [% IF ( NovelistSelectProfile && ( normalized_isbn || normalized_upc ) ) %] > novSelect.loadContentForQuery( > { >- ClientIdentifier : '[% IF normalized_isbn %][% normalized_isbn | html %][% ELSE %][% normalized_upc | html %][% END %]', >- ISBN : '[% IF normalized_isbn %][% normalized_isbn | html %][% ELSE %][% normalized_upc | html %][% END %]', >+ ClientIdentifier : '[% IF ( normalized_isbn ) %][% normalized_isbn | html %][% ELSE %][% normalized_upc | html %][% END %]', >+ ISBN : '[% IF ( normalized_isbn ) %][% normalized_isbn | html %][% ELSE %][% normalized_upc | html %][% END %]', > version : '2.1' > }, > '[% NovelistSelectProfile | html %]', >@@ -1694,11 +1692,11 @@ > KOHA.coce.getURL('[% Koha.Preference('CoceHost') | html %]', '[% Koha.Preference('CoceProviders') | html %]', [% covernewwindow | html %]); > [% END %] > >- [% IF OpenLibraryCovers %] >+ [% IF ( OpenLibraryCovers ) %] > KOHA.OpenLibrary.GetCoverFromIsbn(); > [% END %] > >- [% IF OPACLocalCoverImages %] >+ [% IF ( OPACLocalCoverImages ) %] > KOHA.LocalCover.GetCoverFromBibnumber(true); > [% END %] > } >@@ -1723,11 +1721,11 @@ > KOHA.coce.getURL('[% Koha.Preference('CoceHost') | html %]', '[% Koha.Preference('CoceProviders') | html %]', [% covernewwindow | html %]); > [% END %] > >- [% IF OpenLibraryCovers %] >+ [% IF ( OpenLibraryCovers ) %] > KOHA.OpenLibrary.GetCoverFromIsbn(); > [% END %] > >- [% IF OPACLocalCoverImages %] >+ [% IF ( OPACLocalCoverImages ) %] > KOHA.LocalCover.GetCoverFromBibnumber(true); > [% END %] > } >-- >2.17.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 25304
:
104281
|
104302
| 104308