Attachment 104321 Details for Bug 25130 – Bug 25130: Reason for accepting/rejecting a suggestion is not visible when viewing (not editing)

[patch] Bug 25130: Reason for accepting/rejecting a suggestion is not visible when viewing (not editing)

Bug-25130-Reason-for-acceptingrejecting-a-suggesti.patch (text/plain), 1.59 KB, created by ByWater Sandboxes on 2020-05-04 21:50:59 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: ByWater Sandboxes

Created: 2020-05-04 21:50:59 UTC

Size: 1.59 KB

patch

obsolete

>From acbffaca6396167f4f3f1a338b6dbcc0c2535cd9 Mon Sep 17 00:00:00 2001
>From: David Roberts <david@koha-ptfs.co.uk>
>Date: Mon, 4 May 2020 19:43:32 +0000
>Subject: [PATCH] Bug 25130: Reason for accepting/rejecting a suggestion is not
> visible when viewing (not editing)
>
>The patch adds the suggestion management reason to the display when
>viewing a suggestion.
>
>To test:
>
>1) Edit a suggestion and assign a reason for accepting it.
>2) View the suggestion (/cgi-bin/koha/suggestion/suggestion.pl?suggestionid=XX&op=show, replacing XX with your suggestion ID)
>3) Under suggestion management, the reason you've just assigned does not
>display.
>4) Apply the patch
>5) Check the display again - the Reason should now be visible directly
>under the status.
>
>Signed-off-by: Abbey Holt <aholt@dubuque.lib.ia.us>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt | 6 ++++++
> 1 file changed, 6 insertions(+)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
>index 0882b2c69b..313460fa0f 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
>@@ -162,6 +162,12 @@
> 
>         </li>
>         <li>
>+         <span class="label">Reason:</span>
>+            [% IF ( reason ) %]
>+                [% AuthorisedValues.GetByCode( 'SUGGEST', reason, 0 ) | html %]
>+            [% END %]
>+        </li>
>+        <li>
>           <table>
>             <thead><tr><th>&nbsp;</th><th>Date</th><th>By</th></tr></thead>
>             <tbody>
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 25130: 104320 | 104321 | 104633