Bugzilla – Attachment 104493 Details for
Bug 25409
Required dropdown missing "required" class near label
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 25409: Add missing "required" class to template
Bug-25409-Add-missing-required-class-to-template.patch (text/plain), 1.60 KB, created by
Slava Shishkin
on 2020-05-07 11:32:04 UTC
(
hide
)
Description:
Bug 25409: Add missing "required" class to template
Filename:
MIME Type:
Creator:
Slava Shishkin
Created:
2020-05-07 11:32:04 UTC
Size:
1.60 KB
patch
obsolete
>From 4052e8d2e3b808ed067d578a8ead72d4b0e4689c Mon Sep 17 00:00:00 2001 >From: Slava Shishkin <slavashishkin@gmail.com> >Date: Thu, 7 May 2020 14:24:31 +0300 >Subject: [PATCH] Bug 25409: Add missing "required" class to template > >Added "required" class to "itemtype" label in "onboardingstep5.tt" >template. > >To test: > 1) Start new instalation. During onboarding tool phase you will be > requested to create a new circulation rule. > 2) Observe that "itemtype" label has no "required" class. > 3) Apply patch. > 4) Repeat step 2 (you can reload circulation rule creation page). > 5) Observe the error is gone. >--- > .../intranet-tmpl/prog/en/modules/onboarding/onboardingstep5.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep5.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep5.tt >index b559255591..0a1455c7d2 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep5.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep5.tt >@@ -57,7 +57,7 @@ > </li> > > <li> >- <label for="itemtype"> Item type: </label> >+ <label for="itemtype" class="required">Item type: </label> > <select id="itemtype" name="itemtype" required="required"> > <option value=""> Choose </option> > <option value="*" selected="selected">All</option> >-- >2.17.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 25409
:
104486
|
104493
|
104499
|
104556
|
104634
|
104684