Attachment 104608 Details for Bug 25430 – Bug 25430: Improve the styling of the claims returned tab

[patch] Bug 25430: Improve the styling of the claims returned tab

Bug-25430-Improve-the-styling-of-the-claims-return.patch (text/plain), 5.34 KB, created by Kyle M Hall (khall) on 2020-05-08 17:17:58 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2020-05-08 17:17:58 UTC

Size: 5.34 KB

patch

obsolete

>From d1999902e76a41530b0a0be0a860e4ea9cbc076d Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Fri, 8 May 2020 13:15:40 -0400
>Subject: [PATCH] Bug 25430: Improve the styling of the claims returned tab
>
>It has been suggested that it would be useful to add title attributes to the different numbers on the return claims tab in the checkouts and patron details pages. In addition, color coding them ( and removing the slash ) will make the numbers easier to read.
>
>Test Plan:
>1) Set up return claims for your system
>2) Apply this patch
>3) View the claims tab for someone with not claims, and someone with claims
>4) Note the resolved claims are green and have a "tooltip" when hovered over
>5) Note the unresolved claims are green if 0, and yellow if not 0, and
> also have a "tooltip"
>---
> .../intranet-tmpl/prog/en/modules/circ/circulation.tt | 10 ++++------
> .../prog/en/modules/members/moremember.tt | 10 ++++------
> 2 files changed, 8 insertions(+), 12 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
>index 7423164850..358102d317 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
>@@ -873,17 +873,15 @@
> <li>
> [% IF ( patron.return_claims.count ) %]
> <a href="#return-claims" id="return-claims-tab">
>- [% patron.return_claims.resolved.count | html %]
>- /
>- [% patron.return_claims.unresolved.count | html %]
> Claim(s)
>+ [% patron.return_claims.resolved.count | html %]
>+ [% patron.return_claims.unresolved.count | html %]
> </a>
> [% ELSE %]
> <a href="#return-claims" id="return-claims-tab">
>- 0
>- /
>- 0
> Claim(s)
>+ 0
>+ 0
> </a>
> [% END %]
> </li>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
>index 8321edef92..4603bcbdf7 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
>@@ -732,17 +732,15 @@
> <li>
> [% IF ( patron.return_claims.count ) %]
> <a href="#return-claims" id="return-claims-tab">
>- [% patron.return_claims.resolved.count | html %]
>- /
>- [% patron.return_claims.unresolved.count | html %]
> Claim(s)
>+ [% patron.return_claims.resolved.count | html %]
>+ [% patron.return_claims.unresolved.count | html %]
> </a>
> [% ELSE %]
> <a href="#return-claims" id="return-claims-tab">
>- 0
>- /
>- 0
> Claim(s)
>+ 0
>+ 0
> </a>
> [% END %]
> </li>
>-- 
>2.24.2 (Apple Git-127)

Actions: View | Diff | Splinter Review

Attachments on bug 25430: 104608 | 106211 | 108350 | 108521 | 108629