Bugzilla – Attachment 104630 Details for
Bug 25301
Category code is blank when renewing or editing expired/expiring patron
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 25301: removed useless URI parameter "categorycode" from template
Bug-25301-removed-useless-URI-parameter-categoryco.patch (text/plain), 5.44 KB, created by
Katrin Fischer
on 2020-05-09 22:38:37 UTC
(
hide
)
Description:
Bug 25301: removed useless URI parameter "categorycode" from template
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2020-05-09 22:38:37 UTC
Size:
5.44 KB
patch
obsolete
>From 6eb14f10ee95291441022ff7411af9ab43a690e7 Mon Sep 17 00:00:00 2001 >From: Petro Vashchuk <stalkernoid@gmail.com> >Date: Wed, 6 May 2020 16:09:01 +0300 >Subject: [PATCH] Bug 25301: removed useless URI parameter "categorycode" from > template > >Both "Edit details" links were sending empty query parameter >"categorycode" as there is no such template parameter in "moremember.pl" >defined at all, because template code block looks copy-pasted >from "circulation.tt". > >This patch removes the parameter from "moremember.tt" template. > >To test: > 1) You need to create or find expired or expiring patron. > 2) Head to patron details page of that patron. > 3) Inspect both "Edit details" links: > one in the notification about expiration > and other one in the "Expiration date:" field. > 4) Observe empty parameter "categorycode=" in those links. > 5) Apply patch. > 6) Repeat step 3. > 7) Check that there's no "categorycode=" in the links anymore. > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt >index 8321edef92..78ebaffe62 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt >@@ -140,13 +140,13 @@ > [% ELSE %] > Patron's card has expired. > [% END %] >- <a href="/cgi-bin/koha/members/setstatus.pl?borrowernumber=[% patron.borrowernumber | uri %]&reregistration=y">Renew</a> or <a href="/cgi-bin/koha/members/memberentry.pl?op=modify&borrowernumber=[% patron.borrowernumber | html %]&categorycode=[% categorycode | html %]">Edit details</a> >+ <a href="/cgi-bin/koha/members/setstatus.pl?borrowernumber=[% patron.borrowernumber | uri %]&reregistration=y">Renew</a> or <a href="/cgi-bin/koha/members/memberentry.pl?op=modify&borrowernumber=[% patron.borrowernumber | html %]">Edit details</a> > </li> > [% ELSIF ( patron.is_going_to_expire ) %] > <li> > <span class="circ-hlt">Expiration:</span> Patron's card will expire soon. > Patron's card expires on [% patron.dateexpiry | $KohaDates %] >- <a href="/cgi-bin/koha/members/setstatus.pl?borrowernumber=[% patron.borrowernumber | uri %]&reregistration=y">Renew</a> or <a href="/cgi-bin/koha/members/memberentry.pl?op=modify&borrowernumber=[% patron.borrowernumber | html %]&categorycode=[% categorycode | html %]">Edit details</a> >+ <a href="/cgi-bin/koha/members/setstatus.pl?borrowernumber=[% patron.borrowernumber | uri %]&reregistration=y">Renew</a> or <a href="/cgi-bin/koha/members/memberentry.pl?op=modify&borrowernumber=[% patron.borrowernumber | html %]">Edit details</a> > </li> > [% END %] > >@@ -466,12 +466,12 @@ > <span class="blocker"> > [% patron.dateexpiry | $KohaDates %] > <strong><em>Expired</em></strong> >- <a href="/cgi-bin/koha/members/setstatus.pl?borrowernumber=[% patron.borrowernumber | uri %]&reregistration=y">Renew</a> or <a href="/cgi-bin/koha/members/memberentry.pl?op=modify&borrowernumber=[% patron.borrowernumber | html %]&categorycode=[% categorycode | html %]">Edit details</a> >+ <a href="/cgi-bin/koha/members/setstatus.pl?borrowernumber=[% patron.borrowernumber | uri %]&reregistration=y">Renew</a> or <a href="/cgi-bin/koha/members/memberentry.pl?op=modify&borrowernumber=[% patron.borrowernumber | html %]">Edit details</a> > </span> > [% ELSIF ( patron.is_going_to_expire ) %] > [% patron.dateexpiry | $KohaDates %] > <strong><em>Patron expires soon</em></strong> >- <a href="/cgi-bin/koha/members/setstatus.pl?borrowernumber=[% patron.borrowernumber | uri %]&reregistration=y">Renew</a> or <a href="/cgi-bin/koha/members/memberentry.pl?op=modify&borrowernumber=[% patron.borrowernumber | html %]&categorycode=[% categorycode | html %]">Edit details</a> >+ <a href="/cgi-bin/koha/members/setstatus.pl?borrowernumber=[% patron.borrowernumber | uri %]&reregistration=y">Renew</a> or <a href="/cgi-bin/koha/members/memberentry.pl?op=modify&borrowernumber=[% patron.borrowernumber | html %]">Edit details</a> > [% ELSE %] > [% patron.dateexpiry | $KohaDates %] > [% END %] >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 25301
:
104418
|
104484
|
104630
|
104631
|
104656
|
104657
|
104658