Bugzilla – Attachment 104634 Details for
Bug 25409
Required dropdown missing "required" class near label
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 25409: Add missing “Required” text and “required” classes
Bug-25409-Add-missing-Required-text-and-required-c.patch (text/plain), 2.43 KB, created by
Slava Shishkin
on 2020-05-10 15:22:38 UTC
(
hide
)
Description:
Bug 25409: Add missing “Required” text and “required” classes
Filename:
MIME Type:
Creator:
Slava Shishkin
Created:
2020-05-10 15:22:38 UTC
Size:
2.43 KB
patch
obsolete
>From 1fce3cc511a7a942b228f161fee7fb5fefc2b9de Mon Sep 17 00:00:00 2001 >From: Slava Shishkin <slavashishkin@gmail.com> >Date: Sun, 10 May 2020 18:15:09 +0300 >Subject: [PATCH] =?UTF-8?q?Bug=2025409:=20Add=20missing=20=E2=80=9CRequire?= > =?UTF-8?q?d=E2=80=9D=20text=20and=20=E2=80=9Crequired=E2=80=9D=20classes?= >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >Highlight text with red by adding ârequiredâ class to the label and added red >âRequiredâ text next to select field in "onboardingstep5.tt" template. > >To test: > 1) Start new installation. During onboarding tool phase you will be > requested to create a new circulation rule. > 2) Observe that "Units" label has no "required" class and that > thereâs no âRequiredâ text next to a select field. > 3) Apply patch. > 4) Repeat step 2 (you can reload circulation rule creation page). > 5) Observe the error is gone. >--- > .../prog/en/modules/onboarding/onboardingstep5.tt | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep5.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep5.tt >index 0a1455c7d2..e70870f500 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep5.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep5.tt >@@ -79,7 +79,7 @@ > <span class="required">Required</span> > </li> > <li> >- <label for="lengthunit">Units: </label> >+ <label for="lengthunit" class="required">Units: </label> > <select name="lengthunit" id="lengthunit" required="required"> > <option value=""> Choose </option> > [% SET units = 'days' %] >@@ -96,6 +96,7 @@ > <option value="hours" selected="selected">Hours</option> > [% END %] > </select> >+ <span class="required">Required</span> > </li> > <li> > <label for="renewalsallowed" class="required">Renewals allowed: </label> >-- >2.17.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 25409
:
104486
|
104493
|
104499
|
104556
|
104634
|
104684