Bugzilla – Attachment 104639 Details for
Bug 25440
Remove undef and CGI warnings and fix template variables list in circulation rules
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 25440: Fix for "uninitialized value in hash" warning in smart-rules.pl
Bug-25440-Fix-for-uninitialized-value-in-hash-warn.patch (text/plain), 1.54 KB, created by
Andrii Nugged
on 2020-05-10 16:09:43 UTC
(
hide
)
Description:
Bug 25440: Fix for "uninitialized value in hash" warning in smart-rules.pl
Filename:
MIME Type:
Creator:
Andrii Nugged
Created:
2020-05-10 16:09:43 UTC
Size:
1.54 KB
patch
obsolete
>From 8f70c2eb043e7ce0a89b8d150187da8314c3375b Mon Sep 17 00:00:00 2001 >From: Andrew Nugged <nugged@gmail.com> >Date: Sun, 10 May 2020 18:18:35 +0300 >Subject: [PATCH] Bug 25440: Fix for "uninitialized value in hash" warning in > smart-rules.pl > >This warning emitted: > >Use of uninitialized value in hash element >at /admin/smart-rules.pl line 569. > >that happened because we have NULLs in SQL results for 'categorycode' >and 'itemtype' which later used as 'any' kind of category/item in the >template, so for the template it passed this way: > > $rules->{ $r->{categorycode} }->{ $r->{itemtype} }->... > >but undef will stringify as "" to become a hash key ("Hashes are >unordered collections of scalar values indexed by their associated >string key" https://perldoc.perl.org/perldata.html), > >that's why "undef warning". To prevent warning here is the simple fix: > > $rules->{ $r->{categorycode} // '' }->{ $r->{itemtype} // '' }->... >--- > admin/smart-rules.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/admin/smart-rules.pl b/admin/smart-rules.pl >index 99c8ed1445..b5272c8325 100755 >--- a/admin/smart-rules.pl >+++ b/admin/smart-rules.pl >@@ -565,7 +565,7 @@ my $definedbranch = $all_rules->count ? 1 : 0; > my $rules = {}; > while ( my $r = $all_rules->next ) { > $r = $r->unblessed; >- $rules->{ $r->{categorycode} }->{ $r->{itemtype} }->{ $r->{rule_name} } = $r->{rule_value}; >+ $rules->{ $r->{categorycode} // '' }->{ $r->{itemtype} // '' }->{ $r->{rule_name} } = $r->{rule_value}; > } > > $template->param(show_branch_cat_rule_form => 1); >-- >2.17.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 25440
:
104635
|
104636
|
104637
|
104638
|
104639
|
104640
|
105059
|
105063
|
105985
|
106300
|
106301
|
106302
|
106303
|
106304
|
106305
|
106388