Bugzilla – Attachment 104657 Details for
Bug 25301
Category code is blank when renewing or editing expired/expiring patron
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 25301: removed URI parameter "categorycode" from "circulation.tt"
Bug-25301-removed-URI-parameter-categorycode-from-.patch (text/plain), 3.54 KB, created by
Jonathan Druart
on 2020-05-11 09:11:08 UTC
(
hide
)
Description:
Bug 25301: removed URI parameter "categorycode" from "circulation.tt"
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2020-05-11 09:11:08 UTC
Size:
3.54 KB
patch
obsolete
>From af58c4834c8d22b7fdeb38e129e052c44d93b214 Mon Sep 17 00:00:00 2001 >From: Petro Vashchuk <stalkernoid@gmail.com> >Date: Thu, 7 May 2020 12:22:24 +0300 >Subject: [PATCH] Bug 25301: removed URI parameter "categorycode" from > "circulation.tt" > >"Edit details" links in patron's circulation check-out page >was sending empty query parameter "categorycode" because there is no >defined template parameter in "circulation.pl" > >This patch removes the URI parameter from "circulation.tt" template. > >To test: > 1) You need to create or find expired or expiring patron. > 2) Head to patron's circulation check-out page. > 3) Inspect "Edit details" link. > 4) Observe empty parameter "categorycode=" in that link. > 5) Apply patch. > 6) Repeat step 3. > 7) Check that there's no "categorycode=" in the link anymore. > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >index 7423164850..1b1784b906 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >@@ -688,7 +688,7 @@ > [% IF ( warndeparture ) %] > <li> > <span class="circ-hlt">Expiration:</span> Patron's card will expire soon. >- Patron's card expires on [% expiry | $KohaDates %] <a href="/cgi-bin/koha/members/setstatus.pl?borrowernumber=[% patron.borrowernumber | uri %]&destination=circ&reregistration=y">Renew</a> or <a href="/cgi-bin/koha/members/memberentry.pl?op=modify&destination=circ&borrowernumber=[% patron.borrowernumber | html %]&categorycode=[% categorycode | html %]">Edit details</a> >+ Patron's card expires on [% expiry | $KohaDates %] <a href="/cgi-bin/koha/members/setstatus.pl?borrowernumber=[% patron.borrowernumber | uri %]&destination=circ&reregistration=y">Renew</a> or <a href="/cgi-bin/koha/members/memberentry.pl?op=modify&destination=circ&borrowernumber=[% patron.borrowernumber | html %]">Edit details</a> > > </li> > [% END %] >@@ -705,7 +705,7 @@ > [% IF ( expiry ) %] > Patron's card expired on [% expiry | $KohaDates %] > [% END %] >- <a href="/cgi-bin/koha/members/setstatus.pl?borrowernumber=[% patron.borrowernumber | uri %]&destination=circ&reregistration=y">Renew</a> or <a href="/cgi-bin/koha/members/memberentry.pl?op=modify&destination=circ&borrowernumber=[% patron.borrowernumber | html %]&categorycode=[% categorycode | html %]">Edit details</a> >+ <a href="/cgi-bin/koha/members/setstatus.pl?borrowernumber=[% patron.borrowernumber | uri %]&destination=circ&reregistration=y">Renew</a> or <a href="/cgi-bin/koha/members/memberentry.pl?op=modify&destination=circ&borrowernumber=[% patron.borrowernumber | html %]">Edit details</a> > </li> > [% END %] > >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 25301
:
104418
|
104484
|
104630
|
104631
|
104656
| 104657 |
104658