Bugzilla – Attachment 104673 Details for
Bug 15253
Add Koha::Logger based logging for SIP2
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 15253: Add POD to C4/SIP/Logger.pm and C4/SIP/Trapper.pm
Bug-15253-Add-POD-to-C4SIPLoggerpm-and-C4SIPTrappe.patch (text/plain), 2.27 KB, created by
Jonathan Druart
on 2020-05-11 10:13:02 UTC
(
hide
)
Description:
Bug 15253: Add POD to C4/SIP/Logger.pm and C4/SIP/Trapper.pm
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2020-05-11 10:13:02 UTC
Size:
2.27 KB
patch
obsolete
>From 8b4e31d8ae1ad969a0c9cdd37f955c98e9782838 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Wed, 29 Apr 2020 06:42:29 -0400 >Subject: [PATCH] Bug 15253: Add POD to C4/SIP/Logger.pm and C4/SIP/Trapper.pm > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > C4/SIP/Logger.pm | 22 +++++++++++++++++++++- > C4/SIP/Trapper.pm | 16 ++++++++++++++++ > 2 files changed, 37 insertions(+), 1 deletion(-) > >diff --git a/C4/SIP/Logger.pm b/C4/SIP/Logger.pm >index 8eff6826e2..41169219d1 100644 >--- a/C4/SIP/Logger.pm >+++ b/C4/SIP/Logger.pm >@@ -6,11 +6,15 @@ use Modern::Perl; > our $activeSIPServer; > our $activeLogger; > >+=head1 NAME >+ >+C4::SIP::Logger - Module for handling SIP server logging >+ > =head2 get_SIPServer > > my $sipServer = C4::SIP::SIPServer::get_SIPServer() > >-@RETURNS C4::SIP::SIPServer, the current server's child-process used to handle this SIP-transaction >+ @RETURNS C4::SIP::SIPServer, the current server's child-process used to handle this SIP-transaction > > =cut > >@@ -18,6 +22,16 @@ sub get_SIPServer { > return $activeSIPServer; > } > >+=head2 _set_SIPServer >+ >+ my $sipServer = C4::SIP::SIPServer::_set_SIPServer($sipServer) >+ >+ Sets the passed in SIP server as the active SIP server and returns it as well >+ >+ @RETURNS C4::SIP::SIPServer, the current server's child-process used to handle this SIP-transaction >+ >+=cut >+ > sub _set_SIPServer { > my ($sipServer) = @_; > $activeSIPServer = $sipServer; >@@ -36,6 +50,12 @@ sub get_logger { > return $activeLogger; > } > >+=head2 set_logger >+ >+ my $logger = C4::SIP::SIPServer::set_logger($logger) >+ >+=cut >+ > sub set_logger { > my ($logger) = @_; > $activeLogger = $logger; >diff --git a/C4/SIP/Trapper.pm b/C4/SIP/Trapper.pm >index 8dce10ed0c..8f115b59b7 100644 >--- a/C4/SIP/Trapper.pm >+++ b/C4/SIP/Trapper.pm >@@ -4,11 +4,27 @@ use Modern::Perl; > > use Koha::Logger; > >+=head1 NAME >+ >+C4::SIP::Trapper - Module for capturing warnings for the SIP logger >+ >+=head2 TIEHANDLE >+ >+ Ties the given class to this module. >+ >+=cut >+ > sub TIEHANDLE { > my $class = shift; > bless [], $class; > } > >+=head2 PRINT >+ >+ Captures warnings and directs them to Koha::Logger as well as STDERR >+ >+=cut >+ > sub PRINT { > my $self = shift; > $Log::Log4perl::caller_depth++; >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15253
:
45824
|
45825
|
45826
|
58570
|
58571
|
58572
|
58573
|
58582
|
60872
|
65219
|
65220
|
65221
|
65222
|
65223
|
65224
|
65225
|
65226
|
65227
|
65228
|
71702
|
71703
|
74947
|
86573
|
86574
|
87993
|
88383
|
100062
|
100063
|
100379
|
102216
|
102217
|
102218
|
102219
|
103456
|
103457
|
103458
|
103459
|
103462
|
103499
|
103500
|
103501
|
103502
|
103503
|
103599
|
103915
|
103916
|
103917
|
103918
|
103919
|
103920
|
103921
|
104016
|
104667
|
104668
|
104669
|
104670
|
104671
|
104672
| 104673 |
104674
|
111169