Bugzilla – Attachment 104709 Details for
Bug 25418
Backdated check out date loses time
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 25418: (bug 25133 follow-up) Display due date with hours
Bug-25418-bug-25133-follow-up-Display-due-date-wit.patch (text/plain), 3.97 KB, created by
Nick Clemens (kidclamp)
on 2020-05-11 17:10:05 UTC
(
hide
)
Description:
Bug 25418: (bug 25133 follow-up) Display due date with hours
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2020-05-11 17:10:05 UTC
Size:
3.97 KB
patch
obsolete
>From 8a3d1bdb70a63530879d1d294c4ebf0b947ac166 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 7 May 2020 17:18:35 +0200 >Subject: [PATCH] Bug 25418: (bug 25133 follow-up) Display due date with hours > >And not as due date, it's not a display-only info, but an input. > >This patch is a follow-up of Bug 25133: Fix time part of due date for 12hr > >== Test plan == >1. create checkouts with the following params and results >2. tomorrow 11:59 PM timeformat syspref: 12h > - item is due without a specific time, only date (after-checkout green box) >3. backdate 11:59 PM timeformat syspref: 12h > - note the yellow confirm box has only the date > - item is due at 12:00 PM (after-checkout green box) >4. tomorrow 11:23 AM timeformat syspref: 12h > - item is due at 11:23 AM (after-checkout green box) >5. backdate 11:23 AM timeformat syspref: 12h > - note the yellow confirm box has the date and time > - item is due 11:23 AM (after-checkout green box) >6. tomorrow 23:59 timeformat syspref: 24h > - item is due without a specific time, only date (after-checkout green box) >7. backdate 23:59 timeformat syspref: 24h > - note the yellow confirm box has only the date > - item is due at 00:00 (after-checkout green box) >8. tomorrow 11:23 timeformat syspref: 24h > - item is due at 11:23 (after-checkout green box) >9. backdate 11:23 timeformat syspref: 24h > - note the yellow confirm box has the date and time > - item is due 11:23 (after-checkout green box) >10. apply patch >11. create checkouts with the following params and results >12. tomorrow 11:59 PM timeformat syspref: 12h > - item is due without a specific time, only date (after-checkout green box) >13. backdate 11:59 PM timeformat syspref: 12h > - note the yellow confirm box has the date and time > - CHANGE COMPARED TO BEFORE THE PATCH > - item is due without a specific time, only date (after-checkout green box) > - CHANGE COMPARED TO BEFORE THE PATCH >14. tomorrow 11:23 AM timeformat syspref: 12h > - item is due 11:23 AM (after-checkout green box) >15. backdate 11:23 AM timeformat syspref: 12h > - note the yellow confirm box has the date and time > - item is due 11:23 AM (after-checkout green box) >16. tomorrow 23:59 timeformat syspref: 24h > - item is due without a specific time, only date (after-checkout green box) >17. backdate 23:59 timeformat syspref: 24h > - note the yellow confirm box has the date and time > - CHANGE COMPARED TO BEFORE THE PATCH > - item is due without a specific time, only date (after-checkout green box) > - CHANGE COMPARED TO BEFORE THE PATCH >18. tomorrow 11:23 timeformat syspref: 24h > - item is due at 11:23 (after-checkout green box) >19. backdate 11:23 timeformat syspref: 24h > - note the yellow confirm box has the date and time > - item is due 11:23 (after-checkout green box) > >Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >index a4d721a062..0c1b10be55 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >@@ -236,7 +236,7 @@ > > [% IF ( INVALID_DATE ) %] > <p> >- <input type="text" size="13" id="duedatespec" name="duedatespec" value="[% duedatespec | $KohaDates as_due_date => 1 %]" /> >+ <input type="text" size="13" id="duedatespec" name="duedatespec" value="[% duedatespec | $KohaDates with_hours => 1 %]" /> > <label for="duedatespec">Due date</label> > </p> > [% ELSE %] >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 25418
:
104521
|
104705
| 104709 |
104710