Bugzilla – Attachment 104736 Details for
Bug 25417
Backdating returns and forgiving fines causes and internal server error
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 25417: Prevent negative debit amount on backdating returns
Bug-25417-Prevent-negative-debit-amount-on-backdat.patch (text/plain), 1.05 KB, created by
Martin Renvoize (ashimema)
on 2020-05-12 08:32:04 UTC
(
hide
)
Description:
Bug 25417: Prevent negative debit amount on backdating returns
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2020-05-12 08:32:04 UTC
Size:
1.05 KB
patch
obsolete
>From 2123648688b0ac383e2be02e406d641b6f5ee245 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 8 May 2020 12:28:46 +0200 >Subject: [PATCH] Bug 25417: Prevent negative debit amount on backdating > returns > >Koha::Account->add_credit is expecting a positive amount. > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >Signed-off-by: Didier Gautheron <didier.gautheron@biblibre.com> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > C4/Circulation.pm | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index 8db887db2e..99e1423e51 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -2433,6 +2433,8 @@ sub _FixOverduesOnReturn { > if ($exemptfine) { > my $amountoutstanding = $accountline->amountoutstanding; > >+ return if $amountoutstanding <= 0; >+ > my $account = Koha::Account->new({patron_id => $borrowernumber}); > my $credit = $account->add_credit( > { >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 25417
:
104535
|
104536
|
104575
|
104576
|
104578
|
104579
|
104580
|
104644
|
104645
|
104715
|
104716
|
104730
|
104731
|
104732
|
104733
|
104734
|
104735
|
104736
|
104737
|
104738
|
104739
|
104749
|
104750
|
104751
|
104752
|
104753
|
104754