Bugzilla – Attachment 104840 Details for
Bug 25480
koha-create may hide useful error
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 25480: Don't hide apache error and display incorrect error
Bug-25480-Dont-hide-apache-error-and-display-incor.patch (text/plain), 3.07 KB, created by
Tomás Cohen Arazi (tcohen)
on 2020-05-13 12:14:10 UTC
(
hide
)
Description:
Bug 25480: Don't hide apache error and display incorrect error
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2020-05-13 12:14:10 UTC
Size:
3.07 KB
patch
obsolete
>From 80eae983a109e3696a85b781392583517cb7e141 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 13 May 2020 13:05:48 +0200 >Subject: [PATCH] Bug 25480: Don't hide apache error and display incorrect > error > >When searching if some apache mod are enable we are hiding the error (2> /dev/null) and display an error about the (guessed) missing module. > >It can lead to wrong tracks, let display the original apache error if there is one. > >This is linked with https://gitlab.com/koha-community/koha-testing-docker/-/merge_requests/119 > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > debian/scripts/koha-create | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > >diff --git a/debian/scripts/koha-create b/debian/scripts/koha-create >index 43d58fd2b5e..45c1ef644ff 100755 >--- a/debian/scripts/koha-create >+++ b/debian/scripts/koha-create >@@ -151,16 +151,16 @@ check_apache_config() > { > > # Check that mpm_itk is installed and enabled >- if ! /usr/sbin/apachectl -M 2> /dev/null | grep -q 'mpm_itk'; then >+ if ! /usr/sbin/apachectl -M | grep -q 'mpm_itk'; then > # Check Apache version > APACHE_DISABLE_MPM_MSG="" > if /usr/sbin/apache2ctl -v | grep -q "Server version: Apache/2.4"; then > # mpm_event or mpm_worker need to be disabled first. mpm_itk depends > # on mpm_prefork, which is enabled if needed. See > # https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=734865 >- if /usr/sbin/apachectl -M 2> /dev/null | grep -q 'mpm_event'; then >+ if /usr/sbin/apachectl -M | grep -q 'mpm_event'; then > APACHE_DISABLE_MPM_MSG=" sudo a2dismod mpm_event ;" >- elif /usr/sbin/apachectl -M 2> /dev/null | grep -q 'mpm_worker'; then >+ elif /usr/sbin/apachectl -M | grep -q 'mpm_worker'; then > APACHE_DISABLE_MPM_MSG=" sudo a2dismod mpm_worker ;" > # else mpm_prefork: a2enmod mpm_itk works > fi >@@ -179,7 +179,7 @@ EOM > fi > > # Check that mod_rewrite is installed and enabled. >- if ! /usr/sbin/apachectl -M 2> /dev/null | grep -q 'rewrite_module'; then >+ if ! /usr/sbin/apachectl -M | grep -q 'rewrite_module'; then > cat 1>&2 <<EOM > > Koha requires mod_rewrite to be enabled within Apache in order to run. >@@ -192,7 +192,7 @@ EOM > > # Check that the CGI module is installed and enabled > # (Apache 2.4 may not have it by default.) >- if ! /usr/sbin/apachectl -M 2> /dev/null | grep -q 'cgi_module'; then >+ if ! /usr/sbin/apachectl -M | grep -q 'cgi_module'; then > cat 1>&2 << EOM > Koha requires mod_cgi to be enabled within Apache in order to run. > Typically this can be enabled with: >@@ -204,7 +204,7 @@ EOM > > # Check that mod_ssl is installed and enabled. > if [ "$CLO_LETSENCRYPT" = "yes" ]; then >- if ! /usr/sbin/apachectl -M 2> /dev/null | grep -q 'ssl_module'; then >+ if ! /usr/sbin/apachectl -M | grep -q 'ssl_module'; then > cat 1>&2 <<EOM > > Koha requires mod_ssl to be enabled within Apache in order to run with --letsencrypt. >-- >2.26.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 25480
:
104835
|
104840
|
104875