Bugzilla – Attachment 10485 Details for
Bug 6679
Fixing code so it passes basic Perl::Critic tests
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[FAILED-QA]Bug 6679 - fix 19 perlcritic violations from C4::Letters.pm
Bug-6679---fix-19-perlcritic-violations-from-C4Let.patch (text/plain), 4.79 KB, created by
Mason James
on 2012-06-26 04:16:19 UTC
(
hide
)
Description:
[FAILED-QA]Bug 6679 - fix 19 perlcritic violations from C4::Letters.pm
Filename:
MIME Type:
Creator:
Mason James
Created:
2012-06-26 04:16:19 UTC
Size:
4.79 KB
patch
obsolete
>From e0fe0bd22d8e1116b0f17d4000cc614a73ce6c97 Mon Sep 17 00:00:00 2001 >From: Mason James <mtj@kohaaloha.com> >Date: Tue, 26 Jun 2012 16:14:02 +1200 >Subject: [PATCH] Bug 6679 - fix 19 perlcritic violations from C4::Letters.pm >Content-Type: text/plain; charset="utf-8" >http://koha-community.org > >"return" statement with explicit "undef" at line 979, column 28. See page 199 of PBP. (Severity: 5) > >Subroutine prototypes used at line 997, column 1. See page 194 of PBP. (Severity: 5) >--- > C4/Letters.pm | 44 ++++++++++++++++++++++---------------------- > 1 files changed, 22 insertions(+), 22 deletions(-) > >diff --git a/C4/Letters.pm b/C4/Letters.pm >index 514b355..fd3d774 100644 >--- a/C4/Letters.pm >+++ b/C4/Letters.pm >@@ -93,7 +93,7 @@ $template->param(LETTERLOOP => \@letterloop); > > =cut > >-sub GetLetters (;$) { >+sub GetLetters { > > # returns a reference to a hash of references to ALL letters... > my $cat = shift; >@@ -117,7 +117,7 @@ sub GetLetters (;$) { > } > > my %letter; >-sub getletter ($$$) { >+sub getletter { > my ( $module, $code, $branchcode ) = @_; > > if (C4::Context->preference('IndependantBranches') && $branchcode){ >@@ -149,7 +149,7 @@ sub getletter ($$$) { > > =cut > >-sub addalert ($$$) { >+sub addalert { > my ( $borrowernumber, $type, $externalid ) = @_; > my $dbh = C4::Context->dbh; > my $sth = >@@ -170,7 +170,7 @@ sub addalert ($$$) { > > =cut > >-sub delalert ($) { >+sub delalert { > my $alertid = shift or die "delalert() called without valid argument (alertid)"; # it's gonna die anyway. > $debug and warn "delalert: deleting alertid $alertid"; > my $sth = C4::Context->dbh->prepare("delete from alert where alertid=?"); >@@ -187,7 +187,7 @@ sub delalert ($) { > > =cut > >-sub getalert (;$$$) { >+sub getalert { > my ( $borrowernumber, $type, $externalid ) = @_; > my $dbh = C4::Context->dbh; > my $query = "SELECT a.*, b.branchcode FROM alert a JOIN borrowers b USING(borrowernumber) WHERE"; >@@ -224,16 +224,16 @@ sub getalert (;$$$) { > # outmoded POD: > # When type=virtual, the id is related to a virtual shelf and this sub returns the name of the sub > >-sub findrelatedto ($$) { >- my $type = shift or return undef; >- my $externalid = shift or return undef; >+sub findrelatedto { >+ my $type = shift or return ; >+ my $externalid = shift or return ; > my $q = ($type eq 'issue' ) ? > "select title as result from subscription left join biblio on subscription.biblionumber=biblio.biblionumber where subscriptionid=?" : > ($type eq 'borrower') ? > "select concat(firstname,' ',surname) from borrowers where borrowernumber=?" : undef; > unless ($q) { > warn "findrelatedto(): Illegal type '$type'"; >- return undef; >+ return; > } > my $sth = C4::Context->dbh->prepare($q); > $sth->execute($externalid); >@@ -665,12 +665,12 @@ return message_id on success > > =cut > >-sub EnqueueLetter ($) { >- my $params = shift or return undef; >+sub EnqueueLetter { >+ my $params = shift or return; > >- return unless exists $params->{'letter'}; >- return unless exists $params->{'borrowernumber'}; >- return unless exists $params->{'message_transport_type'}; >+ return exists $params->{'letter'}; >+ return exists $params->{'borrowernumber'}; >+ return exists $params->{'message_transport_type'}; > > # If we have any attachments we should encode then into the body. > if ( $params->{'attachments'} ) { >@@ -716,7 +716,7 @@ returns number of messages sent. > > =cut > >-sub SendQueuedMessages (;$) { >+sub SendQueuedMessages { > my $params = shift; > > my $unsent_messages = _get_unsent_messages(); >@@ -861,7 +861,7 @@ sub _add_attachments { > > } > >-sub _get_unsent_messages (;$) { >+sub _get_unsent_messages { > my $params = shift; > > my $dbh = C4::Context->dbh(); >@@ -893,7 +893,7 @@ ENDSQL > return $sth->fetchall_arrayref({}); > } > >-sub _send_message_by_email ($;$$$) { >+sub _send_message_by_email { > my $message = shift or return; > my ($username, $password, $method) = @_; > >@@ -975,8 +975,8 @@ $content > EOS > } > >-sub _send_message_by_sms ($) { >- my $message = shift or return undef; >+sub _send_message_by_sms { >+ my $message = shift or return; > my $member = C4::Members::GetMember( 'borrowernumber' => $message->{'borrowernumber'} ); > return unless $member->{'smsalertnumber'}; > >@@ -994,11 +994,11 @@ sub _update_message_to_address { > $dbh->do('UPDATE message_queue SET to_address=? WHERE message_id=?',undef,($to,$id)); > } > >-sub _set_message_status ($) { >- my $params = shift or return undef; >+sub _set_message_status { >+ my $params = shift or return; > > foreach my $required_parameter ( qw( message_id status ) ) { >- return undef unless exists $params->{ $required_parameter }; >+ return unless exists $params->{ $required_parameter }; > } > > my $dbh = C4::Context->dbh(); >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 6679
:
4883
|
4884
|
4885
|
4886
|
4887
|
4888
|
5445
|
5446
|
5483
|
5487
|
6121
|
6122
|
6123
|
6139
|
6140
|
6141
|
6142
|
6143
|
6144
|
6270
|
6271
|
6663
|
6670
|
6675
|
6676
|
6677
|
6678
|
8542
|
8897
|
8898
|
8899
|
8950
|
8951
|
9746
|
9747
|
9748
|
9749
|
9750
|
10050
|
10051
|
10052
|
10053
|
10054
|
10075
|
10076
|
10077
|
10078
|
10079
|
10484
|
10485
|
10486
|
10487
|
10488
|
10489
|
10491
|
10492
|
10493
|
10494
|
10495
|
10496
|
10497
|
10499
|
10500
|
10501
|
10502
|
10503
|
10504
|
10505
|
10506
|
10507
|
10508
|
10509
|
10510
|
10512
|
10513
|
10514
|
10515
|
10517
|
10521
|
10522
|
10523
|
10524
|
10525
|
10526
|
10527
|
10935
|
10936
|
10938
|
10940
|
10944
|
10945
|
10946
|
10947
|
10948
|
10949
|
10950
|
10952
|
10953
|
10955
|
10957
|
10958
|
10959
|
10960
|
10961
|
10962
|
10963
|
10964
|
10965
|
10966
|
10967
|
10972
|
10976
|
10979
|
10980
|
10981
|
12224
|
12363
|
12490
|
12491
|
12492
|
34191
|
34192
|
34193
|
34194
|
34195
|
34196
|
34197
|
39100
|
39101
|
39102
|
39392
|
39393
|
39394
|
39395
|
39396
|
39397
|
39398
|
42770
|
47086
|
47087
|
47088
|
47089
|
47090
|
47178
|
47179
|
47180
|
47181
|
47205
|
47206
|
47207
|
47208