Bugzilla – Attachment 104855 Details for
Bug 25494
Warnings in advanced editor macros routes
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 25494: Remove warnings in advanced editor macros routes
Bug-25494-Remove-warnings-in-advanced-editor-macro.patch (text/plain), 1.21 KB, created by
Tomás Cohen Arazi (tcohen)
on 2020-05-13 21:34:48 UTC
(
hide
)
Description:
Bug 25494: Remove warnings in advanced editor macros routes
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2020-05-13 21:34:48 UTC
Size:
1.21 KB
patch
obsolete
>From 778d8be39fc6aa1cb711a09649fb2de5e3456c28 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Wed, 13 May 2020 18:33:00 -0300 >Subject: [PATCH] Bug 25494: Remove warnings in advanced editor macros routes > >There's a couple leftover 'warn's in the controller code. >This patch removes that. > >To test: >1. Run: > $ kshell > k$ prove t/db_dependent/api/v1/advanced_editor_macros.t >=> FAIL: Two numbers are warned >2. Apply this patch and repeat 1 >=> SUCCESS: No more warns >3. Sign off :-D >--- > Koha/REST/V1/AdvancedEditorMacro.pm | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > >diff --git a/Koha/REST/V1/AdvancedEditorMacro.pm b/Koha/REST/V1/AdvancedEditorMacro.pm >index 92077713cc5..8cb4cb3833c 100644 >--- a/Koha/REST/V1/AdvancedEditorMacro.pm >+++ b/Koha/REST/V1/AdvancedEditorMacro.pm >@@ -75,8 +75,7 @@ sub get { > error => "This macro is shared, you must access it via advanced_editor/macros/shared" > }); > } >- warn $macro->borrowernumber; >- warn $patron->borrowernumber; >+ > if( $macro->borrowernumber != $patron->borrowernumber ){ > return $c->render( status => 403, openapi => { > error => "You do not have permission to access this macro" >-- >2.26.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 25494
: 104855