Bugzilla – Attachment 10486 Details for
Bug 6679
Fixing code so it passes basic Perl::Critic tests
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
fix 15 perlcritic violations in C4/ImportExportFramework.pm
fix-15-perlcritic-violations-in-C4ImportExportFram.patch (text/plain), 3.90 KB, created by
Mason James
on 2012-06-26 04:40:30 UTC
(
hide
)
Description:
fix 15 perlcritic violations in C4/ImportExportFramework.pm
Filename:
MIME Type:
Creator:
Mason James
Created:
2012-06-26 04:40:30 UTC
Size:
3.90 KB
patch
obsolete
>From 18556c12f2ff53a15a20e928e3844be63deaee5f Mon Sep 17 00:00:00 2001 >From: Mason James <mtj@kohaaloha.com> >Date: Tue, 26 Jun 2012 16:39:27 +1200 >Subject: [PATCH] fix 15 perlcritic violations in C4/ImportExportFramework.pm >Content-Type: text/plain; charset="utf-8" >http://koha-community.org > >Bareword file handle opened at line 558, column 17. See pages 202,204 of PBP. (Severity: 5) > >Two-argument "open" used at line 558, column 17. See page 207 of PBP. (Severity: 5) > >http://bugs.koha-community.org/show_bug.cgi?id=6679 >--- > C4/ImportExportFramework.pm | 48 ++++++++++++++++++++++-------------------- > 1 files changed, 25 insertions(+), 23 deletions(-) > >diff --git a/C4/ImportExportFramework.pm b/C4/ImportExportFramework.pm >index b81b393..72873f2 100644 >--- a/C4/ImportExportFramework.pm >+++ b/C4/ImportExportFramework.pm >@@ -515,7 +515,7 @@ sub _createTmpDir > mkdir $tempdir; > }; > if ($@) { >- return undef; >+ return; > } else { > return $tempdir; > } >@@ -547,27 +547,28 @@ sub createODS > $tempdir = _createTmpDir($tmp); > } > if ($tempdir) { >+ my $fh; > # populate tempdir directory with the ods elements > eval { >- if (open(OUT, "> $tempdir/content.xml")) { >- print OUT $strContent; >- close(OUT); >+ if (open($fh, '>', "$tempdir/content.xml")) { >+ print {$fh} $strContent; >+ close($fh); > } >- if (open(OUT, "> $tempdir/mimetype")) { >- print OUT 'application/vnd.oasis.opendocument.spreadsheet'; >- close(OUT); >+ if (open($fh, '>', "$tempdir/mimetype")) { >+ print {$fh} 'application/vnd.oasis.opendocument.spreadsheet'; >+ close($fh); > } >- if (open(OUT, "> $tempdir/meta.xml")) { >- print OUT _getMeta($lang); >- close(OUT); >+ if (open($fh, '>', "$tempdir/meta.xml")) { >+ print {$fh} _getMeta($lang); >+ close($fh); > } >- if (open(OUT, "> $tempdir/styles.xml")) { >- print OUT ODS_STYLES_STR; >- close(OUT); >+ if (open($fh, '>', "$tempdir/styles.xml")) { >+ print {$fh} ODS_STYLES_STR; >+ close($fh); > } >- if (open(OUT, "> $tempdir/settings.xml")) { >- print OUT ODS_SETTINGS_STR; >- close(OUT); >+ if (open($fh, '>', "$tempdir/settings.xml")) { >+ print {$fh} ODS_SETTINGS_STR; >+ close($fh); > } > mkdir($tempdir.'/META-INF/'); > mkdir($tempdir.'/Configurations2/'); >@@ -579,9 +580,10 @@ sub createODS > mkdir($tempdir.'/Configurations2/menubar/'); > mkdir($tempdir.'/Configurations2/progressbar/'); > mkdir($tempdir.'/Configurations2/toolbar/'); >- if (open(OUT, "> $tempdir/META-INF/manifest.xml")) { >- print OUT ODS_MANIFEST_STR; >- close(OUT); >+ >+ if (open($fh, '>', "$tempdir/META-INF/manifest.xml")) { >+ print {$fh} ODS_MANIFEST_STR; >+ close($fh); > } > }; > if ($@) { >@@ -604,13 +606,13 @@ sub createODS > my $ok = 0; > # read ods file and return as a string > if (-f "$tempdir/new.ods") { >- if (open (MYFILE, "$tempdir/new.ods")) { >- binmode MYFILE; >+ if (open ($fh, '<', "$tempdir/new.ods")) { >+ binmode $fh; > my $buffer; >- while (read (MYFILE, $buffer, 65536)) { >+ while (read ($fh, $buffer, 65536)) { > $$strODSRef .= $buffer; > } >- close(MYFILE); >+ close($fh); > $ok = 1; > } > } >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 6679
:
4883
|
4884
|
4885
|
4886
|
4887
|
4888
|
5445
|
5446
|
5483
|
5487
|
6121
|
6122
|
6123
|
6139
|
6140
|
6141
|
6142
|
6143
|
6144
|
6270
|
6271
|
6663
|
6670
|
6675
|
6676
|
6677
|
6678
|
8542
|
8897
|
8898
|
8899
|
8950
|
8951
|
9746
|
9747
|
9748
|
9749
|
9750
|
10050
|
10051
|
10052
|
10053
|
10054
|
10075
|
10076
|
10077
|
10078
|
10079
|
10484
|
10485
|
10486
|
10487
|
10488
|
10489
|
10491
|
10492
|
10493
|
10494
|
10495
|
10496
|
10497
|
10499
|
10500
|
10501
|
10502
|
10503
|
10504
|
10505
|
10506
|
10507
|
10508
|
10509
|
10510
|
10512
|
10513
|
10514
|
10515
|
10517
|
10521
|
10522
|
10523
|
10524
|
10525
|
10526
|
10527
|
10935
|
10936
|
10938
|
10940
|
10944
|
10945
|
10946
|
10947
|
10948
|
10949
|
10950
|
10952
|
10953
|
10955
|
10957
|
10958
|
10959
|
10960
|
10961
|
10962
|
10963
|
10964
|
10965
|
10966
|
10967
|
10972
|
10976
|
10979
|
10980
|
10981
|
12224
|
12363
|
12490
|
12491
|
12492
|
34191
|
34192
|
34193
|
34194
|
34195
|
34196
|
34197
|
39100
|
39101
|
39102
|
39392
|
39393
|
39394
|
39395
|
39396
|
39397
|
39398
|
42770
|
47086
|
47087
|
47088
|
47089
|
47090
|
47178
|
47179
|
47180
|
47181
|
47205
|
47206
|
47207
|
47208