Bugzilla – Attachment 10487 Details for
Bug 6679
Fixing code so it passes basic Perl::Critic tests
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 6679 - fix 12 perlcritic violations in C4/Context.pm
Bug-6679---fix-12-perlcritic-violations-in-C4Conte.patch (text/plain), 3.23 KB, created by
Mason James
on 2012-06-26 12:36:33 UTC
(
hide
)
Description:
Bug 6679 - fix 12 perlcritic violations in C4/Context.pm
Filename:
MIME Type:
Creator:
Mason James
Created:
2012-06-26 12:36:33 UTC
Size:
3.23 KB
patch
obsolete
>From 41f1d6570f1c2963feb5fda65ab1adb8b469b594 Mon Sep 17 00:00:00 2001 >From: Mason James <mtj@kohaaloha.com> >Date: Wed, 27 Jun 2012 00:34:43 +1200 >Subject: [PATCH] Bug 6679 - fix 12 perlcritic violations in C4/Context.pm >Content-Type: text/plain; charset="utf-8" >http://koha-community.org > >"return" statement with explicit "undef" at line 486, column 5. See page 199 of PBP. (Severity: 5) > >Subroutine prototypes used at line 548, column 1. See page 194 of PBP. (Severity: 5) >--- > C4/Context.pm | 24 ++++++++++++------------ > 1 files changed, 12 insertions(+), 12 deletions(-) > >diff --git a/C4/Context.pm b/C4/Context.pm >index 9ce6c74..a602f11 100644 >--- a/C4/Context.pm >+++ b/C4/Context.pm >@@ -276,7 +276,7 @@ sub memcached { > if ($ismemcached) { > return $memcached; > } else { >- return undef; >+ return; > } > } > >@@ -293,7 +293,7 @@ sub db_scheme2dbi { > if (/Postgres|Pg|PostgresSQL/) { return("Pg"); } > if (/oracle/) { return("Oracle"); } > } >- return undef; # Just in case >+ return; # Just in case > } > > sub import { >@@ -358,7 +358,7 @@ sub new { > $conf_fname = CONFIG_FNAME; > } else { > warn "unable to locate Koha configuration file koha-conf.xml"; >- return undef; >+ return; > } > } > >@@ -376,7 +376,7 @@ sub new { > > $self->{"config_file"} = $conf_fname; > warn "read_config_file($conf_fname) returned undef" if !defined($self->{"config"}); >- return undef if !defined($self->{"config"}); >+ return if !defined($self->{"config"}); > > $self->{"dbh"} = undef; # Database handle > $self->{"Zconn"} = undef; # Zebra Connections >@@ -480,10 +480,10 @@ C<C4::Config-E<gt>new> will not return it. > > =cut > >-sub _common_config ($$) { >+sub _common_config { > my $var = shift; > my $term = shift; >- return undef if !defined($context->{$term}); >+ return if !defined($context->{$term}); > # Presumably $self->{$term} might be > # undefined if the config file given to &new > # didn't exist, and the caller didn't bother >@@ -545,7 +545,7 @@ END_SQL > return $sysprefs{$var}; > } > >-sub boolean_preference ($) { >+sub boolean_preference { > my $self = shift; > my $var = shift; # The system preference to return > my $it = preference($self, $var); >@@ -1027,19 +1027,19 @@ sub set_userenv { > return $cell; > } > >-sub set_shelves_userenv ($$) { >- my ($type, $shelves) = @_ or return undef; >- my $activeuser = $context->{activeuser} or return undef; >+sub set_shelves_userenv { >+ my ($type, $shelves) = @_ or return; >+ my $activeuser = $context->{activeuser} or return; > $context->{userenv}->{$activeuser}->{barshelves} = $shelves if $type eq 'bar'; > $context->{userenv}->{$activeuser}->{pubshelves} = $shelves if $type eq 'pub'; > $context->{userenv}->{$activeuser}->{totshelves} = $shelves if $type eq 'tot'; > } > >-sub get_shelves_userenv () { >+sub get_shelves_userenv { > my $active; > unless ($active = $context->{userenv}->{$context->{activeuser}}) { > $debug and warn "get_shelves_userenv cannot retrieve context->{userenv}->{context->{activeuser}}"; >- return undef; >+ return; > } > my $totshelves = $active->{totshelves} or undef; > my $pubshelves = $active->{pubshelves} or undef; >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 6679
:
4883
|
4884
|
4885
|
4886
|
4887
|
4888
|
5445
|
5446
|
5483
|
5487
|
6121
|
6122
|
6123
|
6139
|
6140
|
6141
|
6142
|
6143
|
6144
|
6270
|
6271
|
6663
|
6670
|
6675
|
6676
|
6677
|
6678
|
8542
|
8897
|
8898
|
8899
|
8950
|
8951
|
9746
|
9747
|
9748
|
9749
|
9750
|
10050
|
10051
|
10052
|
10053
|
10054
|
10075
|
10076
|
10077
|
10078
|
10079
|
10484
|
10485
|
10486
|
10487
|
10488
|
10489
|
10491
|
10492
|
10493
|
10494
|
10495
|
10496
|
10497
|
10499
|
10500
|
10501
|
10502
|
10503
|
10504
|
10505
|
10506
|
10507
|
10508
|
10509
|
10510
|
10512
|
10513
|
10514
|
10515
|
10517
|
10521
|
10522
|
10523
|
10524
|
10525
|
10526
|
10527
|
10935
|
10936
|
10938
|
10940
|
10944
|
10945
|
10946
|
10947
|
10948
|
10949
|
10950
|
10952
|
10953
|
10955
|
10957
|
10958
|
10959
|
10960
|
10961
|
10962
|
10963
|
10964
|
10965
|
10966
|
10967
|
10972
|
10976
|
10979
|
10980
|
10981
|
12224
|
12363
|
12490
|
12491
|
12492
|
34191
|
34192
|
34193
|
34194
|
34195
|
34196
|
34197
|
39100
|
39101
|
39102
|
39392
|
39393
|
39394
|
39395
|
39396
|
39397
|
39398
|
42770
|
47086
|
47087
|
47088
|
47089
|
47090
|
47178
|
47179
|
47180
|
47181
|
47205
|
47206
|
47207
|
47208