Bugzilla – Attachment 104874 Details for
Bug 25482
Wrong permissions in spec break Plack on Debian 10
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 25482: Explicitly set macros as not shard during tests
Bug-25482-Explicitly-set-macros-as-not-shard-durin.patch (text/plain), 2.24 KB, created by
Tomás Cohen Arazi (tcohen)
on 2020-05-14 11:32:52 UTC
(
hide
)
Description:
Bug 25482: Explicitly set macros as not shard during tests
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2020-05-14 11:32:52 UTC
Size:
2.24 KB
patch
obsolete
>From 9f43a3e2a2737b02c0090b556837357658fd5c4f Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Thu, 14 May 2020 10:42:06 +0000 >Subject: [PATCH] Bug 25482: Explicitly set macros as not shard during tests > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > Koha/REST/V1/AdvancedEditorMacro.pm | 2 -- > t/db_dependent/api/v1/advanced_editor_macros.t | 4 +++- > 2 files changed, 3 insertions(+), 3 deletions(-) > >diff --git a/Koha/REST/V1/AdvancedEditorMacro.pm b/Koha/REST/V1/AdvancedEditorMacro.pm >index 92077713cc5..e94106242a8 100644 >--- a/Koha/REST/V1/AdvancedEditorMacro.pm >+++ b/Koha/REST/V1/AdvancedEditorMacro.pm >@@ -75,8 +75,6 @@ sub get { > error => "This macro is shared, you must access it via advanced_editor/macros/shared" > }); > } >- warn $macro->borrowernumber; >- warn $patron->borrowernumber; > if( $macro->borrowernumber != $patron->borrowernumber ){ > return $c->render( status => 403, openapi => { > error => "You do not have permission to access this macro" >diff --git a/t/db_dependent/api/v1/advanced_editor_macros.t b/t/db_dependent/api/v1/advanced_editor_macros.t >index e4a0625272c..72fb17703cf 100644 >--- a/t/db_dependent/api/v1/advanced_editor_macros.t >+++ b/t/db_dependent/api/v1/advanced_editor_macros.t >@@ -56,6 +56,7 @@ subtest 'list() tests' => sub { > name => 'Test1', > macro => 'delete 100', > borrowernumber => $patron_1->borrowernumber, >+ shared => 0, > } > }); > my $macro_2 = $builder->build_object({ class => 'Koha::AdvancedEditorMacros', value => >@@ -63,7 +64,7 @@ subtest 'list() tests' => sub { > name => 'Test2', > macro => 'delete 100', > borrowernumber => $patron_1->borrowernumber, >- shared=> 1, >+ shared => 1, > } > }); > my $macro_3 = $builder->build_object({ class => 'Koha::AdvancedEditorMacros', value => >@@ -71,6 +72,7 @@ subtest 'list() tests' => sub { > name => 'Test3', > macro => 'delete 100', > borrowernumber => $patron_2->borrowernumber, >+ shared => 0, > } > }); > my $macro_4 = $builder->build_object({ class => 'Koha::AdvancedEditorMacros', value => >-- >2.26.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 25482
:
104856
|
104857
|
104873
|
104874
|
104936
|
104937
|
104938