Attachment 104892 Details for Bug 25506 – Bug 25506: Fix for "Use of uninitialized value" in about.pl

[patch] Bug 25506: Fix for "Use of uninitialized value" in about.pl

Bug-25506-Fix-for-Use-of-uninitialized-value-in-ab.patch (text/plain), 1.60 KB, created by Slava Shishkin on 2020-05-14 15:00:12 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Slava Shishkin

Created: 2020-05-14 15:00:12 UTC

Size: 1.60 KB

patch

obsolete

>From 1746d9473d6d31c72cdc89f7791b3443a909c8f5 Mon Sep 17 00:00:00 2001
>From: Slava Shishkin <slavashishkin@gmail.com>
>Date: Thu, 14 May 2020 17:53:47 +0300
>Subject: [PATCH] Bug 25506: Fix for "Use of uninitialized value" in about.pl
>
>Perl warning on the "About Koha" page:
>
>Use of uninitialized value in string eq
>at /home/vagrant/kohaclone/about.pl line 220.
>
>Fixed by adding additional precheck for
>C4::Context->config('zebra_auth_index_mode') being Perl's "true".
>
>To test:
>    1) Ensure you don't have "<zebra_auth_index_mode>...
>       </zebra_auth_index_mode>" in your koha-conf.xml so you will have
>       "C4::Context->config" returning "undef"
>    2) Go to the "About Koha" page.
>    3) Observe the warning in the log file.
>    4) Apply patch.
>    5) Repeat step 2.
>    6) Check that previous warning was suppressed.
>---
> about.pl | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
>diff --git a/about.pl b/about.pl
>index fc8dcec21c..62a94d87f4 100755
>--- a/about.pl
>+++ b/about.pl
>@@ -217,7 +217,10 @@ if (    C4::Context->config('zebra_auth_index_mode')
>     push @xml_config_warnings, { error => 'zebra_auth_index_mode_is_grs1' };
> }
> 
>-if ( (C4::Context->config('zebra_auth_index_mode') eq 'dom') && ($context->{'server'}->{'authorityserver'}->{'config'} !~ /zebra-authorities-dom.cfg/) ) {
>+if( (   C4::Context->config('zebra_auth_index_mode')
>+    and C4::Context->config('zebra_auth_index_mode') eq 'dom' )
>+    && ( $context->{'server'}->{'authorityserver'}->{'config'} !~ /zebra-authorities-dom.cfg/ ) )
>+{
>     push @xml_config_warnings, {
>         error => 'zebra_auth_index_mode_mismatch_warn'
>     };
>-- 
>2.17.1

Actions: View | Diff | Splinter Review

Attachments on bug 25506: 104892 | 104980 | 105192