Bugzilla – Attachment 104936 Details for
Bug 25482
Wrong permissions in spec break Plack on Debian 10
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 25482: Wrong permissions specification for adv editor macros
Bug-25482-Wrong-permissions-specification-for-adv-.patch (text/plain), 2.12 KB, created by
Martin Renvoize (ashimema)
on 2020-05-15 11:45:46 UTC
(
hide
)
Description:
Bug 25482: Wrong permissions specification for adv editor macros
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2020-05-15 11:45:46 UTC
Size:
2.12 KB
patch
obsolete
>From 0019df23746f2630a36ee2d51cc1fe84676b5e0a Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Wed, 13 May 2020 19:07:17 -0300 >Subject: [PATCH] Bug 25482: Wrong permissions specification for adv editor > macros > >The current permissions are defined as a hash, with a duplicate key. >This is generally invalid, but Debian 9's Mojolicious::Plugin::OpenAPI >lets it go through, even though the results are, random? > >This patch sets the required permissions right, and following the >haspermissions() syntax correctly. > >Tests for searching macros are not passing. Still trying to figure. > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > api/v1/swagger/paths/advancededitormacros.json | 18 ++++++++++++------ > 1 file changed, 12 insertions(+), 6 deletions(-) > >diff --git a/api/v1/swagger/paths/advancededitormacros.json b/api/v1/swagger/paths/advancededitormacros.json >index 120d14d64b..2fa8f2034a 100644 >--- a/api/v1/swagger/paths/advancededitormacros.json >+++ b/api/v1/swagger/paths/advancededitormacros.json >@@ -178,8 +178,10 @@ > }, > "x-koha-authorization": { > "permissions": { >- "editcatalogue": "advanced_editor", >- "editcatalogue": "create_shared_macros" >+ "editcatalogue": { >+ "advanced_editor": 1, >+ "create_shared_macros": 1 >+ } > } > } > } >@@ -457,8 +459,10 @@ > }, > "x-koha-authorization": { > "permissions": { >- "editcatalogue": "advanced_editor", >- "editcatalogue": "create_shared_macros" >+ "editcatalogue": { >+ "advanced_editor": 1, >+ "create_shared_macros": 1 >+ } > } > } > }, >@@ -512,8 +516,10 @@ > }, > "x-koha-authorization": { > "permissions": { >- "editcatalogue": "advanced_editor", >- "editcatalogue": "delete_shared_macros" >+ "editcatalogue": { >+ "advanced_editor": 1, >+ "delete_shared_macros": 1 >+ } > } > } > } >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 25482
:
104856
|
104857
|
104873
|
104874
| 104936 |
104937
|
104938