Attachment 10494 Details for Bug 6679 – Bug 6679 - [SIGNED-OFF]fix 12 perlcritic violations in C4/External/BakerTaylor.pm

[patch] Bug 6679 - [SIGNED-OFF]fix 12 perlcritic violations in C4/External/BakerTaylor.pm

Bug-6679---fix-12-perlcritic-violations-in-C4Exter.patch (text/plain), 2.32 KB, created by Jonathan Druart on 2012-06-26 13:13:20 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2012-06-26 13:13:20 UTC

Size: 2.32 KB

patch

obsolete

>From c4e91828929acc9636e1081c32707ea8cf991fc6 Mon Sep 17 00:00:00 2001
>From: Mason James <mtj@kohaaloha.com>
>Date: Wed, 27 Jun 2012 00:43:07 +1200
>Subject: [PATCH] Bug 6679 - fix 12 perlcritic violations in
> C4/External/BakerTaylor.pm
>
>Subroutine prototypes used at line 82, column 1.  See page 194 of PBP.  (Severity: 5)
>
>"return" statement with explicit "undef" at line 83, column 22.  See page 199 of PBP.  (Severity: 5)
>
>Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
>---
> C4/External/BakerTaylor.pm |   22 +++++++++++-----------
> 1 files changed, 11 insertions(+), 11 deletions(-)
>
>diff --git a/C4/External/BakerTaylor.pm b/C4/External/BakerTaylor.pm
>index 3503db0..47c04cc 100644
>--- a/C4/External/BakerTaylor.pm
>+++ b/C4/External/BakerTaylor.pm
>@@ -50,26 +50,26 @@ sub initialize {
> 			#"Mozilla/4.76 [en] (Win98; U)",	#  if for some reason you want to go stealth, you might prefer this
> }
> 
>-sub image_url (;$) {
>-	($user and $pass) or return undef;
>+sub image_url {
>+	($user and $pass) or return;
> 	my $isbn = (@_ ? shift : '');
> 	$isbn =~ s/(p|-)//g;	# sanitize
> 	return $image_url . $isbn;
> }
>-sub link_url (;$) {
>+sub link_url {
> 	my $isbn = (@_ ? shift : '');
> 	$isbn =~ s/(p|-)//g;	# sanitize
>-	$link_url or return undef;
>+	$link_url or return;
> 	return $link_url . $isbn;
> }
>-sub content_cafe_url ($) {
>-	($user and $pass) or return undef;
>+sub content_cafe_url {
>+	($user and $pass) or return;
> 	my $isbn = (@_ ? shift : '');
> 	$isbn =~ s/(p|-)//g;	# sanitize
> 	return "http://contentcafe2.btol.com/ContentCafeClient/ContentCafe.aspx?UserID=$user&Password=$pass&Options=Y&ItemKey=$isbn";
> }
>-sub http_jacket_link ($) {
>-	my $isbn = shift or return undef;
>+sub http_jacket_link {
>+	my $isbn = shift or return;
> 	$isbn =~ s/(p|-)//g;	# sanitize
> 	my $image = availability($isbn);
> 	my $alt = "Buy this book";
>@@ -79,9 +79,9 @@ sub http_jacket_link ($) {
> 	return sprintf qq(<a class="btlink" href="%s">%s</a>),$link,($image||$alt);
> }
> 
>-sub availability ($) {
>-	my $isbn = shift or return undef;
>-	($user and $pass) or return undef;
>+sub availability {
>+	my $isbn = shift or return;
>+	($user and $pass) or return;
> 	$isbn =~ s/(p|-)//g;	# sanitize
> 	my $url = "http://contentcafe2.btol.com/ContentCafe/InventoryAvailability.asmx/CheckInventory?UserID=$user&Password=$pass&Value=$isbn";
> 	$debug and warn __PACKAGE__ . " request:\n$url\n";
>-- 
>1.7.7.3

Actions: View | Diff | Splinter Review

Attachments on bug 6679: 4883 | 4884 | 4885 | 4886 | 4887 | 4888 | 5445 | 5446 | 5483 | 5487 | 6121 | 6122 | 6123 | 6139 | 6140 | 6141 | 6142 | 6143 | 6144 | 6270 | 6271 | 6663 | 6670 | 6675 | 6676 | 6677 | 6678 | 8542 | 8897 | 8898 | 8899 | 8950 | 8951 | 9746 | 9747 | 9748 | 9749 | 9750 | 10050 | 10051 | 10052 | 10053 | 10054 | 10075 | 10076 | 10077 | 10078 | 10079 | 10484 | 10485 | 10486 | 10487 | 10488 | 10489 | 10491 | 10492 | 10493 | 10494 | 10495 | 10496 | 10497 | 10499 | 10500 | 10501 | 10502 | 10503 | 10504 | 10505 | 10506 | 10507 | 10508 | 10509 | 10510 | 10512 | 10513 | 10514 | 10515 | 10517 | 10521 | 10522 | 10523 | 10524 | 10525 | 10526 | 10527 | 10935 | 10936 | 10938 | 10940 | 10944 | 10945 | 10946 | 10947 | 10948 | 10949 | 10950 | 10952 | 10953 | 10955 | 10957 | 10958 | 10959 | 10960 | 10961 | 10962 | 10963 | 10964 | 10965 | 10966 | 10967 | 10972 | 10976 | 10979 | 10980 | 10981 | 12224 | 12363 | 12490 | 12491 | 12492 | 34191 | 34192 | 34193 | 34194 | 34195 | 34196 | 34197 | 39100 | 39101 | 39102 | 39392 | 39393 | 39394 | 39395 | 39396 | 39397 | 39398 | 42770 | 47086 | 47087 | 47088 | 47089 | 47090 | 47178 | 47179 | 47180 | 47181 | 47205 | 47206 | 47207 | 47208