Attachment 10501 Details for Bug 6679 – Bug 6679 - fix 7 perlcritic violations in C4/Biblio.pm

[patch] Bug 6679 - fix 7 perlcritic violations in C4/Biblio.pm

Bug-6679---fix-7-perlcritic-violations-in-C4Biblio.patch (text/plain), 2.33 KB, created by Mason James on 2012-06-26 13:44:40 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mason James

Created: 2012-06-26 13:44:40 UTC

Size: 2.33 KB

patch

obsolete

>From c6e50e2154d9c10d2aa9f59fcb3602b4de8c4548 Mon Sep 17 00:00:00 2001
>From: Mason James <mtj@kohaaloha.com>
>Date: Wed, 27 Jun 2012 01:30:33 +1200
>Subject: [PATCH] Bug 6679 - fix 7 perlcritic violations in C4/Biblio.pm
>Content-Type: text/plain; charset="utf-8"
>http://koha-community.org
>
>- Expression form of "eval" at line 492, column 12.  See page 161 of PBP.  (Severity: 5)
>
>- "return" statement with explicit "undef" at line 891, column 5.  See page 199 of PBP.  (Severity: 5)
>
>- Subroutine prototypes used at line 1148, column 1.  See page 194 of PBP.  (Severity: 5)
>---
> C4/Biblio.pm |   14 +++++++-------
> 1 files changed, 7 insertions(+), 7 deletions(-)
>
>diff --git a/C4/Biblio.pm b/C4/Biblio.pm
>index 1ab4fff..a6378e6 100644
>--- a/C4/Biblio.pm
>+++ b/C4/Biblio.pm
>@@ -489,10 +489,10 @@ sub BiblioAutoLink {
> 
>     my $linker_module =
>       "C4::Linker::" . ( C4::Context->preference("LinkerModule") || 'Default' );
>-    eval { eval "require $linker_module"; };
>+    eval { eval {require $linker_module}; };
>     if ($@) {
>         $linker_module = 'C4::Linker::Default';
>-        eval "require $linker_module";
>+        eval {require $linker_module};
>     }
>     if ($@) {
>         return 0, 0;
>@@ -888,7 +888,7 @@ Return the ISBD view which can be included in opac and intranet
> sub GetISBDView {
>     my ( $biblionumber, $template ) = @_;
>     my $record   = GetMarcBiblio($biblionumber, 1);
>-    return undef unless defined $record;
>+    return unless defined $record;
>     my $itemtype = &GetFrameworkCode($biblionumber);
>     my ( $holdingbrtagf, $holdingbrtagsubf ) = &GetMarcFromKohaField( "items.holdingbranch", $itemtype );
>     my $tagslib = &GetMarcStructure( 1, $itemtype );
>@@ -1145,7 +1145,7 @@ C<$frameworkcode> is the framework code.
> 
> =cut
> 
>-sub GetUsedMarcStructure($) {
>+sub GetUsedMarcStructure {
>     my $frameworkcode = shift || '';
>     my $query = qq/
>         SELECT *
>@@ -1210,7 +1210,7 @@ sub GetMarcBiblio {
> 
>         return $record;
>     } else {
>-        return undef;
>+        return;
>     }
> }
> 
>@@ -3452,7 +3452,7 @@ sub _koha_delete_biblio {
>         $sth2->finish;
>     }
>     $sth->finish;
>-    return undef;
>+    return;
> }
> 
> =head2 _koha_delete_biblioitems
>@@ -3501,7 +3501,7 @@ sub _koha_delete_biblioitems {
>         $sth2->finish;
>     }
>     $sth->finish;
>-    return undef;
>+    return;
> }
> 
> =head1 UNEXPORTED FUNCTIONS
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 6679: 4883 | 4884 | 4885 | 4886 | 4887 | 4888 | 5445 | 5446 | 5483 | 5487 | 6121 | 6122 | 6123 | 6139 | 6140 | 6141 | 6142 | 6143 | 6144 | 6270 | 6271 | 6663 | 6670 | 6675 | 6676 | 6677 | 6678 | 8542 | 8897 | 8898 | 8899 | 8950 | 8951 | 9746 | 9747 | 9748 | 9749 | 9750 | 10050 | 10051 | 10052 | 10053 | 10054 | 10075 | 10076 | 10077 | 10078 | 10079 | 10484 | 10485 | 10486 | 10487 | 10488 | 10489 | 10491 | 10492 | 10493 | 10494 | 10495 | 10496 | 10497 | 10499 | 10500 | 10501 | 10502 | 10503 | 10504 | 10505 | 10506 | 10507 | 10508 | 10509 | 10510 | 10512 | 10513 | 10514 | 10515 | 10517 | 10521 | 10522 | 10523 | 10524 | 10525 | 10526 | 10527 | 10935 | 10936 | 10938 | 10940 | 10944 | 10945 | 10946 | 10947 | 10948 | 10949 | 10950 | 10952 | 10953 | 10955 | 10957 | 10958 | 10959 | 10960 | 10961 | 10962 | 10963 | 10964 | 10965 | 10966 | 10967 | 10972 | 10976 | 10979 | 10980 | 10981 | 12224 | 12363 | 12490 | 12491 | 12492 | 34191 | 34192 | 34193 | 34194 | 34195 | 34196 | 34197 | 39100 | 39101 | 39102 | 39392 | 39393 | 39394 | 39395 | 39396 | 39397 | 39398 | 42770 | 47086 | 47087 | 47088 | 47089 | 47090 | 47178 | 47179 | 47180 | 47181 | 47205 | 47206 | 47207 | 47208