Attachment 10503 Details for Bug 6679 – Bug 6679 - fix 6 perlcritic violations in C4/Barcodes/hbyymmincr.pm

[patch] Bug 6679 - fix 6 perlcritic violations in C4/Barcodes/hbyymmincr.pm

Bug-6679---fix-6-perlcritic-violations-in-C4Barcod.patch (text/plain), 2.37 KB, created by Mason James on 2012-06-26 13:54:33 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mason James

Created: 2012-06-26 13:54:33 UTC

Size: 2.37 KB

patch

obsolete

>From 2c97a59f1931bc73df3c022aa84985c0bf14adf6 Mon Sep 17 00:00:00 2001
>From: Mason James <mtj@kohaaloha.com>
>Date: Wed, 27 Jun 2012 01:53:05 +1200
>Subject: [PATCH] Bug 6679 - fix 6 perlcritic violations in C4/Barcodes/hbyymmincr.pm
>Content-Type: text/plain; charset="utf-8"
>http://koha-community.org
>
>- Subroutine prototypes used at line 45, column 1.  See page 194 of PBP.  (Severity: 5)
>---
> C4/Barcodes/hbyymmincr.pm |   12 ++++++------
> 1 files changed, 6 insertions(+), 6 deletions(-)
>
>diff --git a/C4/Barcodes/hbyymmincr.pm b/C4/Barcodes/hbyymmincr.pm
>index ca3149f..258a1a5 100644
>--- a/C4/Barcodes/hbyymmincr.pm
>+++ b/C4/Barcodes/hbyymmincr.pm
>@@ -42,7 +42,7 @@ INIT {
> # Generates barcode where hb = home branch Code, yymm = year/month catalogued, incr = incremental number,
> # 	increment resets yearly -fbcit
> 
>-sub db_max ($;$) {
>+sub db_max {
> 	my $self = shift;
> 	my $query = "SELECT MAX(SUBSTRING(barcode,-$width)), barcode FROM items WHERE barcode REGEXP ? GROUP BY barcode";
> 	$debug and print STDERR "(hbyymmincr) db_max query: $query\n";
>@@ -71,14 +71,14 @@ sub db_max ($;$) {
> 	return ($max || 0);
> }
> 
>-sub initial () {
>+sub initial {
> 	my $self = shift;
> 	# FIXME: populated branch?
> 	my $iso = C4::Dates->new->output('iso'); 	# like "2008-07-02"
> 	return $self->branch . substr($iso,2,2) . substr($iso,5,2) . sprintf('%' . "$width.$width" . 'd',1);
> }
> 
>-sub parse ($;$) {   # return 3 parts of barcode: non-incrementing, incrementing, non-incrementing
>+sub parse {   # return 3 parts of barcode: non-incrementing, incrementing, non-incrementing
> 	my $self = shift;
> 	my $barcode = (@_) ? shift : $self->value;
> 	my $branch = $self->branch;
>@@ -90,17 +90,17 @@ sub parse ($;$) {   # return 3 parts of barcode: non-incrementing, incrementing,
> 	return ($1,$2,'');  # the third part is in anticipation of barcodes that include checkdigits
> }
> 
>-sub branch ($;$) {
>+sub branch {
> 	my $self = shift;
> 	(@_) and $self->{branch} = shift;
> 	return $self->{branch};
> }
>-sub width ($;$) {
>+sub width {
> 	my $self = shift;
> 	(@_) and $width = shift;	# hitting the class variable.
> 	return $width;
> }
>-sub process_head($$;$$) {	# (self,head,whole,specific)
>+sub process_head {	# (self,head,whole,specific)
> 	my ($self,$head,$whole,$specific) = @_;
> 	$specific and return $head;	# if this is built off an existing barcode, just return the head unchanged.
> 	$head =~ s/\d{4}$//;		# else strip the old yymm
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 6679: 4883 | 4884 | 4885 | 4886 | 4887 | 4888 | 5445 | 5446 | 5483 | 5487 | 6121 | 6122 | 6123 | 6139 | 6140 | 6141 | 6142 | 6143 | 6144 | 6270 | 6271 | 6663 | 6670 | 6675 | 6676 | 6677 | 6678 | 8542 | 8897 | 8898 | 8899 | 8950 | 8951 | 9746 | 9747 | 9748 | 9749 | 9750 | 10050 | 10051 | 10052 | 10053 | 10054 | 10075 | 10076 | 10077 | 10078 | 10079 | 10484 | 10485 | 10486 | 10487 | 10488 | 10489 | 10491 | 10492 | 10493 | 10494 | 10495 | 10496 | 10497 | 10499 | 10500 | 10501 | 10502 | 10503 | 10504 | 10505 | 10506 | 10507 | 10508 | 10509 | 10510 | 10512 | 10513 | 10514 | 10515 | 10517 | 10521 | 10522 | 10523 | 10524 | 10525 | 10526 | 10527 | 10935 | 10936 | 10938 | 10940 | 10944 | 10945 | 10946 | 10947 | 10948 | 10949 | 10950 | 10952 | 10953 | 10955 | 10957 | 10958 | 10959 | 10960 | 10961 | 10962 | 10963 | 10964 | 10965 | 10966 | 10967 | 10972 | 10976 | 10979 | 10980 | 10981 | 12224 | 12363 | 12490 | 12491 | 12492 | 34191 | 34192 | 34193 | 34194 | 34195 | 34196 | 34197 | 39100 | 39101 | 39102 | 39392 | 39393 | 39394 | 39395 | 39396 | 39397 | 39398 | 42770 | 47086 | 47087 | 47088 | 47089 | 47090 | 47178 | 47179 | 47180 | 47181 | 47205 | 47206 | 47207 | 47208