Bugzilla – Attachment 105057 Details for
Bug 25535
Hold API mapping maps cancellationdate to cancelation_date, but it should be cancellation_date
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 25535: Hold API mapping maps cancellationdate to cancelation_date, but it should be cancellation_date
Bug-25535-Hold-API-mapping-maps-cancellationdate-t.patch (text/plain), 2.02 KB, created by
Martin Renvoize (ashimema)
on 2020-05-19 07:02:38 UTC
(
hide
)
Description:
Bug 25535: Hold API mapping maps cancellationdate to cancelation_date, but it should be cancellation_date
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2020-05-19 07:02:38 UTC
Size:
2.02 KB
patch
obsolete
>From 467dd0943d8c814394b8fcd4d1e15fac438e5b67 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Mon, 18 May 2020 14:14:42 -0400 >Subject: [PATCH] Bug 25535: Hold API mapping maps cancellationdate to > cancelation_date, but it should be cancellation_date > >Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > Koha/Hold.pm | 2 +- > api/v1/swagger/definitions/hold.json | 2 +- > api/v1/swagger/paths/holds.json | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > >diff --git a/Koha/Hold.pm b/Koha/Hold.pm >index 6896f5e94d..e8d9e0cc2c 100644 >--- a/Koha/Hold.pm >+++ b/Koha/Hold.pm >@@ -416,7 +416,7 @@ sub to_api_mapping { > branchcode => 'pickup_library_id', > notificationdate => undef, > reminderdate => undef, >- cancellationdate => 'cancelation_date', >+ cancellationdate => 'cancellation_date', > reservenotes => 'notes', > found => 'status', > itemnumber => 'item_id', >diff --git a/api/v1/swagger/definitions/hold.json b/api/v1/swagger/definitions/hold.json >index dda32600b3..db4c90e209 100644 >--- a/api/v1/swagger/definitions/hold.json >+++ b/api/v1/swagger/definitions/hold.json >@@ -22,7 +22,7 @@ > "type": ["string", "null"], > "description": "Internal library identifier for the pickup library" > }, >- "cancelation_date": { >+ "cancellation_date": { > "type": ["string", "null"], > "format": "date", > "description": "The date the hold was cancelled" >diff --git a/api/v1/swagger/paths/holds.json b/api/v1/swagger/paths/holds.json >index e4e925d8ef..847d3b83ca 100644 >--- a/api/v1/swagger/paths/holds.json >+++ b/api/v1/swagger/paths/holds.json >@@ -37,7 +37,7 @@ > "type": "string" > }, > { >- "name": "cancelation_date", >+ "name": "cancellation_date", > "in": "query", > "description": "The date the hold was cancelled", > "type": "string", >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 25535
:
105037
|
105047
| 105057