Attachment 10506 Details for Bug 6679 – Bug 6679 - fix 4 perlcritic violations in C4/ShelfBrowser.pm

[patch] Bug 6679 - fix 4 perlcritic violations in C4/ShelfBrowser.pm

Bug-6679---fix-4-perlcritic-violations-in-C4ShelfB.patch (text/plain), 1.58 KB, created by Mason James on 2012-06-26 14:11:12 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mason James

Created: 2012-06-26 14:11:12 UTC

Size: 1.58 KB

patch

obsolete

>From 84aa094a424c05a874167745a102cde6cc8bb4d5 Mon Sep 17 00:00:00 2001
>From: Mason James <mtj@kohaaloha.com>
>Date: Wed, 27 Jun 2012 02:10:11 +1200
>Subject: [PATCH] Bug 6679 - fix 4 perlcritic violations in C4/ShelfBrowser.pm
>Content-Type: text/plain; charset="utf-8"
>http://koha-community.org
>
>- Variable declared in conditional statement at line 183, column 5.  Declare  variables outside of the condition.  (Severity: 5)
>---
> C4/ShelfBrowser.pm |   13 +++++++++----
> 1 files changed, 9 insertions(+), 4 deletions(-)
>
>diff --git a/C4/ShelfBrowser.pm b/C4/ShelfBrowser.pm
>index 449190f..c885d90 100644
>--- a/C4/ShelfBrowser.pm
>+++ b/C4/ShelfBrowser.pm
>@@ -180,11 +180,16 @@ sub GetNearbyItems {
>     my @prev_items = reverse GetShelfInfo($sth_prev_items, $marcflavour);
>     my @next_items = GetShelfInfo($sth_next_items, $marcflavour);
> 
>-    my $next_itemnumber = $next_items[-1]->{itemnumber} if @next_items;
>-    my $next_biblionumber = $next_items[-1]->{biblionumber} if @next_items;
>+    my (
>+        $next_itemnumber, $next_biblionumber,
>+        $prev_itemnumber, $prev_biblionumber
>+    );
>+
>+    $next_itemnumber = $next_items[-1]->{itemnumber} if @next_items;
>+    $next_biblionumber = $next_items[-1]->{biblionumber} if @next_items;
> 
>-    my $prev_itemnumber = $prev_items[0]->{itemnumber} if @prev_items;
>-    my $prev_biblionumber = $prev_items[0]->{biblionumber} if @prev_items;
>+    $prev_itemnumber = $prev_items[0]->{itemnumber} if @prev_items;
>+    $prev_biblionumber = $prev_items[0]->{biblionumber} if @prev_items;
> 
>     my %result = (
>         next                => \@next_items,
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 6679: 4883 | 4884 | 4885 | 4886 | 4887 | 4888 | 5445 | 5446 | 5483 | 5487 | 6121 | 6122 | 6123 | 6139 | 6140 | 6141 | 6142 | 6143 | 6144 | 6270 | 6271 | 6663 | 6670 | 6675 | 6676 | 6677 | 6678 | 8542 | 8897 | 8898 | 8899 | 8950 | 8951 | 9746 | 9747 | 9748 | 9749 | 9750 | 10050 | 10051 | 10052 | 10053 | 10054 | 10075 | 10076 | 10077 | 10078 | 10079 | 10484 | 10485 | 10486 | 10487 | 10488 | 10489 | 10491 | 10492 | 10493 | 10494 | 10495 | 10496 | 10497 | 10499 | 10500 | 10501 | 10502 | 10503 | 10504 | 10505 | 10506 | 10507 | 10508 | 10509 | 10510 | 10512 | 10513 | 10514 | 10515 | 10517 | 10521 | 10522 | 10523 | 10524 | 10525 | 10526 | 10527 | 10935 | 10936 | 10938 | 10940 | 10944 | 10945 | 10946 | 10947 | 10948 | 10949 | 10950 | 10952 | 10953 | 10955 | 10957 | 10958 | 10959 | 10960 | 10961 | 10962 | 10963 | 10964 | 10965 | 10966 | 10967 | 10972 | 10976 | 10979 | 10980 | 10981 | 12224 | 12363 | 12490 | 12491 | 12492 | 34191 | 34192 | 34193 | 34194 | 34195 | 34196 | 34197 | 39100 | 39101 | 39102 | 39392 | 39393 | 39394 | 39395 | 39396 | 39397 | 39398 | 42770 | 47086 | 47087 | 47088 | 47089 | 47090 | 47178 | 47179 | 47180 | 47181 | 47205 | 47206 | 47207 | 47208