Bugzilla – Attachment 10508 Details for
Bug 6679
Fixing code so it passes basic Perl::Critic tests
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 6679 - fix 4 perlcritic violations in C4/Creators/PDF.pm
Bug-6679---fix-4-perlcritic-violations-in-C4Creato.patch (text/plain), 2.73 KB, created by
Mason James
on 2012-06-26 14:29:52 UTC
(
hide
)
Description:
Bug 6679 - fix 4 perlcritic violations in C4/Creators/PDF.pm
Filename:
MIME Type:
Creator:
Mason James
Created:
2012-06-26 14:29:52 UTC
Size:
2.73 KB
patch
obsolete
>From dcb7a0a2ba8b88e89a3047ce200d4e23f72f5ad4 Mon Sep 17 00:00:00 2001 >From: Mason James <mtj@kohaaloha.com> >Date: Wed, 27 Jun 2012 02:28:26 +1200 >Subject: [PATCH] Bug 6679 - fix 4 perlcritic violations in C4/Creators/PDF.pm >Content-Type: text/plain; charset="utf-8" >http://koha-community.org > >- "return" statement with explicit "undef" at line 171, column 8. See page 199 of PBP. (Severity: 5) > >- "return" statement with explicit "undef" at line 201, column 8. See page 199 of PBP. (Severity: 5) > >- Bareword file handle opened at line 212, column 11. See pages 202,204 of PBP. (Severity: 5) > >- Two-argument "open" used at line 212, column 11. See page 207 of PBP. (Severity: 5) >--- > C4/Creators/PDF.pm | 12 ++++++------ > 1 files changed, 6 insertions(+), 6 deletions(-) > >diff --git a/C4/Creators/PDF.pm b/C4/Creators/PDF.pm >index 41ff548..871e32b 100644 >--- a/C4/Creators/PDF.pm >+++ b/C4/Creators/PDF.pm >@@ -168,7 +168,7 @@ sub prAltJpeg > { my ($iData, $iWidth, $iHeight, $iFormat,$aiData, $aiWidth, $aiHeight, $aiFormat) = @_; > my ($namnet, $utrad); > if (! $PDF::Reuse::pos) # If no output is active, it is no use to continue >- { return undef; >+ { return; > } > prJpegBlob($aiData, $aiWidth, $aiHeight, $aiFormat); > my $altObjNr = $PDF::Reuse::objNr; >@@ -198,7 +198,7 @@ sub prJpegBlob > { my ($iData, $iWidth, $iHeight, $iFormat, $altArrayObjNr) = @_; > my ($iLangd, $namnet, $utrad); > if (! $PDF::Reuse::pos) # If no output is active, it is no use to continue >- { return undef; >+ { return; > } > my $checkidOld = $PDF::Reuse::checkId; > if (!$iFormat) >@@ -209,16 +209,16 @@ sub prJpegBlob > $namnet = 'Ig' . $PDF::Reuse::imageNr; > $PDF::Reuse::objNr++; > $PDF::Reuse::objekt[$PDF::Reuse::objNr] = $PDF::Reuse::pos; >- open (BILDFIL, "<$iFile") || errLog("Couldn't open $iFile, $!, aborts"); >- binmode BILDFIL; >+ open (my $fh, '<', "$iFile") || errLog("Couldn't open $iFile, $!, aborts"); >+ binmode $fh; > my $iStream; >- sysread BILDFIL, $iStream, $iLangd; >+ sysread $fh, $iStream, $iLangd; > $utrad = "$PDF::Reuse::objNr 0 obj\n<</Type/XObject/Subtype/Image/Name/$namnet" . > "/Width $iWidth /Height $iHeight /BitsPerComponent 8 " . > ($altArrayObjNr ? "/Alternates $altArrayObjNr 0 R " : "") . > "/Filter/DCTDecode/ColorSpace/DeviceRGB" > . "/Length $iLangd >>stream\n$iStream\nendstream\nendobj\n"; >- close BILDFIL; >+ close $fh; > $PDF::Reuse::pos += syswrite $PDF::Reuse::UTFIL, $utrad; > if ($PDF::Reuse::runfil) > { $PDF::Reuse::log .= "Cid~$PDF::Reuse::checkId\n"; >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 6679
:
4883
|
4884
|
4885
|
4886
|
4887
|
4888
|
5445
|
5446
|
5483
|
5487
|
6121
|
6122
|
6123
|
6139
|
6140
|
6141
|
6142
|
6143
|
6144
|
6270
|
6271
|
6663
|
6670
|
6675
|
6676
|
6677
|
6678
|
8542
|
8897
|
8898
|
8899
|
8950
|
8951
|
9746
|
9747
|
9748
|
9749
|
9750
|
10050
|
10051
|
10052
|
10053
|
10054
|
10075
|
10076
|
10077
|
10078
|
10079
|
10484
|
10485
|
10486
|
10487
|
10488
|
10489
|
10491
|
10492
|
10493
|
10494
|
10495
|
10496
|
10497
|
10499
|
10500
|
10501
|
10502
|
10503
|
10504
|
10505
|
10506
|
10507
|
10508
|
10509
|
10510
|
10512
|
10513
|
10514
|
10515
|
10517
|
10521
|
10522
|
10523
|
10524
|
10525
|
10526
|
10527
|
10935
|
10936
|
10938
|
10940
|
10944
|
10945
|
10946
|
10947
|
10948
|
10949
|
10950
|
10952
|
10953
|
10955
|
10957
|
10958
|
10959
|
10960
|
10961
|
10962
|
10963
|
10964
|
10965
|
10966
|
10967
|
10972
|
10976
|
10979
|
10980
|
10981
|
12224
|
12363
|
12490
|
12491
|
12492
|
34191
|
34192
|
34193
|
34194
|
34195
|
34196
|
34197
|
39100
|
39101
|
39102
|
39392
|
39393
|
39394
|
39395
|
39396
|
39397
|
39398
|
42770
|
47086
|
47087
|
47088
|
47089
|
47090
|
47178
|
47179
|
47180
|
47181
|
47205
|
47206
|
47207
|
47208