Bugzilla – Attachment 105093 Details for
Bug 25540
Biblio.t is failing randomly
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 25540: Use build_sample_item
Bug-25540-Use-buildsampleitem.patch (text/plain), 4.02 KB, created by
Jonathan Druart
on 2020-05-19 13:32:33 UTC
(
hide
)
Description:
Bug 25540: Use build_sample_item
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2020-05-19 13:32:33 UTC
Size:
4.02 KB
patch
obsolete
>From e76d3098fc1f7ea6913c56ca2e4f9cc4dfe67c2b Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 19 May 2020 15:31:43 +0200 >Subject: [PATCH] Bug 25540: Use build_sample_item > >--- > t/db_dependent/Koha/Biblio.t | 36 ++++++++---------------------------- > 1 file changed, 8 insertions(+), 28 deletions(-) > >diff --git a/t/db_dependent/Koha/Biblio.t b/t/db_dependent/Koha/Biblio.t >index 59a0895d62..b849fd3160 100644 >--- a/t/db_dependent/Koha/Biblio.t >+++ b/t/db_dependent/Koha/Biblio.t >@@ -321,63 +321,43 @@ subtest 'pickup_locations' => sub { > my $group3_7 = $builder->build_object( { class => 'Koha::Library::Groups', value => { parent_id => $root3->id, branchcode => $library7->branchcode } } ); > my $group3_8 = $builder->build_object( { class => 'Koha::Library::Groups', value => { parent_id => $root3->id, branchcode => $library8->branchcode } } ); > >- my $biblio1 = $builder->build_object( { class => 'Koha::Biblios', value => {title => '1'} } ); >- my $biblioitem1 = $builder->build_object( { class => 'Koha::Biblioitems', value => { biblionumber => $biblio1->biblionumber } } ); >- my $biblio2 = $builder->build_object( { class => 'Koha::Biblios', value => {title => '2'} } ); >- my $biblioitem2 = $builder->build_object( { class => 'Koha::Biblioitems', value => { biblionumber => $biblio2->biblionumber } } ); >+ my $biblio1 = $builder->build_sample_biblio({ title => '1' }); >+ my $biblio2 = $builder->build_sample_biblio({ title => '2' }); > >- my $item1_1 = Koha::Item->new({ >+ my $item1_1 = $builder->build_sample_item({ > biblionumber => $biblio1->biblionumber, >- biblioitemnumber => $biblioitem1->biblioitemnumber, > homebranch => $library1->branchcode, > holdingbranch => $library2->branchcode, >- itype => 'test', >- barcode => "item11barcode", > })->store; > >- my $item1_3 = Koha::Item->new({ >+ my $item1_3 = $builder->build_sample_item({ > biblionumber => $biblio1->biblionumber, >- biblioitemnumber => $biblioitem1->biblioitemnumber, > homebranch => $library3->branchcode, > holdingbranch => $library4->branchcode, >- itype => 'test', >- barcode => "item13barcode", > })->store; > >- my $item1_7 = Koha::Item->new({ >+ my $item1_7 = $builder->build_sample_item({ > biblionumber => $biblio1->biblionumber, >- biblioitemnumber => $biblioitem1->biblioitemnumber, > homebranch => $library7->branchcode, > holdingbranch => $library4->branchcode, >- itype => 'test', >- barcode => "item17barcode", > })->store; > >- my $item2_2 = Koha::Item->new({ >+ my $item2_2 = $builder->build_sample_item({ > biblionumber => $biblio2->biblionumber, >- biblioitemnumber => $biblioitem2->biblioitemnumber, > homebranch => $library2->branchcode, > holdingbranch => $library1->branchcode, >- itype => 'test', >- barcode => "item22barcode", > })->store; > >- my $item2_4 = Koha::Item->new({ >+ my $item2_4 = $builder->build_sample_item({ > biblionumber => $biblio2->biblionumber, >- biblioitemnumber => $biblioitem2->biblioitemnumber, > homebranch => $library4->branchcode, > holdingbranch => $library3->branchcode, >- itype => 'test', >- barcode => "item23barcode", > })->store; > >- my $item2_6 = Koha::Item->new({ >+ my $item2_6 = $builder->build_sample_item({ > biblionumber => $biblio2->biblionumber, >- biblioitemnumber => $biblioitem2->biblioitemnumber, > homebranch => $library6->branchcode, > holdingbranch => $library4->branchcode, >- itype => 'test', >- barcode => "item26barcode", > })->store; > > my $patron1 = $builder->build_object( { class => 'Koha::Patrons', value => { firstname=>'1', branchcode => $library1->branchcode } } ); >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 25540
:
105093
|
105094
|
105266
|
105290
|
105291
|
105292
|
105296
|
105297
|
115204
|
115205