Attachment 105103 Details for Bug 25531 – Bug 25531: Debar patron if needed when checkin is backdated

[patch] Bug 25531: Debar patron if needed when checkin is backdated

Bug-25531-Debar-patron-if-needed-when-checkin-is-b.patch (text/plain), 1.44 KB, created by Martin Renvoize (ashimema) on 2020-05-19 15:46:49 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2020-05-19 15:46:49 UTC

Size: 1.44 KB

patch

obsolete

>From 416bf214901588a58187eeae6a2eb8edb5ab5c58 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Mon, 18 May 2020 17:50:11 +0200
>Subject: [PATCH] Bug 25531: Debar patron if needed when checkin is backdated
>
>If think this case does not apply to real-life, but the logic needs to
>be fixed.
>If an item is due now, and AddReturn is called now with a return date in
>the future, the issue is overdue and the patron must be debarred.
>However it is not as we compare with now and not the return date
>
>Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> C4/Circulation.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/C4/Circulation.pm b/C4/Circulation.pm
>index 5f48cfc288..e439250933 100644
>--- a/C4/Circulation.pm
>+++ b/C4/Circulation.pm
>@@ -2053,7 +2053,7 @@ sub AddReturn {
>         my $fix = _FixOverduesOnReturn( $borrowernumber, $item->itemnumber, $exemptfine, 'RETURNED' );
>         defined($fix) or warn "_FixOverduesOnReturn($borrowernumber, $item->itemnumber...) failed!";  # zero is OK, check defined
> 
>-        if ( $issue and $issue->is_overdue ) {
>+        if ( $issue and $issue->is_overdue($return_date) ) {
>         # fix fine days
>             my ($debardate,$reminder) = _debar_user_on_return( $patron_unblessed, $item->unblessed, dt_from_string($issue->date_due), $return_date );
>             if ($reminder){
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 25531: 105030 | 105031 | 105064 | 105096 | 105097 | 105102 | 105103 | 105168