Bugzilla – Attachment 105125 Details for
Bug 25524
Debian packages always append to /etc/koha/sites/$site/log4perl.conf
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 25524: Remove --line-regexp option in log4perl_component()
Bug-25524-Remove---line-regexp-option-in-log4perlc.patch (text/plain), 1.74 KB, created by
Tomás Cohen Arazi (tcohen)
on 2020-05-19 22:24:31 UTC
(
hide
)
Description:
Bug 25524: Remove --line-regexp option in log4perl_component()
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2020-05-19 22:24:31 UTC
Size:
1.74 KB
patch
obsolete
>From 14a4e42679ecb43cb8911ab2d5f5a17654874add Mon Sep 17 00:00:00 2001 >From: David Cook <dcook@prosentient.com.au> >Date: Mon, 18 May 2020 07:08:18 +0000 >Subject: [PATCH] Bug 25524: Remove --line-regexp option in > log4perl_component() > >The current grep expression uses -x|--line-regexp, but that causes >the regexp to fail to match since we're not specifying a regexp >that can match a whole line. We can either provide a better regexp, >or remove that --line-regexp option. > >This patch removes the --line-regexp (ie -x) option from the grep >in log4perl_component, so that it detects logger components correctly. > >To Test: >0) Apply patch >1) Build Koha package >2) Look at /etc/koha/sites/kohadev/log4perl.conf in an existing >Koha instance (e.g. on koha-testing-docker), and note it has >components for z3950, api, and sip >3) Install package >4) Note that /etc/koha/sites/kohadev/log4perl.conf is the same as before >5) Remove the "log4perl.logger.sip and log4perl.appender.SIP lines from >/etc/koha/sites/kohadev/log4perl.conf >6) Reinstall package >7) Note that the missing lines have been appended to the file at >/etc/koha/sites/kohadev/log4perl.conf > >Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > debian/koha-common.postinst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/debian/koha-common.postinst b/debian/koha-common.postinst >index b645b470ce1..af595fa4ce5 100644 >--- a/debian/koha-common.postinst >+++ b/debian/koha-common.postinst >@@ -136,7 +136,7 @@ log4perl_component() > local config=$1 > local component=$2 > >- if grep -q -x "log4perl.logger.$component" $config; then >+ if grep -q "log4perl.logger.$component" $config; then > return 0 > else > return 1 >-- >2.26.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 25524
:
105006
|
105123
| 105125