Attachment 105177 Details for Bug 25513 – Bug 25513: DO NOT PUSH - try recreating the failure

[patch] Bug 25513: DO NOT PUSH - try recreating the failure

Bug-25513-DO-NOT-PUSH---try-recreating-the-failure.patch (text/plain), 1.78 KB, created by Jonathan Druart on 2020-05-21 10:54:45 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2020-05-21 10:54:45 UTC

Size: 1.78 KB

patch

obsolete

>From e425b28e1e92de97f03fb97e0aa843bc49cb3ac6 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Thu, 21 May 2020 12:35:34 +0200
>Subject: [PATCH] Bug 25513: DO NOT PUSH - try recreating the failure
>
>This is failing in stretch:
>Stretch with mysql 5.5
>Stretch with 10.1.44-MariaDB-1~bionic (docker-compose.mariadb_d9.yml)
>
>Not on Buster with 10.1.44-MariaDB-1~bionic (docker-compose.mariadb_d9.yml)
>---
> t/db_dependent/api/v1/acquisitions_orders.t | 17 ++++++-----------
> 1 file changed, 6 insertions(+), 11 deletions(-)
>
>diff --git a/t/db_dependent/api/v1/acquisitions_orders.t b/t/db_dependent/api/v1/acquisitions_orders.t
>index c9c6194798..96332cc357 100644
>--- a/t/db_dependent/api/v1/acquisitions_orders.t
>+++ b/t/db_dependent/api/v1/acquisitions_orders.t
>@@ -108,14 +108,16 @@ subtest 'list() tests' => sub {
> 
> subtest 'get() tests' => sub {
> 
>-    plan tests => 6;
>-
>-    $schema->storage->txn_begin;
>+    plan tests => 3;
> 
>     my $order = $builder->build_object(
>         {
>             class => 'Koha::Acquisition::Orders',
>-            value => { orderstatus => 'new' }
>+            value => {
>+                orderstatus => 'new',
>+                ecost_tax_excluded => 9963405519357589504,
>+                unitprice => 10177559957753600000
>+            }
>         }
>     );
>     my $patron = $builder->build_object({
>@@ -131,13 +133,6 @@ subtest 'get() tests' => sub {
>       ->json_is( '' => $order->to_api, 'SWAGGER3.3.2' );
> 
>     my $non_existent_order_id = $order->ordernumber;
>-    $order->delete;
>-
>-    $t->get_ok( "//$userid:$password@/api/v1/acquisitions/orders/" . $non_existent_order_id )
>-      ->status_is(404)
>-      ->json_is( '/error' => 'Order not found' );
>-
>-    $schema->storage->txn_rollback;
> };
> 
> subtest 'add() tests' => sub {
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 25513: 105170 | 105175 | 105177 | 105265 | 105317 | 105393 | 105394 | 105395