Attachment 105184 Details for Bug 14708 – Bug 14708: The patron set as the anonymous patron should not be deletable.

[patch] Bug 14708: The patron set as the anonymous patron should not be deletable.

Bug-14708-The-patron-set-as-the-anonymous-patron-s.patch (text/plain), 2.82 KB, created by Katrin Fischer on 2020-05-21 13:06:26 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2020-05-21 13:06:26 UTC

Size: 2.82 KB

patch

obsolete

>From c42263121f6102f62b426fcad01d7758f21c5e83 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Wed, 27 Feb 2019 06:59:08 -0500
>Subject: [PATCH] Bug 14708: The patron set as the anonymous patron should not
> be deletable.
>
>Right now it's possible to delete the anonymous patron at any time. When this happens the system will break just as if anonymouspatron was unset but patrons still have an "always anonymize" privacy setting.
>
>This issue occurs more frequently than one would expect.
>
>We should make it so that the patron set in AnonymousPatron is not deletable.
>
>Test Plan:
>1) Apply this patch
>2) Set a patron to by AnonymousPatron
>3) Attempt to delete that patron from the members toolbar
>4) Note the error message!
>
>Signed-off-by: Devinim <kohadevinim@devinim.com.tr>
>
>Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt | 4 ++++
> members/deletemem.pl                                          | 7 +++++++
> 2 files changed, 11 insertions(+)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
>index a6016d68d1..eff802f788 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
>@@ -49,6 +49,10 @@
>                                 <h3>Unable to delete patrons from other libraries with current settings</h3>
>                                 <p>Insufficient privileges.</p>
>                             [% END %]
>+                            [% IF ( error == 'CANT_DELETE_ANONYMOUS_PATRON' ) %]
>+                                <h3>Unable to delete patron that is set as AnonymousPatron</h3>
>+                                <p>This patron cannot be deleted while set as AnonymousPatron in the system preferences.</p>
>+                            [% END %]
>                             [% IF ( error == 'CANT_DELETE' ) %]
>                                 <h3>Unable to delete patron</h3>
>                                 <p>Insufficient privileges.</p>
>diff --git a/members/deletemem.pl b/members/deletemem.pl
>index 12eac49339..15e97e6b1a 100755
>--- a/members/deletemem.pl
>+++ b/members/deletemem.pl
>@@ -83,6 +83,13 @@ if (C4::Context->preference("IndependentBranches")) {
>     }
> }
> 
>+if ( my $anonymous_patron = C4::Context->preference("AnonymousPatron") ) {
>+    if ( $patron->id eq $anonymous_patron ) {
>+        print $input->redirect("/cgi-bin/koha/members/moremember.pl?borrowernumber=$member&error=CANT_DELETE_ANONYMOUS_PATRON");
>+        exit 0;    # Exit without error
>+    }
>+}
>+
> my $op = $input->param('op') || 'delete_confirm';
> my $dbh = C4::Context->dbh;
> my $is_guarantor = $patron->guarantee_relationships->count;
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 14708: 85766 | 85770 | 85783 | 85789 | 103026 | 103027 | 103028 | 103922 | 105024 | 105025 | 105026 | 105027 | 105028 | 105029 | 105184 | 105185 | 105186 | 105187 | 105188 | 105189 | 112830 | 112831 | 112922 | 113121