Attachment 105212 Details for Bug 20783 – Bug 20783: Similar changes for OPAC

[patch] Bug 20783: Similar changes for OPAC

Bug-20783-Similar-changes-for-OPAC.patch (text/plain), 3.10 KB, created by Katrin Fischer on 2020-05-21 14:41:25 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2020-05-21 14:41:25 UTC

Size: 3.10 KB

patch

obsolete

>From d963e1c20f1a2a38a2f7b47f634f891b37074fde Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 12 May 2020 15:13:44 +0200
>Subject: [PATCH] Bug 20783: Similar changes for OPAC
>
>Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com>
>
>Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com>
>
>Signed-off-by: Jessica Zairo <jzairo@bywatersolutions.com>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 17 +++++++++++------
> 1 file changed, 11 insertions(+), 6 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
>index b6c926dbf1..b7bb3b0025 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
>@@ -551,7 +551,7 @@
>                             <li id="tab_images"><a href="#images">Images</a></li>
>                         [% END %]
> 
>-                        [% IF ( HTML5MediaEnabled && HTML5MediaSets ) %]
>+                        [% IF HTML5MediaEnabled && HTML5MediaSets.size %]
>                             [% IF ( defaulttab == 'media' ) %]<li id="tab_html5media" class="ui-tabs-active">[% ELSE %]<li id="tab_html5media">[% END %]<a href="#html5media">Play media</a></li>
>                         [% END %]
> 
>@@ -955,11 +955,16 @@
>                             <div id="html5media">
>                               [% FOREACH HTML5MediaSet IN HTML5MediaSets %]
>                                 <p>
>-                                  [% SET ctrl_preload = ' controls preload=none' #translatability %]
>-                                  <[% HTML5MediaParent _ ctrl_preload | html %] >
>-                                    <[% HTML5MediaSet.child | html %] src="[% HTML5MediaSet.srcblock | html %]" [% HTML5MediaSet.typeblock | html %] />
>-                                    <span>[[% HTML5MediaParent | html %] tag not supported by your browser.]</span>
>-                                  </[% HTML5MediaParent | html %]>
>+                                    [% IF HTML5MediaSet.is_youtube %]
>+                                        <iframe id="player" type="text/html" width="640" height="360"
>+                                            src="[% HTML5MediaSet.srcblock %]" frameborder="0"></iframe>
>+                                    [% ELSE %]
>+                                        [% SET ctrl_preload = ' controls preload=none' #translatability %]
>+                                        <[% HTML5MediaParent _ ctrl_preload | html %] >
>+                                          <[% HTML5MediaSet.child | html %] src="[% HTML5MediaSet.srcblock | html %]" [% HTML5MediaSet.typeblock | html %] />
>+                                          <span>[[% HTML5MediaParent | html %] tag not supported by your browser.]</span>
>+                                        </[% HTML5MediaParent | html %]>
>+                                    [% END %]
>                                 </p>
>                               [% END %]
>                             </div>
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 20783: 75441 | 75442 | 75443 | 79829 | 79833 | 104747 | 104748 | 104771 | 104774 | 104779 | 104780 | 104781 | 104799 | 104800 | 105198 | 105210 | 105211 | 105212 | 105213 | 111177 | 111178 | 111179