Bugzilla – Attachment 10522 Details for
Bug 6679
Fixing code so it passes basic Perl::Critic tests
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 6679 - fix 2 perlcritic violations in C4/Utils.pm
Bug-6679---fix-2-perlcritic-violations-in-C4Utilsp.patch (text/plain), 906 bytes, created by
Mason James
on 2012-06-26 20:37:54 UTC
(
hide
)
Description:
Bug 6679 - fix 2 perlcritic violations in C4/Utils.pm
Filename:
MIME Type:
Creator:
Mason James
Created:
2012-06-26 20:37:54 UTC
Size:
906 bytes
patch
obsolete
>From a6c0a99167fd69e5e100a3c26f9d4c52b907dc4b Mon Sep 17 00:00:00 2001 >From: Mason James <mtj@kohaaloha.com> >Date: Wed, 27 Jun 2012 04:57:58 +1200 >Subject: [PATCH] Bug 6679 - fix 2 perlcritic violations in C4/Utils.pm >Content-Type: text/plain; charset="utf-8" >http://koha-community.org > >Subroutine prototypes used at line 38, column 1. See page 194 of PBP. (Severity: 5) > >Subroutine prototypes used at line 43, column 1. See page 194 of PBP. (Severity: 5) >--- > C4/Utils.pm | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/C4/Utils.pm b/C4/Utils.pm >index 31d50eb..dac9423 100644 >--- a/C4/Utils.pm >+++ b/C4/Utils.pm >@@ -35,12 +35,12 @@ BEGIN { > } > > >-sub maxwidth (@) { >+sub maxwidth { > (@_) or return 0; > return (sort {$a <=> $b} map {length} @_)[-1]; > } > >-sub hashdump ($$) { >+sub hashdump { > my $pre = shift; > my $val = shift; > if (ref($val) =~ /HASH/) { >-- >1.7.2.5
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=10522">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 6679
:
4883
|
4884
|
4885
|
4886
|
4887
|
4888
|
5445
|
5446
|
5483
|
5487
|
6121
|
6122
|
6123
|
6139
|
6140
|
6141
|
6142
|
6143
|
6144
|
6270
|
6271
|
6663
|
6670
|
6675
|
6676
|
6677
|
6678
|
8542
|
8897
|
8898
|
8899
|
8950
|
8951
|
9746
|
9747
|
9748
|
9749
|
9750
|
10050
|
10051
|
10052
|
10053
|
10054
|
10075
|
10076
|
10077
|
10078
|
10079
|
10484
|
10485
|
10486
|
10487
|
10488
|
10489
|
10491
|
10492
|
10493
|
10494
|
10495
|
10496
|
10497
|
10499
|
10500
|
10501
|
10502
|
10503
|
10504
|
10505
|
10506
|
10507
|
10508
|
10509
|
10510
|
10512
|
10513
|
10514
|
10515
|
10517
|
10521
|
10522
|
10523
|
10524
|
10525
|
10526
|
10527
|
10935
|
10936
|
10938
|
10940
|
10944
|
10945
|
10946
|
10947
|
10948
|
10949
|
10950
|
10952
|
10953
|
10955
|
10957
|
10958
|
10959
|
10960
|
10961
|
10962
|
10963
|
10964
|
10965
|
10966
|
10967
|
10972
|
10976
|
10979
|
10980
|
10981
|
12224
|
12363
|
12490
|
12491
|
12492
|
34191
|
34192
|
34193
|
34194
|
34195
|
34196
|
34197
|
39100
|
39101
|
39102
|
39392
|
39393
|
39394
|
39395
|
39396
|
39397
|
39398
|
42770
|
47086
|
47087
|
47088
|
47089
|
47090
|
47178
|
47179
|
47180
|
47181
|
47205
|
47206
|
47207
|
47208