Attachment 105358 Details for Bug 25492 – Bug 25492: Your Account Menu button does nothing on mobile devices

[patch] Bug 25492: Your Account Menu button does nothing on mobile devices

Bug-25492-Your-Account-Menu-button-does-nothing-on.patch (text/plain), 1.84 KB, created by David Nind on 2020-05-26 12:06:43 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2020-05-26 12:06:43 UTC

Size: 1.84 KB

patch

obsolete

>From ae9408b2b1a32a6cd132c32ebf76fb76c53025c3 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Sat, 23 May 2020 14:35:45 +0000
>Subject: [PATCH] Bug 25492: Your Account Menu button does nothing on mobile
> devices
>
>This patch removes some redundant code from the OPAC JavaScript which
>was causing problems with the show/hide action on two controls which are
>shown only at narrower browser widths: The "Your account" menu shown
>when the user is on a user-related page, and the "Refine your search"
>menu shown on the search results page.
>
>To test, apply the patch and go to the OPAC. Narrow your browser width
>to below 768 pixels.
>
> - Perform a search.
> - On the search results page you should see a "Refine your search"
>   link at the top of the results. Clicking it should expand and
>   collapse the facets menu.
> - Log in to the OPAC.
> - On the "Your summary" page there should be a "Your account menu" link
>   at the top of the main part of the page. Clicking it should expand
>   and collapse the account menu.
> - Verify that these menus display correctly when you widen and narrow
>   the browser window.
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> koha-tmpl/opac-tmpl/bootstrap/js/script.js | 6 ------
> 1 file changed, 6 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/js/script.js b/koha-tmpl/opac-tmpl/bootstrap/js/script.js
>index 6bd94be58d..0d10eb8d9f 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/js/script.js
>+++ b/koha-tmpl/opac-tmpl/bootstrap/js/script.js
>@@ -62,12 +62,6 @@ $(document).ready(function(){
>         }
>     });
> 
>-    $(".menu-collapse-toggle").on("click",function(e){
>-        e.preventDefault();
>-        $(this).toggleClass("menu-open");
>-        $(".menu-collapse").toggle();
>-    });
>-
>     $(".loginModal-trigger").on("click",function(e){
>         e.preventDefault();
>         $("#loginModal").modal("show");
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 25492: 105302 | 105358 | 105427