Bugzilla – Attachment 105372 Details for
Bug 25601
Error when unsetting default checkout, hold and return policy for a specific library
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 25601: (bug 18928 follow-up) Fix "Unset" for "return policy for $branch"
Bug-25601-bug-18928-follow-up-Fix-Unset-for-return.patch (text/plain), 1.78 KB, created by
Victor Grousset/tuxayo
on 2020-05-27 01:39:34 UTC
(
hide
)
Description:
Bug 25601: (bug 18928 follow-up) Fix "Unset" for "return policy for $branch"
Filename:
MIME Type:
Creator:
Victor Grousset/tuxayo
Created:
2020-05-27 01:39:34 UTC
Size:
1.78 KB
patch
obsolete
>From c45cfdf179c3145c7d5c20a16b180b9ce77dae6c Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 26 May 2020 10:10:52 +0200 >Subject: [PATCH] Bug 25601: (bug 18928 follow-up) Fix "Unset" for "return > policy for $branch" > >returnbranch has to pass an itemtype key when setting the rule (here >setting it to unlimited for any item types) > >Test plan: >1. Go the "Circulation and fine rules" admin page >2. Set a rule for "Default checkout, hold and return policy" >3. Unset it >4. Select a library >5. Set a rule for "Default checkout, hold and return policy" >6. Unset it > >Display should be consistent with what you selected > >Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> >--- > admin/smart-rules.pl | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/admin/smart-rules.pl b/admin/smart-rules.pl >index 6bea920dd9..195ca818af 100755 >--- a/admin/smart-rules.pl >+++ b/admin/smart-rules.pl >@@ -161,6 +161,7 @@ elsif ($op eq 'delete-branch-cat') { > branchcode => $branch, > categorycode => undef, > rules => { >+ max_holds => undef, > patron_maxissueqty => undef, > patron_maxonsiteissueqty => undef, > } >@@ -169,11 +170,11 @@ elsif ($op eq 'delete-branch-cat') { > Koha::CirculationRules->set_rules( > { > branchcode => $branch, >+ itemtype => undef, > rules => { > holdallowed => undef, > hold_fulfillment_policy => undef, > returnbranch => undef, >- max_holds => undef, > } > } > ); >-- >2.26.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 25601
:
105348
|
105372
|
105392