Attachment 105379 Details for Bug 25444 – Bug 25444: More minor improvements to simplified loop

[patch] Bug 25444: More minor improvements to simplified loop

Bug-25444-More-minor-improvements-to-simplified-lo.patch (text/plain), 1.08 KB, created by Kyle M Hall (khall) on 2020-05-27 10:29:03 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2020-05-27 10:29:03 UTC

Size: 1.08 KB

patch

obsolete

>From 171b207ca47165e2fb47006a35782664b2214b8e Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Wed, 27 May 2020 06:28:40 -0400
>Subject: [PATCH] Bug 25444: More minor improvements to simplified loop
>
>---
> C4/CourseReserves.pm | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/C4/CourseReserves.pm b/C4/CourseReserves.pm
>index 6bcb342876..beb45285df 100644
>--- a/C4/CourseReserves.pm
>+++ b/C4/CourseReserves.pm
>@@ -541,10 +541,10 @@ sub _UpdateCourseItem {
>     if ( $course_item->is_enabled ) {
>         my $item_fields = {};
> 
>-        for my $field ( qw( itype ccode location homebranch holdingbranch ) ) {
>+        for my $field ( @FIELDS ) {
> 
>-            my $field_enabled = sprintf "%s_enabled", $field;
>-            my $field_storage = sprintf "%s_storage", $field;
>+            my $field_enabled = $field . '_enabled';
>+            my $field_storage = $field . '_storage';
> 
>             # Find newly enabled field and add item value to storage
>             if ( $params{$field_enabled} && !$course_item->$field_enabled ) {
>-- 
>2.24.1 (Apple Git-126)

Actions: View | Diff | Splinter Review

Attachments on bug 25444: 105361 | 105362 | 105363 | 105364 | 105370 | 105371 | 105378 | 105379 | 105383 | 105384 | 105385 | 105386