Attachment 105391 Details for Bug 25608 – Bug 25608: (bug 23463 follow-up) Fix inventory regression

[patch] Bug 25608: (bug 23463 follow-up) Fix inventory regression

Bug-25608-bug-23463-follow-up-Fix-inventory-regres.patch (text/plain), 2.38 KB, created by Tomás Cohen Arazi (tcohen) on 2020-05-27 12:05:21 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2020-05-27 12:05:21 UTC

Size: 2.38 KB

patch

obsolete

>From f338462e362551415060348d985eb59b4890fb46 Mon Sep 17 00:00:00 2001
>From: Didier Gautheron <didier.gautheron@biblibre.com>
>Date: Wed, 27 May 2020 04:18:58 +0200
>Subject: [PATCH] Bug 25608: (bug 23463 follow-up) Fix inventory regression
>
>Follow-up work
>  commit bbb504c86f5ca0a474365d4839177412f415c4ee
>  Bug 23463: Replace ModItem with Koha::Item->store
>
>Test plan :
>    - Create a biblio with default framework
>    - Create an item with barcode='000AAA1', callnumber='ZZZAAA1'
>    - Create an item with barcode='000AAA2', callnumber='ZZZAAA2'
>    - Create a file 'barecodes.txt' containing 2 lines '000AAA1' and '000AAA2'
>    - Go to inventory tool : /cgi-bin/koha/tools/inventory.pl
>    - Choose file in 'Barcode file'
>    - Enter item callnumber between 'ZZZ' and 'ZZZa'
>    - Check 'Compare barcodes list to results'
>    - Submit
>    => without patch, you get an error trace
>    - Apply patch, it works
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Amended commit title.
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> tools/inventory.pl | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
>diff --git a/tools/inventory.pl b/tools/inventory.pl
>index 13c2f07e967..13b7a538a58 100755
>--- a/tools/inventory.pl
>+++ b/tools/inventory.pl
>@@ -199,13 +199,10 @@ if ( $uploadbarcodes && length($uploadbarcodes) > 0 ) {
>         } else {
>             my $item = Koha::Items->find({barcode => $barcode});
>             if ( $item ) {
>-                my $item_unblessed = $item->unblessed;
>                 # Modify date last seen for scanned items, remove lost status
>                 $item->set({ itemlost => 0, datelastseen => $date })->store;
>+                my $item_unblessed = $item->unblessed;
>                 $moddatecount++;
>-                # update item hash accordingly
>-                $item_unblessed->{itemlost} = 0;
>-                $item_unblessed->{datelastseen} = $date;
>                 unless ( $dont_checkin ) {
>                     $qonloan->execute($barcode);
>                     if ($qonloan->rows){
>@@ -219,7 +216,7 @@ if ( $uploadbarcodes && length($uploadbarcodes) > 0 ) {
>                         }
>                     }
>                 }
>-                push @scanned_items, $item;
>+                push @scanned_items, $item_unblessed;
>             } else {
>                 push @errorloop, { barcode => $barcode, ERR_BARCODE => 1 };
>             }
>-- 
>2.26.2

Actions: View | Diff | Splinter Review

Attachments on bug 25608: 105373 | 105377 | 105391