Bugzilla – Attachment 105393 Details for
Bug 25513
Integer casting in Koha::Object->TO_JSON causes random test failures
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 25513: Regression tests
Bug-25513-Regression-tests.patch (text/plain), 1.61 KB, created by
Tomás Cohen Arazi (tcohen)
on 2020-05-27 13:05:17 UTC
(
hide
)
Description:
Bug 25513: Regression tests
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2020-05-27 13:05:17 UTC
Size:
1.61 KB
patch
obsolete
>From a3082ade79834af66b232ef16d2724271d235fcd Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Wed, 27 May 2020 09:55:16 -0300 >Subject: [PATCH] Bug 25513: Regression tests > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > t/db_dependent/api/v1/acquisitions_orders.t | 19 ++++++++++++++++++- > 1 file changed, 18 insertions(+), 1 deletion(-) > >diff --git a/t/db_dependent/api/v1/acquisitions_orders.t b/t/db_dependent/api/v1/acquisitions_orders.t >index c9c61947980..830f1092c8f 100644 >--- a/t/db_dependent/api/v1/acquisitions_orders.t >+++ b/t/db_dependent/api/v1/acquisitions_orders.t >@@ -108,7 +108,7 @@ subtest 'list() tests' => sub { > > subtest 'get() tests' => sub { > >- plan tests => 6; >+ plan tests => 8; > > $schema->storage->txn_begin; > >@@ -137,6 +137,23 @@ subtest 'get() tests' => sub { > ->status_is(404) > ->json_is( '/error' => 'Order not found' ); > >+ # Regression tests for bug 25513 >+ # Pick a high value that could be transformed into exponential >+ # representation and not considered a number by buggy DBD::mysql versions >+ $order = $builder->build_object( >+ { >+ class => 'Koha::Acquisition::Orders', >+ value => { >+ orderstatus => 'new', >+ ecost_tax_excluded => 9963405519357589504, >+ unitprice => 10177559957753600000 >+ } >+ } >+ ); >+ >+ $t->get_ok( "//$userid:$password@/api/v1/acquisitions/orders/" . $order->ordernumber ) >+ ->json_is( '' => $order->to_api, 'Number representation should be consistent' ); >+ > $schema->storage->txn_rollback; > }; > >-- >2.26.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 25513
:
105170
|
105175
|
105177
|
105265
|
105317
| 105393 |
105394
|
105395