Bugzilla – Attachment 105395 Details for
Bug 25513
Integer casting in Koha::Object->TO_JSON causes random test failures
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 25513: Remove unneeded integer casting in Koha::Object->TO_JSON
Bug-25513-Remove-unneeded-integer-casting-in-KohaO.patch (text/plain), 1.66 KB, created by
Tomás Cohen Arazi (tcohen)
on 2020-05-27 13:09:27 UTC
(
hide
)
Description:
Bug 25513: Remove unneeded integer casting in Koha::Object->TO_JSON
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2020-05-27 13:09:27 UTC
Size:
1.66 KB
patch
obsolete
>From f4f7bc28a8463132515e38be2329c2d263ec9f00 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 22 May 2020 14:29:20 +0200 >Subject: [PATCH] Bug 25513: Remove unneeded integer casting in > Koha::Object->TO_JSON > >This patch removes a problematic integer casting happening in TO_JSON. >The original need for this cast (a DBD::mysql bug) is now fixed. We >remove the cast as it is causing random failures. > >To test: >1. Apply the regression tests >2. Run: > $ kshell > k$ prove t/db_dependent/api/v1/acquisitions_orders.t >=> FAIL: Tests fail with select high values (i.e. casting gives wrong > results) >3. Apply this patch >4. Repeat 2 >=> SUCCESS: Tests now pass! >5. Sign off :-D > >Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > Koha/Object.pm | 9 --------- > 1 file changed, 9 deletions(-) > >diff --git a/Koha/Object.pm b/Koha/Object.pm >index ed7cc4bdc9b..44214f85c54 100644 >--- a/Koha/Object.pm >+++ b/Koha/Object.pm >@@ -353,15 +353,6 @@ sub TO_JSON { > ? Mojo::JSON->true > : Mojo::JSON->false; > } >- elsif ( _numeric_column_type( $columns_info->{$col}->{data_type} ) >- and looks_like_number( $unblessed->{$col} ) >- ) { >- >- # TODO: Remove once the solution for >- # https://rt.cpan.org/Ticket/Display.html?id=119904 >- # is ported to whatever distro we support by that time >- $unblessed->{$col} += 0; >- } > elsif ( _datetime_column_type( $columns_info->{$col}->{data_type} ) ) { > eval { > return unless $unblessed->{$col}; >-- >2.26.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 25513
:
105170
|
105175
|
105177
|
105265
|
105317
|
105393
|
105394
| 105395