Bugzilla – Attachment 105489 Details for
Bug 25653
Authorities search does not retain selection
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 25653: Update tab selector to use 'active' and include all options
Bug-25653-Update-tab-selector-to-use-active-and-in.patch (text/plain), 1.75 KB, created by
Nick Clemens (kidclamp)
on 2020-06-02 14:03:07 UTC
(
hide
)
Description:
Bug 25653: Update tab selector to use 'active' and include all options
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2020-06-02 14:03:07 UTC
Size:
1.75 KB
patch
obsolete
>From 68618188a1774499f77165daad7d0a0ad7a09f24 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Tue, 2 Jun 2020 14:00:25 +0000 >Subject: [PATCH] Bug 25653: Update tab selector to use 'active' and include > all options > >It looks like the functionality was broken when ui tabs were upgraded and mainmainentry was added > >To test: >1 - Browse to Authorities >2 - Search in each tab >3 - Note all search results revert to 'Search main heading a only' >4 - Apply patch >5 - Note selection is retained after search >--- > koha-tmpl/intranet-tmpl/prog/en/includes/authorities_js.inc | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/authorities_js.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/authorities_js.inc >index f8043c5cf1..a788fee20a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/authorities_js.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/authorities_js.inc >@@ -78,12 +78,14 @@ $(document).ready(function () { > > var searchType = '[% marclist | html %]'; > if (searchType) { >- if ('mainentry' == searchType) { >- $("#header_search").tabs( "option", "selected", 0 ); >+ if ('mainmainentry' == searchType) { >+ $("#header_search").tabs( "option", "active", 0 ); >+ } else if ('mainentry' == searchType) { >+ $("#header_search").tabs( "option", "active", 1 ); > } else if ('match' == searchType) { >- $("#header_search").tabs( "option", "selected", 1 ); >+ $("#header_search").tabs( "option", "active", 2 ); > } else if ('all' == searchType) { >- $("#header_search").tabs( "option", "selected", 2 ); >+ $("#header_search").tabs( "option", "active", 3 ); > } > } > >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 25653
:
105489
|
105495
|
105570