Bugzilla – Attachment 105507 Details for
Bug 25526
Using Write Off Selected will not allow for a different amount to be written off
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 25526: Allow write off selected of less than or equal to amount
Bug-25526-Allow-write-off-selected-of-less-than-or.patch (text/plain), 1.53 KB, created by
Lucas Gass (lukeg)
on 2020-06-02 22:31:58 UTC
(
hide
)
Description:
Bug 25526: Allow write off selected of less than or equal to amount
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2020-06-02 22:31:58 UTC
Size:
1.53 KB
patch
obsolete
>From 810ac19c6930bed796595d9fc0d57fdaf2f3c032 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Tue, 2 Jun 2020 22:30:00 +0000 >Subject: [PATCH] Bug 25526: Allow write off selected of less than or equal to > amount > >TEST PLAN: >1. Have a fine on a Patron's account. >2. Choose the "Write off Selected" button >3. Enter an amount less than the amount owed by the patron. >4. Koha will give a yellow box with a note "You must collect a value greater than or equal to 2.00." The $2.00 is the amount that is attempted to write off (the amount less than the amount owed). >5. Apply patch >6. Again try to pay an amount less than the amount owed. >7. You should be able to pay it off. >8. Try paying an amount more than owed, you should still get an error. You shouldn't be able to write off more than the amount. >9. Make sure 'Pay selected' still works as it should. >--- > members/paycollect.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/members/paycollect.pl b/members/paycollect.pl >index 43c52c7c7b..b1b9cc4938 100755 >--- a/members/paycollect.pl >+++ b/members/paycollect.pl >@@ -166,7 +166,7 @@ if ( $total_paid and $total_paid ne '0.00' ) { > error_over => 1, > total_due => $total_due > ); >- } elsif ( $total_collected < $total_paid && !( $writeoff_individual || $type eq 'writeoff') ) { >+ } elsif ( $total_collected < $total_paid && ( $writeoff_individual || $type eq 'writeoff') ) { > $template->param( > error_under => 1, > total_paid => $total_paid >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 25526
:
105507
|
105528
|
105625
|
105627
|
105637
|
105856