Attachment 105596 Details for Bug 25638 – Bug 25638: Revert "Bug 25513: Remove unneeded integer casting in Koha::Object->TO_JSON"

[patch] Bug 25638: Revert "Bug 25513: Remove unneeded integer casting in Koha::Object->TO_JSON"

Bug-25638-Revert-Bug-25513-Remove-unneeded-integer.patch (text/plain), 1.29 KB, created by Tomás Cohen Arazi (tcohen) on 2020-06-05 18:56:07 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2020-06-05 18:56:07 UTC

Size: 1.29 KB

patch

obsolete

>From 8b122ff2e6e65c2164cea57986d82b03590b2ab7 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 2 Jun 2020 14:36:43 +0200
>Subject: [PATCH] Bug 25638: Revert "Bug 25513: Remove unneeded integer casting
> in Koha::Object->TO_JSON"
>
>This reverts commit a79cf4150e8a08e743acc7d7147af91757d7a9b8.
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> Koha/Object.pm | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
>diff --git a/Koha/Object.pm b/Koha/Object.pm
>index 44214f85c54..ed7cc4bdc9b 100644
>--- a/Koha/Object.pm
>+++ b/Koha/Object.pm
>@@ -353,6 +353,15 @@ sub TO_JSON {
>                 ? Mojo::JSON->true
>                 : Mojo::JSON->false;
>         }
>+        elsif ( _numeric_column_type( $columns_info->{$col}->{data_type} )
>+            and looks_like_number( $unblessed->{$col} )
>+        ) {
>+
>+            # TODO: Remove once the solution for
>+            # https://rt.cpan.org/Ticket/Display.html?id=119904
>+            # is ported to whatever distro we support by that time
>+            $unblessed->{$col} += 0;
>+        }
>         elsif ( _datetime_column_type( $columns_info->{$col}->{data_type} ) ) {
>             eval {
>                 return unless $unblessed->{$col};
>-- 
>2.27.0

Actions: View | Diff | Splinter Review

Attachments on bug 25638: 105484 | 105485 | 105582 | 105583 | 105590 | 105595 | 105596 | 105597 | 105598 | 105599 | 105665