Attachment 105599 Details for Bug 25638 – Bug 25638: Update TODO

[patch] Bug 25638: Update TODO

Bug-25638-Update-TODO.patch (text/plain), 2.13 KB, created by Tomás Cohen Arazi (tcohen) on 2020-06-05 18:56:41 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2020-06-05 18:56:41 UTC

Size: 2.13 KB

patch

obsolete

>From fe0be22c88039acd9a2a39ac94cccc5511e7acf3 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Fri, 5 Jun 2020 15:55:28 -0300
>Subject: [PATCH] Bug 25638: Update TODO
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> Koha/Object.pm | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
>diff --git a/Koha/Object.pm b/Koha/Object.pm
>index c6ae91e4efd..bb2a5d8ee8a 100644
>--- a/Koha/Object.pm
>+++ b/Koha/Object.pm
>@@ -360,8 +360,9 @@ sub TO_JSON {
>         ) {
> 
>             # TODO: Remove once the solution for
>-            # https://rt.cpan.org/Ticket/Display.html?id=119904
>+            # https://github.com/perl5-dbi/DBD-mysql/issues/212
>             # is ported to whatever distro we support by that time
>+            # or we move to DBD::MariaDB
>             $unblessed->{$col} += 0;
>         }
>         elsif ( _decimal_column_type( $columns_info->{$col}->{data_type} )
>@@ -369,8 +370,9 @@ sub TO_JSON {
>         ) {
> 
>             # TODO: Remove once the solution for
>-            # https://rt.cpan.org/Ticket/Display.html?id=119904
>+            # https://github.com/perl5-dbi/DBD-mysql/issues/212
>             # is ported to whatever distro we support by that time
>+            # or we move to DBD::MariaDB
>             $unblessed->{$col} += 0.00;
>         }
>         elsif ( _datetime_column_type( $columns_info->{$col}->{data_type} ) ) {
>@@ -410,8 +412,9 @@ sub _datetime_column_type {
> 
> sub _numeric_column_type {
>     # TODO: Remove once the solution for
>-    # https://rt.cpan.org/Ticket/Display.html?id=119904
>+    # https://github.com/perl5-dbi/DBD-mysql/issues/212
>     # is ported to whatever distro we support by that time
>+    # or we move to DBD::MariaDB
>     my ($column_type) = @_;
> 
>     my @numeric_types = (
>@@ -428,8 +431,9 @@ sub _numeric_column_type {
> 
> sub _decimal_column_type {
>     # TODO: Remove once the solution for
>-    # https://rt.cpan.org/Ticket/Display.html?id=119904
>+    # https://github.com/perl5-dbi/DBD-mysql/issues/212
>     # is ported to whatever distro we support by that time
>+    # or we move to DBD::MariaDB
>     my ($column_type) = @_;
> 
>     my @decimal_types = (
>-- 
>2.27.0

Actions: View | Diff | Splinter Review

Attachments on bug 25638: 105484 | 105485 | 105582 | 105583 | 105590 | 105595 | 105596 | 105597 | 105598 | 105599 | 105665