Attachment 105632 Details for Bug 25537 – Bug 25537: Page reload at branchtransfers.pl loses destination branch

[patch] Bug 25537: Page reload at branchtransfers.pl loses destination branch

Bug-25537-Page-reload-at-branchtransferspl-loses-d.patch (text/plain), 2.16 KB, created by Martin Renvoize (ashimema) on 2020-06-08 10:37:15 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2020-06-08 10:37:15 UTC

Size: 2.16 KB

patch

obsolete

>From c2df16b0258d9eacfc410e4d03cfed438d73a813 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Thu, 21 May 2020 13:52:32 -0400
>Subject: [PATCH] Bug 25537: Page reload at branchtransfers.pl loses
> destination branch
>
>At branchtransfers.pl, one selects a destination branch and scans in any
>number of items to generate transfers to that branch. However, anything
>that makes the page reload causes your branch selection to be lost,
>reverting you back to whichever branch comes first alphabetically.
>
>This is an invitation to error when one has a stack of books to
>send all to the same branch. Could that error handling get moved
>into a modal or something that won't reload the page?
>
>Test Plan:
>1) Place a hold on an item and set it to waiting
>2) Initiate a branch transfer from branchtransfers.pl for any branch but
>   the first in the pulldown branch selector
>3) Choose to cancel the hold and transfer
>4) Note the pulldown reverts to the first option
>5) Apply this patch
>6) Repeat steps 1-3
>7) Note the pulldown retains your preveiously selected branch!
>
>Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt
>index 3e7f9e936f..9b3f6a2793 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt
>@@ -46,6 +46,7 @@
>                     [% END %]
>                     <input type="hidden" name="itemnumber" value="[% itemnumber | html %]" />
>                     <input type="hidden" name="borrowernumber" value="[% borrowernumber | html %]" />
>+                    <input type="hidden" name="tobranchcd" value="[% tobranchcd | html %]" />
>                     [% IF ( waiting ) %]
>                         <input type="hidden" name="barcode" value="[% barcode | html %]" />
>                         <input type="hidden" name="request" value="KillWaiting" />
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 25537: 105224 | 105476 | 105632