Attachment 105650 Details for Bug 25695 – Bug 25695: add a missing warning in onboarding.pl

[patch] Bug 25695: add a missing warning in onboarding.pl

Bug-25695-add-a-missing-warning-in-onboardingpl.patch (text/plain), 1005 bytes, created by Slava Shishkin on 2020-06-08 15:26:08 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Slava Shishkin

Created: 2020-06-08 15:26:08 UTC

Size: 1005 bytes

patch

obsolete

>From 91576eb1f87a05ff7bbbab92781ba74a68140ea1 Mon Sep 17 00:00:00 2001
>From: Slava Shishkin <slavashishkin@gmail.com>
>Date: Mon, 8 Jun 2020 18:24:59 +0300
>Subject: [PATCH] Bug 25695: add a missing warning in onboarding.pl
>
>There is a forgotten warning in the second eval block just after
>the same eval block which has warning.
>This makes the error reason not logged. The solution is to add exactly
>the same 'warn $@' in consecutive eval block.
>
>Mentored-by: Andrew Nugged <nugged@gmail.com>
>---
> installer/onboarding.pl | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/installer/onboarding.pl b/installer/onboarding.pl
>index 5d10d23c11..547e74fe9e 100755
>--- a/installer/onboarding.pl
>+++ b/installer/onboarding.pl
>@@ -312,6 +312,7 @@ if ( $step == 5 ) {
>                 push @messages, { code => 'success_on_insert_circ_rule' };
>             }
>             else {
>+                warn $@;
>                 push @messages, { code => 'error_on_insert_circ_rule' };
>             }
>         }
>-- 
>2.17.1

Actions: View | Diff | Splinter Review

Attachments on bug 25695: 105650 | 105998 | 105999 | 106387